Commit graph

1022 commits

Author SHA1 Message Date
Nikhil Bhavikatti
fd6d06ff11 Fix for OOB issue
Sanity check added to prevent number of samples exceeding the timeslot
buffer size to prevent overflow.
2022-09-09 13:42:46 +05:30
Nikhil Bhavikatti
22071e3e10 Fix for OOB issue in DRC
Frame length was not getting updated before DRC processing. Moved the
update to appropriate location.
2022-09-09 13:33:34 +05:30
Nikhil Bhavikatti
089e13f285 Fix for heap buffer overflow
Updated bitbuffer read next to bitbuffer end when it exceeds bitbuffer
end to prevent bytes consumed to be updated incorrectly.
2022-09-09 13:27:44 +05:30
Nikhil Bhavikatti
8e37a351fc Fix for heap buffer overflow
Sanity check added to prevent count bits getting updated to negative
value.
2022-09-09 13:24:14 +05:30
Nikhil Bhavikatti
49b1b8f081 Fix for write access memory violation in USAC process call
When there is failure during the init call, decoder_create_done flag
should be reset before calling initialization again.
2022-09-09 13:17:27 +05:30
Nikhil Bhavikatti
dbedfafd12 Fix for write access memory violation in AAC init call
When there is failure during the init call, header_decode_done flag
should be reset before calling initialization again.
2022-09-09 13:12:00 +05:30
Nikhil Bhavikatti
0ce17e271d Fix for OOB issue
Sanity check added on maximum number of elements to prevent OOB access.
2022-09-09 13:04:47 +05:30
tripti-tiwari
601a6a03ce
Merge pull request #7 from ittiam-systems/oob_fixes
Oob fixes
2022-07-29 18:28:39 +05:30
Nikhil Bhavikatti
a857637600 Fix for Out of bound access issue reported by fuzzer 2022-07-29 17:24:54 +05:30
Rajat Kumar
c9614b8df9 Fix for write null dereferencing in AAC frame decode
Audio Object type(AOT) should be same across init and
execute calls. This check was missing when AOT is
not SBR and PS and hence added as fix for this bug.
For AOTs, SBR and PS since this value is re-read at
a later point, check already present would be fine.

Bug: 196308693
Test: poc in bug
2022-07-27 14:26:18 +05:30
tripti-tiwari
fdb8166ea5
Merge pull request #6 from ittiam-systems/mps_opt
Optimization of MPS module of USAC
2022-07-25 21:52:44 +05:30
Sushanth Patil
9f9b1a4eaf Optimisation changes in esbr synthesis filter block
Some computation were not required when mps and sbr are present.
Added a check to remove them.
2022-07-24 12:30:11 +05:30
Sushanth Patil
3551482d1d Optimisation changes in mps dec module
Added changes to reduce processing loops in cases of
residual bands, pre mix req and phase coding in mps
module.
2022-07-24 11:44:37 +05:30
Sushanth Patil
ec016c95b1 Optimisation changes in ixheaacd_mps_temp_process
ixheaacd_mps_subbandtp() was not required for all mps
configurations. Hence, added checks so its called only
when required.
Also, reduced loop counts when res_bands are present.
2022-07-24 11:34:29 +05:30
Sushanth Patil
acab7bd76a Optimisation changes in ixheaacd_generate_hf
Updated loop count based on number of
qmf channels when MPS is present.
2022-07-24 11:15:54 +05:30
Sushanth Patil
8330107b30 Optimisation changes in mps synt calc module
Converted the mps synt calc module to float module and
reimplemented mps synthesis function.
2022-07-24 11:10:54 +05:30
Sushanth Patil
2aebc58a73 Optimisation changes in ixheaacd_samples_sat
Changed 64-bit operations used for saturating the
output pcm to 32 bit operations targeted towards
32-bit/armv7 architecture.
2022-07-24 11:09:13 +05:30
Sushanth Patil
4d002366a8 Optimisation changes in mps apply pre-matrix and mix-matrix modules
Converted all the computations in these modules to float and
removed all float to int conversion overheads.
2022-07-24 11:05:23 +05:30
Sushanth Patil
1b703a5eea Optimisation changes in mps apply function
Added changes to remove redundant computation
loops in ixheaacd_mps_synt_calc,mps hybrid
analysis & synthesis functions based on number
of non-zero qmf bands.
2022-07-23 21:15:48 +05:30
Sushanth Patil
e73da2db71 Optimisation changes in ixheaacd_mps_upmix_interp
Removed float conversion overheads for
ixheaacd_mps_upmix_interp() function.
2022-07-23 21:01:51 +05:30
Sushanth Patil
7cf8017dd2 Optimisation changes in mps angle & phase interpolation functions
Reduced multiplications using mathematical rearrangement.
2022-07-23 20:59:49 +05:30
Sushanth Patil
d9c6a98804 Optimisation changes in mps hybrid filter functions
Converted the mps hybrid filt module to float
and reduced the number of multiplications in
ixheaacd_mps_hybrid_filt_type1 & type2 functions
using mathematical rearrangement and look-up table
symmetries.
2022-07-23 20:58:14 +05:30
Saketh Sathuvalli
70263ebfe8
Merge pull request #4 from ittiam-systems/Readme_updates
Updated README.md
2022-02-16 10:19:03 +05:30
Annsha Merlin Joseph
fa3be5772b Updated README.md 2022-02-16 10:14:52 +05:30
Saketh Sathuvalli
1cec2d095d
Merge pull request #3 from ittiam-systems/README
Added README.md
2022-02-04 11:53:03 +05:30
Annsha Merlin Joseph
acbbbf0c5b Added README.md 2022-02-04 11:40:06 +05:30
Saketh Sathuvalli
15e5f78ead
Merge pull request #2 from ittiam-systems/api_extensions
Api extensions
2022-01-21 09:28:29 +05:30
Sachin
4c72471cdb Changes to move output sample path from 16bit to 32 bit
AAC Core coder changes to take the output samples as 32 bit
and subject to peak limiter to avoid any clipping , at the
same time maintaining precision.

Bug: 175435457
Test: atest CtsMediaTestCases:DecoderTest
Test: atest CtsMediaTestCases:DecoderTestAacDrc
Test: atest CtsMediaTestCases:DecoderTestXheAac
Test: atest CtsMediaTestCases:DecoderTestAacFormat
Test: atest CtsMediaV2TestCases:CodecDecoderTest
2022-01-20 11:54:35 +05:30
Sachin
8701172d14 Select Expert and Anchor Loudness measurement.
Changes to switch to  Expert Panel as  measurement system
and Anchor Loudness as measurement method depending on stream.

Bug: 175435457
Test: atest CtsMediaTestCases:DecoderTest
Test: atest CtsMediaTestCases:DecoderTestAacDrc
Test: atest CtsMediaTestCases:DecoderTestXheAac
Test: atest CtsMediaTestCases:DecoderTestAacFormat
Test: atest CtsMediaV2TestCases:CodecDecoderTest
2022-01-20 11:53:40 +05:30
Sachin
e8771b7d14 Update configuration parameter's based on change in values.
Check configuration data obtained after audio Pre-Roll
parsing against current configuration. Update only when
configurations are different.

Bug: 175435457
Test: atest CtsMediaTestCases:DecoderTest
Test: atest CtsMediaTestCases:DecoderTestAacDrc
Test: atest CtsMediaTestCases:DecoderTestXheAac
Test: atest CtsMediaTestCases:DecoderTestAacFormat
Test: atest CtsMediaV2TestCases:CodecDecoderTest
2022-01-20 11:53:05 +05:30
Sachin
a281ecf0cd Update Boost and attenuation values for MPEG-D DRC
Extend API Support to change MPEG-D DRC values for boost
and attenuation from plugin.

Bug: 175435457
Test: atest CtsMediaTestCases:DecoderTest
Test: atest CtsMediaTestCases:DecoderTestAacDrc
Test: atest CtsMediaTestCases:DecoderTestXheAac
Test: atest CtsMediaTestCases:DecoderTestAacFormat
Test: atest CtsMediaV2TestCases:CodecDecoderTest
2022-01-20 11:52:31 +05:30
Sachin
ebe61f8ba1 Extend API support for Album Mode.
To extend API support to handle album
mode configuration.

Bug: 175435457
Test: atest CtsMediaTestCases:DecoderTest
Test: atest CtsMediaTestCases:DecoderTestAacDrc
Test: atest CtsMediaTestCases:DecoderTestXheAac
Test: atest CtsMediaTestCases:DecoderTestAacFormat
Test: atest CtsMediaV2TestCases:CodecDecoderTest
2022-01-20 11:51:19 +05:30
Sachin
f7ec92a2c9 Obtain Loudness Info from MPEG-4/MPEG-D DRC stream
Extend API support to query loudness Info
obtained from MPEG-4/MPEG-D DRC stream.

Bug: 175435457
Test: atest CtsMediaTestCases:DecoderTest
Test: atest CtsMediaTestCases:DecoderTestAacDrc
Test: atest CtsMediaTestCases:DecoderTestXheAac
Test: atest CtsMediaTestCases:DecoderTestAacFormat
Test: atest CtsMediaV2TestCases:CodecDecoderTest
2022-01-20 11:50:10 +05:30
Ray Essick
a98bafcb28 Merge "Rename OWNERS-codecs to match naming policies" am: ec70c58e87 am: ba8c412330 am: 55c5e6c2af
Original change: 1619965

MUST ONLY BE SUBMITTED BY AUTOMERGER

Change-Id: I09375de437cb6a493507fe4f0a55280174601a25
2021-03-05 23:18:26 +00:00
Ray Essick
55c5e6c2af Merge "Rename OWNERS-codecs to match naming policies" am: ec70c58e87 am: ba8c412330
Original change: 1619965

MUST ONLY BE SUBMITTED BY AUTOMERGER

Change-Id: Id1a3b0790ecb7e6f71601d1e48a04d6bf11cc61d
2021-03-05 22:32:57 +00:00
Ray Essick
ba8c412330 Merge "Rename OWNERS-codecs to match naming policies" am: ec70c58e87
Original change: 1619965

MUST ONLY BE SUBMITTED BY AUTOMERGER

Change-Id: I63df2c3cedfe7589971d919668e40b1dbebb9c72
2021-03-05 22:00:36 +00:00
Ray Essick
ec70c58e87 Merge "Rename OWNERS-codecs to match naming policies" 2021-03-05 19:18:00 +00:00
Ray Essick
23bbdcab65 Rename OWNERS-codecs to match naming policies
Bug: 181751857
Test: upload/gerrit
Change-Id: I5c99cfecc1a129f25e7734c8a733bfb173510e8c
2021-03-04 19:30:53 -08:00
Xin Li
130b77bec6 [automerger skipped] Mark ab/7061308 as merged in stage. am: 342024bac0 -s ours am: b1135bab42 -s ours
am skip reason: Change-Id I9ab9b7ef95a8127c8c70411a053f6005a5ccd867 with SHA-1 5e3873983e is in history

Original change: undetermined

MUST ONLY BE SUBMITTED BY AUTOMERGER

Change-Id: I8eb446e4bc98526a16f614dedf173184bdd0d947
2021-02-20 12:01:45 +00:00
Xin Li
b1135bab42 [automerger skipped] Mark ab/7061308 as merged in stage. am: 342024bac0 -s ours
am skip reason: Change-Id I9ab9b7ef95a8127c8c70411a053f6005a5ccd867 with SHA-1 5e3873983e is in history

Original change: undetermined

MUST ONLY BE SUBMITTED BY AUTOMERGER

Change-Id: I35742c89caa6f0a669170c5f4977a166402f9b28
2021-02-20 09:50:29 +00:00
Xin Li
342024bac0 Mark ab/7061308 as merged in stage.
Bug: 180401296
Merged-In: I9ab9b7ef95a8127c8c70411a053f6005a5ccd867
Change-Id: Iffb1d6bec2c249445b47f97b5170d95a5c30ef51
2021-02-20 00:24:13 -08:00
Bob Badour
491d316289 [LSC] Add LOCAL_LICENSE_KINDS to external/libxaac am: 39d57e0f7b am: d3457dd00d am: c6a688f83a
Original change: 1588651

MUST ONLY BE SUBMITTED BY AUTOMERGER

Change-Id: I2a77b9c524e0b7b591e1365567f58d93a7a94afa
2021-02-17 17:22:22 +00:00
Bob Badour
c6a688f83a [LSC] Add LOCAL_LICENSE_KINDS to external/libxaac am: 39d57e0f7b am: d3457dd00d
Original change: 1588651

MUST ONLY BE SUBMITTED BY AUTOMERGER

Change-Id: I95d9d0c6d89dcc6a867754de1f5d1c2cddd3506e
2021-02-17 16:47:53 +00:00
Bob Badour
d3457dd00d [LSC] Add LOCAL_LICENSE_KINDS to external/libxaac am: 39d57e0f7b
Original change: 1588651

MUST ONLY BE SUBMITTED BY AUTOMERGER

Change-Id: Ie12bd9da045c95ef3b0408b3e24ee138fbdf596c
2021-02-17 15:54:01 +00:00
Bob Badour
39d57e0f7b [LSC] Add LOCAL_LICENSE_KINDS to external/libxaac
Added SPDX-license-identifier-Apache-2.0 to:
  Android.bp
  fuzzer/Android.bp
  test/Android.bp

Bug: 68860345
Bug: 151177513
Bug: 151953481

Test: m all

Exempt-From-Owner-Approval: janitorial work
Change-Id: I8f70bf816b41ad6d7bb4e473eaab96cc53dc4dde
2021-02-12 18:26:03 -08:00
Cindy Zhou
46e718fa6e Libxaac remove diag am: 3ec6091ef8 am: 2e74869c0f am: b2025665b4
Original change: 1548931

MUST ONLY BE SUBMITTED BY AUTOMERGER

Change-Id: I9fb56e59e9fd840508d99c3a266fe5c209ca7d14
2021-01-21 00:02:07 +00:00
Cindy Zhou
b2025665b4 Libxaac remove diag am: 3ec6091ef8 am: 2e74869c0f
Original change: 1548931

MUST ONLY BE SUBMITTED BY AUTOMERGER

Change-Id: Ibcf0a7d82530596e13d787031e9dd7e28eefaa3e
2021-01-20 23:43:35 +00:00
Cindy Zhou
2e74869c0f Libxaac remove diag am: 3ec6091ef8
Original change: 1548931

MUST ONLY BE SUBMITTED BY AUTOMERGER

Change-Id: I3570404c4aa399f141f2e209a1952828ba373d36
2021-01-20 23:40:10 +00:00
Cindy Zhou
3ec6091ef8 Libxaac remove diag
Removing diag mode since it's only required for debugging purposes.
Bug: 158010610
Test: n/a

Change-Id: Ib2ec5c1a9d5bc8f5f4d48e40f1340f3e4814d451
2021-01-13 12:39:19 -08:00
Cindy Zhou
3f4b1d2d55 Enable cfi for libxaac am: 33385d02d2 am: af592b8c71 am: 0526224005
Original change: 1518098

MUST ONLY BE SUBMITTED BY AUTOMERGER

Change-Id: Ib8877705f76f8fbb1bafd6fbaab66abdc4e5615b
2021-01-08 22:47:59 +00:00