wrapper/libxaac
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
699 commits 10 branches 13 tags 16 MiB
Commit graph

699 commits

This branch
This branch
All branches
Author SHA1 Message Date
Tripti Tiwari
e8f23228d2 Fix for Segv in impd_down_mix function in xaac. am: 72b91f378a am: 1ce1de30ac 
Change-Id: I477303df9aa118aadb1405467097bb01260d0d28
 2020-04-02 19:59:15 +00:00
Tripti Tiwari
1ce1de30ac Fix for Segv in impd_down_mix function in xaac. am: 72b91f378a 
Change-Id: I60184af9afbed5e0c6139df7f142fe710ebdea3f
 2020-04-02 19:32:31 +00:00
Tripti Tiwari
72b91f378a Fix for Segv in impd_down_mix function in xaac. 
Enough size was not allocated for DRC payload.
Added appropriate size to persistence memory to accommodate maximum
length of DRC payload data. Also added reset for bit-handler elements
after execute call.

Bug:141290162
Test: poc in bug

Change-Id: I61176076056899310a3306818cd5ad4624a4bab0
 2020-04-02 09:00:29 -07:00
TreeHugger Robot
7e68b5acbe Merge "Fix for infinite loop in impd_apply_gains_and_add function" into rvc-dev am: dd0c4f77d0 am: a9ef6fb80f 
Change-Id: Iab49a9cab1f65e83dd4731569faed77831c355a3
 2020-04-02 04:32:34 +00:00
TreeHugger Robot
99d1c08cfe Merge "Fix for infinite loop in impd_apply_gains_and_add function" into rvc-dev am: dd0c4f77d0 am: 9b2f2cf8b7 
Change-Id: Ic90e9fffc71c6129e9dc35038762f07fd917698f
 2020-04-02 04:31:23 +00:00
TreeHugger Robot
a9ef6fb80f Merge "Fix for infinite loop in impd_apply_gains_and_add function" into rvc-dev am: dd0c4f77d0 
Change-Id: I6519426e2e19897f6a6b907b023cd57190e7205e
 2020-04-02 04:05:08 +00:00
TreeHugger Robot
9b2f2cf8b7 Merge "Fix for infinite loop in impd_apply_gains_and_add function" into rvc-dev am: dd0c4f77d0 
Change-Id: I97ac4fdaf6c88d3de355f0a804b8fd1ce0edda0e
 2020-04-02 04:04:27 +00:00
Rajat Kumar
3092c26301 Fix for OOB in external libxaac am: 57b4f3eac4 am: dc9da8722e 
Change-Id: I2b0592e8faa1355949bb0855cd8e1728c8c87818
 2020-04-02 03:53:48 +00:00
Rajat Kumar
cd35bc0691 Fix for OOB in external libxaac am: 57b4f3eac4 am: c6045a6064 
Change-Id: I2121520686889e440fc93e6f4307c7fa40cfb466
 2020-04-02 03:53:31 +00:00
TreeHugger Robot
dd0c4f77d0 Merge "Fix for infinite loop in impd_apply_gains_and_add function" into rvc-dev 2020-04-02 03:45:45 +00:00
Rajat Kumar
dc9da8722e Fix for OOB in external libxaac am: 57b4f3eac4 
Change-Id: I6ad790165504b15373184270d0f0840a56253e49
 2020-04-02 03:34:18 +00:00
Rajat Kumar
c6045a6064 Fix for OOB in external libxaac am: 57b4f3eac4 
Change-Id: Iddc26b70d59643c8c45303918438f678f352f63d
 2020-04-02 03:34:09 +00:00
Rajat Kumar
57b4f3eac4 Fix for OOB in external libxaac 
Codec initialization is done with AOT 2 (AAC-LC profile),
but AOT changes abruptly to 42 (USAC profile) in execution
leading to access of uninitialized tables. Hence Added a
check for mismatch in AOT during initialization and
AOT during execution.

Bug:150400335
Test: poc in bug

Change-Id: I73ca2bf0f963df7982c1a8371a8fc0c2e3c7cd82
 2020-03-29 17:16:45 -07:00
Rajat Kumar
fdeb26a3f5 Fix for infinite loop in impd_apply_gains_and_add function 
if (iEnd == iStart) is true until end line of loop,
and (drc_gain_last == shape_filter_block[g].drc_gain_last)
is also true, this make iEnd unchanged for ever
and the while loop will go into infinite iterations.
Hence added a check to break for the same.

Bug:148433653
Bug:151817831
Test:poc in bug

Change-Id: I2a59cde98abee0f28510a5b50ef44b3efd02c079
 2020-03-29 17:08:20 -07:00
TreeHugger Robot
7c64fe9397 Merge "Fix for array out of bound in decoder/drc_src/impd_drc_eq.c" into rvc-dev am: 7862de4bd2 am: d2dbb48fb9 
Change-Id: I4eb91b6dad3fefe6934792b20c89941a687bfc8a
 2020-03-19 19:48:13 +00:00
TreeHugger Robot
81ba29ca03 Merge "Fix for array out of bound in decoder/drc_src/impd_drc_eq.c" into rvc-dev am: 7862de4bd2 am: 439c0bdf9e 
Change-Id: I269990ef1bda4721c6b0f7f95f1fb790d192ea2c
 2020-03-19 19:41:36 +00:00
TreeHugger Robot
d2dbb48fb9 Merge "Fix for array out of bound in decoder/drc_src/impd_drc_eq.c" into rvc-dev am: 7862de4bd2 
Change-Id: I5bbb5700d549fdc9eb50bbf2080dcc46d1097af3
 2020-03-19 19:25:51 +00:00
TreeHugger Robot
439c0bdf9e Merge "Fix for array out of bound in decoder/drc_src/impd_drc_eq.c" into rvc-dev am: 7862de4bd2 
Change-Id: I48739026f3e79803a9e63149d4ea02be7971002c
 2020-03-19 19:24:34 +00:00
TreeHugger Robot
7862de4bd2 Merge "Fix for array out of bound in decoder/drc_src/impd_drc_eq.c" into rvc-dev 2020-03-19 19:07:47 +00:00
Xin Li
6271d9b6cd [automerger skipped] DO NOT MERGE - Empty merge qt-qpr1-dev-plus-aosp@6304901 into stag-aosp-master am: 17570befa3 -s ours am: dbac3acf47 
Change-Id: I09582fae91422b29150ac6b7dc9df4fa4e848d7b
 2020-03-19 04:52:42 +00:00
Xin Li
dbac3acf47 [automerger skipped] DO NOT MERGE - Empty merge qt-qpr1-dev-plus-aosp@6304901 into stag-aosp-master am: 17570befa3 -s ours 
am skip reason: subject contains skip directive

Change-Id: I4330815dd4b2c702c2596d722bea302028cf18ec
 2020-03-19 04:26:02 +00:00
Xin Li
17570befa3 DO NOT MERGE - Empty merge qt-qpr1-dev-plus-aosp@6304901 into stag-aosp-master 
Bug: 151763422
Change-Id: Iad5dbf0139aac64725c98d86c9b98a8189e2bc47
 2020-03-18 19:40:38 -07:00
Sushanth Patil
40fb6f798f Fix for array out of bound in decoder/drc_src/impd_drc_eq.c 
Error return check was missing, which caused an
unchecked value to propagate and lead to array OOB.

Bug: 151407605
Test: poc in bug

Change-Id: I0ab9ced7504314e0a31fbe7138c0b95ecbc8cd84
 2020-03-18 20:56:48 +00:00
Rajat Kumar
699995ad79 Fix for array out of bound for type 'ia_filt_cascade_td_struct[4]' am: ed2dbffd88 am: e0e06a4675 
Change-Id: I74dc4ef58e954bbf8654965206adf9168977b207
 2020-03-18 18:32:54 +00:00
Rajat Kumar
631677719d Fix for array out of bound for type 'ia_filt_cascade_td_struct[4]' am: ed2dbffd88 am: b3f217933e 
Change-Id: Icc66b74dcf1c8b471a2db9f4292eb86f77110ff1
 2020-03-18 18:32:37 +00:00
Rajat Kumar
b3f217933e Fix for array out of bound for type 'ia_filt_cascade_td_struct[4]' am: ed2dbffd88 
Change-Id: I30fb9ea6aabfc8ecb79ccbab7230a49d8363fc5c
 2020-03-18 18:18:38 +00:00
Rajat Kumar
e0e06a4675 Fix for array out of bound for type 'ia_filt_cascade_td_struct[4]' am: ed2dbffd88 
Change-Id: Ibca74a941c7e94ccc7fc469ed03de5f5e4c2aca3
 2020-03-18 18:17:51 +00:00
Rajat Kumar
ed2dbffd88 Fix for array out of bound for type 'ia_filt_cascade_td_struct[4]' 
Value is read from the bit stream and used as index
before checking for bounds, added the same as fix here.

Bug: 151412914
Test: poc in bug

Change-Id: I2f484398d87bee0a525e4f31b4f0da4c1b13bb1d
 2020-03-18 09:09:45 -07:00
Automerger Merge Worker
0128685aa2 Merge "Merge "Fix for missing bound check in MPS bit parsing" into rvc-dev am: 418325e543 am: 81bbfaf816" into rvc-d1-dev-plus-aosp 2020-03-10 05:29:55 +00:00
Automerger Merge Worker
9f2784dd7d Merge "Fix for missing bound check in MPS bit parsing" into rvc-dev am: 418325e543 am: b8d50dbc3a 
Change-Id: I832dcb52a187513e4829b3cdd56ca59c71960477
 2020-03-10 05:29:50 +00:00
Automerger Merge Worker
ece0389dda Merge "Fix for missing bound check in MPS bit parsing" into rvc-dev am: 418325e543 am: 81bbfaf816 
Change-Id: I5750265416a8ca5ab33b0549f5ead9bada63c44a
 2020-03-10 05:29:48 +00:00
Automerger Merge Worker
b8d50dbc3a Merge "Fix for missing bound check in MPS bit parsing" into rvc-dev am: 418325e543 
Change-Id: I90acb99a26a8b6d6911c51f1e8a4114cf4d49ec9
 2020-03-10 05:13:52 +00:00
Automerger Merge Worker
81bbfaf816 Merge "Fix for missing bound check in MPS bit parsing" into rvc-dev am: 418325e543 
Change-Id: Ia0f6a6d3c85ae579d0f9f0acf24ed6fcbacf279a
 2020-03-10 05:13:38 +00:00
TreeHugger Robot
418325e543 Merge "Fix for missing bound check in MPS bit parsing" into rvc-dev 2020-03-10 04:51:59 +00:00
Automerger Merge Worker
d71716b635 Remove mips workarounds. am: a4398eccb8 am: 1e1ae5bdbf am: c7ab425cb7 
Change-Id: I48754558fa0549be934d30fa8c66d6f5d68e0a6a
 2020-03-10 00:56:15 +00:00
Automerger Merge Worker
05c0158bfb Remove mips workarounds. am: a4398eccb8 am: 1e1ae5bdbf 
Change-Id: I41e3ca1bfa0e8b9f41ed82b6a6451e1d5e0a58f5
 2020-03-10 00:34:53 +00:00
Automerger Merge Worker
c7ab425cb7 Remove mips workarounds. am: a4398eccb8 am: 1e1ae5bdbf 
Change-Id: I6a3885975c9d16551afe9a9bc4bf8c384e0fc741
 2020-03-10 00:34:47 +00:00
Automerger Merge Worker
1e1ae5bdbf Remove mips workarounds. am: a4398eccb8 
Change-Id: Ie4c5016c7cd2d2af3e2bd88538b478f2e5b7adc5
 2020-03-10 00:20:30 +00:00
Automerger Merge Worker
964c7e1856 Merge "Fix for SEGV in ixheaacd_aacdec_decodeframe function." into rvc-dev am: 4bbb59d953 am: b1e88aa7db 
Change-Id: I1ba4737ea8dedac386f9bdf79b6cff90e707d12c
 2020-03-09 22:55:59 +00:00
Automerger Merge Worker
5986d45e5d Merge "Fix for read buffer overflow in impd_filter_banks_process" into rvc-dev am: 3eb739ab1d am: f8db1cecb4 
Change-Id: I2de914f2c0df79bc0121275b7ec1b06e18ec6411
 2020-03-09 22:55:54 +00:00
Automerger Merge Worker
996c24bdbe Merge "Fix for SEGV in ixheaacd_aacdec_decodeframe function." into rvc-dev am: 4bbb59d953 am: d62346230c 
Change-Id: I6350732aec68dd2b74fb3d94e353f4ce65b76e0b
 2020-03-09 22:55:45 +00:00
Automerger Merge Worker
f9aed9f6fe Merge "Fix for read buffer overflow in impd_filter_banks_process" into rvc-dev am: 3eb739ab1d am: a9104ef896 
Change-Id: Idf7933ce0d522d2228233d9d2dfbbd64a858f5c6
 2020-03-09 22:55:36 +00:00
Automerger Merge Worker
b1e88aa7db Merge "Fix for SEGV in ixheaacd_aacdec_decodeframe function." into rvc-dev am: 4bbb59d953 
Change-Id: I686cbb29d1801ed8641253c1099cbbd566bc603f
 2020-03-09 22:43:19 +00:00
Automerger Merge Worker
d62346230c Merge "Fix for SEGV in ixheaacd_aacdec_decodeframe function." into rvc-dev am: 4bbb59d953 
Change-Id: I083914e729a5dd44c756b50eed1490a56d3669e7
 2020-03-09 22:43:17 +00:00
Automerger Merge Worker
f8db1cecb4 Merge "Fix for read buffer overflow in impd_filter_banks_process" into rvc-dev am: 3eb739ab1d 
Change-Id: Iaeb045a93a1113b2cc4f9f34c424f89af87efbd6
 2020-03-09 22:43:12 +00:00
Automerger Merge Worker
a9104ef896 Merge "Fix for read buffer overflow in impd_filter_banks_process" into rvc-dev am: 3eb739ab1d 
Change-Id: I19c260f79d9a1a60df7c2dfd1ed37d2f093a30ee
 2020-03-09 22:43:07 +00:00
TreeHugger Robot
4bbb59d953 Merge "Fix for SEGV in ixheaacd_aacdec_decodeframe function." into rvc-dev 2020-03-09 22:30:23 +00:00
TreeHugger Robot
3eb739ab1d Merge "Fix for read buffer overflow in impd_filter_banks_process" into rvc-dev 2020-03-09 22:27:29 +00:00
Tripti Tiwari
f034dda6d2 Fix for SEGV in ixheaacd_aacdec_decodeframe function. 
For erroneous stream, coupling channel initialization memory
was overlapping with SBR scratch memory usage, causing unwanted
reset of the some of the pointers.
All initialization should take place in persistent memory.
As a fix, replaced scratch with persistent memory for initialization.

Bug:145264510
Test:poc in bug

Change-Id: Iaa757d0e87fd3a0b2f75c5288cfe662f556c871f
 2020-03-07 15:07:54 -08:00
Rajat Kumar
5426a0bf19 Fix for read buffer overflow in impd_filter_banks_process 
str_node[k].time is used as index later, added a check
where its calculated.

Bug:146948608
Test:poc in bug

Change-Id: I35ca08ad19045deca44b5b5c55532a84f5a58ed3
 2020-03-07 15:00:27 -08:00