Commit graph

1175 commits

Author SHA1 Message Date
ShashankPathmudi
12e2e71b24
Fix for Heap-buffer-overflow in Codec__decodeXAACStream (#85)
These changes fix the Heap-buffer-overflow in Codec__decodeXAACStream runtime error
caused due to unsupported frame length type configuration for LATM streams.

Bug: ossFuzz:67767
Test: poc in bug
2024-04-16 17:58:40 +05:30
akshayragir833
da04d9de78
Encoder enhancements (#84)
Tests done: smoke test
2024-03-29 17:36:14 +05:30
ShashankPathmudi
d880b2f9ee
Decoder Enhancements (#82)
Significance:
========
[x] Aligned buffer access for scratch memory and scratch memory optimization.

Testing:
=====
[x] MSVS Conformance and CTS are passing.
[x] All previous fuzzer crashes are tested. No crash observed.
[x] For platforms, Conformance tested with different combinations.
[x] Tested Conformance with gcc builds for x86, x86_64, armv7 and armv8.
[x] Tested Conformance with clang builds with address and memory sanitizer flags for x86_64 and armv8.
2024-03-29 09:49:01 +05:30
Elliott Hughes
226c46decb Remove useless neon: clause.
There hasn't been a non-neon platform build in years. Even the NDK hasn't supported non-neon for two years now.

Change-Id: I1d892e8bd97371a87771183655c1e5803a7e4400
2024-03-27 07:53:54 -07:00
Akshay Ragir
ed65992ff0 Fix for the Heap-buffer-overflow READ 1 in ixheaace_process
These changes handle the heap buffer overflow runtime error
by reducing the maximum number of loudnessInfo blocks supported.

Bug: ossFuzz: 67273
Test: poc in bug
2024-03-15 17:24:52 +05:30
Akshay Ragir
0cdc7e8df4 Aligned fuzzer application with the test application 2024-03-15 17:24:52 +05:30
akshayragir833
58381f7993
Audio pre-roll and loudness measurement support for USAC (#79)
Tests done: Smoke test
2024-03-06 15:13:14 +05:30
akshayragir833
d0702a8795
Aligned encoder with the latest changes in common directory (#78)
[x] Tests done: Smoke test
2024-01-22 18:19:16 +05:30
ShashankPathmudi
e6fd2784fc
Decoder Enhancements (#77)
[x] Aligned buffer access for persistent memory.
2024-01-16 21:38:46 +05:30
akshayragir833
63d6a41982
USAC encoder enhancements and internal bug fixes (#76)
Tests done: Smoke test
2024-01-12 13:05:51 +05:30
akshayragir833
87f206b42d
Fix for the Use-of-uninitialized-value in ixheaace_frame_info_generator (#75)
These changes handle the runtime error reported by preventing the
inappropriate access of uninitialized member from a structure.

Bug: ossFuzz: 65422
Test: poc in bug
2024-01-02 19:07:05 +05:30
ShashankPathmudi
59ab6ada33
Fix for global buffer overflow in MPS module (#74) 2023-12-29 17:16:17 +05:30
akshayragir833
1ce177ea0e
Encoder enhancements and minor bug fixes (#73)
Test done: Smoke test
2023-12-28 17:47:33 +05:30
tripti-tiwari
a7019eafff
Merge pull request #72 from ittiam-systems/decoder_bug_fixes
Decoder Bug Fixes
2023-12-26 09:21:35 +05:30
Shashank Pathmudi
0889ef458d Fix for potential divide-by-zero issue observed during code inspection 2023-12-22 19:25:42 +05:30
ShashankPathmudi
daf21a984e
Fix for divide-by-zero in ixheaacd_mps_frame_decode (#71)
These changes handle the divide-by-zero runtime error reported
while calculating the inverse of difference between consecutive
parameter time slot.

Bug: ossFuzz:65191
Test: poc in bug
2023-12-22 19:03:04 +05:30
tripti-tiwari
9b21ecaae1
Merge pull request #70 from ittiam-systems/decoder_bug_fixes
Decoder Bug Fixes
2023-12-18 16:43:37 +05:30
Shashank Pathmudi
2624ae15b4 Fix for Heap-buffer-overflow WRITE 8 in ixheaacd_init_sbr
These changes handle the Heap-buffer-overflow WRITE 8 runtime error reported
due to unsupported channel configuration for USAC.

Bug: ossFuzz:64960
Test: poc in bug
2023-12-18 16:20:32 +05:30
akshayragir833
b5c3233a7a
Sanitization of configuration parameters (#69) 2023-12-11 17:37:51 +05:30
Akshay Ragir
86eb72d8eb Fix for the Global-buffer-overflow READ 4 in iaace_estimate_scfs_chan
These changes handle the 960 frame length
support for SBR and PS profiles.

Bug: ossFuzz: 64532
Test: poc in bug
2023-11-27 20:00:46 +05:30
Shashank Pathmudi
cc7ce80ec3 Fix for write access violation and divide by zero in MPS module 2023-11-27 13:56:59 +05:30
Akshay Ragir
9b18e51b8a Updated Fuzzer application to improve code coverage 2023-11-16 09:24:49 +05:30
Akshay Ragir
695799b8b6 Fix for the Null-dereference READ in ixheaace_write_bits
This change handles the error reported while processing
individual bitstream element in case of multi-channel streams.

Bug: ossFuzz: 64022
Test: poc in bug
2023-11-16 09:24:49 +05:30
Harish Mahendrakar
10a262f43c Android.bp: Fix riscv64 build for decoder
- Add appropriate entries in Android.bp for riscv64 for decoder
- Add missing function in function_selector_generic.c
2023-10-25 21:48:43 -07:00
Shashank Pathmudi
60b6534581 Fix for index-out-of-bounds in ixheaacd_smooth_m1m2
These changes handle the index-out-of-bounds runtime error reported
when the value of arbitrary downmix residual bands is greater than or equal
to the number of parameter bands.

Bug: ossFuzz:63564
Test: poc in bug
2023-10-26 10:17:24 +05:30
Shashank Pathmudi
947ad9f32b Fix for divide-by-zero in impd_parse_dwnmix_instructions
These changes handle the divide-by-zero runtime error reported
while calculating the downmix coefficients because
base channel count was coming zero.

Bug: ossFuzz:63420
Test: poc in bug
2023-10-26 10:17:24 +05:30
Shashank Pathmudi
b1a200212e Fix for divide-by-zero in ixheaacd_sbr_env_calc
These changes handle the divide-by-zero runtime error
reported while calculating energy tone.

Bug: ossFuzz:63248
Test: poc in bug
2023-10-20 11:21:05 +05:30
Shashank Pathmudi
2fb847d5e3 Fix for Nested bug in the same thread, aborting
These changes handle the nested bug in the same thread, aborting issue
reported by disabling some code checks which are related to EC.

Bug: ossFuzz:62003
Test: poc in bug
2023-10-20 11:21:05 +05:30
akshayragir833
fbe3ab5037
Android build file update (#62) 2023-10-18 13:29:06 +05:30
Akshay Ragir
f29c4480db Code refactoring and minor bug fixes 2023-10-12 19:24:54 +05:30
Akshay Ragir
fcf3e9af7d Fix for the Divide-by-zero in iaace_adapt_thr_to_pe
These changes handle the divide-by-zero runtime error
reported when the active lines become zero in
quantization. The issue is reported with AAC and the
same changes are extended to USAC.

Bug: ossFuzz: 62977
Test: poc in bug
2023-10-12 19:24:54 +05:30
Akshay Ragir
e8d026548e Fix for the Index-out-of-bounds in iusace_quantize_lines
These changes handle the index-out-of-bounds runtime error
reported when the bit consumption exceeds the bit reservoir
and global gain reaches the maximum value. The issue is
reported with USAC and the same changes are extended to AAC.

Bug: ossFuzz: 63019
Test: poc in bug
2023-10-12 19:24:54 +05:30
ShashankPathmudi
87abf1f1b0
Decoder bug fixes (#60)
* Fix for divide-by-zero in ixheaacd_sbr_env_calc

These changes handle the divide-by-zero runtime error reported
while calculating the energy because the consecutive frequency bands
were coming same.

Bug: ossFuzz:63038
Test: poc in bug

* Fix for divide-by-zero in ixheaacd_calc_stop_band

These changes handle the divide-by-zero runtime error reported
because sampling frequency comes out to be zero.

Bug: ossFuzz:63138
Test: poc in bug
2023-10-11 21:03:42 +05:30
Shashank Pathmudi
2d79f3ac59 Fix for divide-by-zero in ixheaacd_sbr_env_calc
These changes handle the divide-by-zero runtime error reported
while calculating energy gain.

Bug: ossFuzz:62903
Test: poc in bug
2023-10-05 16:01:11 +05:30
Shashank Pathmudi
0c86a5d8fa Fix for divide-by-zero in ixheaacd_lsf_weight_2st_flt
These changes handle the divide-by-zero runtime error reported
while calculating LSF weights.

Bug: ossFuzz:62778
Test: poc in bug
2023-10-05 16:01:11 +05:30
Akshay Ragir
aeaaaf4945 Minor bug fixes 2023-10-03 19:14:29 +05:30
Akshay Ragir
d8e8f980ae Fix for the Divide-by-zero in iaace_adjust_threshold
These changes handle the divide-by-zero runtime
error reported when the average bits become zero
in bit reservoir factor calculation.

Bug: ossFuzz: 62291
Test: poc in bug
2023-10-03 19:14:29 +05:30
Akshay Ragir
f247fa376e Fix for the Divide-by-zero in impd_drc_td_drc_gain_calc_init
These changes handle the divide-by-zero runtime error
reported when the successive drc gain coordinates
have same x coordinates.

Bug: ossFuzz:62237
Test: poc in bug
2023-10-03 19:14:29 +05:30
Akshay Ragir
56716426e2 Fix for the Global-buffer-overflow READ 4 in iusace_quantize_lines
These changes handle the global-buffer-overflow runtime error
reported when the tonal difference in the SBR module becomes
zero.

Bug: ossFuzz: 62261
Test: poc in bug
2023-10-03 19:14:29 +05:30
Shashank Pathmudi
f48c9bea64 Fix for divide-by-zero in ixheaacd_pre_processing
These changes handle the divide-by-zero runtime error reported
while calculating the energy because the start sample and end sample
were coming same.

Bug: ossFuzz:62766
Test: poc in bug
2023-09-29 18:08:43 +05:30
Shashank Pathmudi
3c8329953c Fix for index-out-of-bounds in ixheaacd_res_ctns_apply
These changes handle the index-out-of-bounds runtime error
reported when the value of residual sampling frequency index
is greater than max residual sampling frequency index.

Bug: ossFuzz:62707
Test: poc in bug
2023-09-29 18:08:43 +05:30
Shashank Pathmudi
11669841e3 Fix for divide-by-zero in ixheaacd_sbr_env_calc
These changes handle the divide-by-zero runtime error
reported while calculating the border vector value because
the value read from bitstream was coming greater the expected value.

Bug: ossFuzz:62633
Test: poc in bug
2023-09-29 18:08:43 +05:30
sandeshvenkatesh
0bb46ed5c9 Update ossfuzz.sh
Suppressing shift sanitizer in ossfuzz.h
2023-09-27 09:42:16 +05:30
Yash Patil
29692f1804 Fix for Divide-by-zero in ixheaacd_sbr_env_calc
These changes handle the Divide-by-zero runtime error reported
while calculating the energy estimation because the
consecutive border vectors were coming same.

Bug: ossFuzz:62282
Test: poc in bug
2023-09-22 19:04:19 +05:30
Yash Patil
f5edac2d5b Fix for Undefined-shift in ixheaacd_intensity_stereo_process
These changes handle the Undefined-shift runtime error reported
because the value of shift was coming greater than maximum expected value.

Bug: ossFuzz:62328
Test: poc in bug
2023-09-22 19:04:19 +05:30
Yash Patil
624669dfe1 Fix for Undefined-shift in ixheaacd_conv_ergtoamplitude_dec
These changes handle the Undefined-shift runtime error reported
because the value of shift was coming greater than maximum expected value.

Bug: ossFuzz:62339
Test: poc in bug
2023-09-22 19:04:19 +05:30
Yash Patil
5b0bee231b Fix for Use-of-uninitialized-value in impd_drc_set_preselection
These changes handles the runtime error reported when
one of the buffer was not initialized correctly.

Bug: ossFuzz:62388
Test: poc in bug
2023-09-22 19:04:19 +05:30
Yash Patil
d5356896ef Fix for Undefined-shift in ixheaacd_fd_frm_dec
These changes handle the Undefined-shift runtime error reported
when value of shift becomes negative.

Bug: ossFuzz:62332
Test: poc in bug
2023-09-22 19:04:19 +05:30
Yash Patil
b1d8b98c0b Fix for Timeout in xaac_dec_fuzzer
These changes handle the Timeout runtime-error reported when
number of bytes consumed are lower as compared to size of
input stream.

Bug: ossFuzz:62360
Test: poc in bug
2023-09-22 19:04:19 +05:30
Yash Patil
9ecc713da9 Fix for Undefined-shift in ixheaacd_hcr_decoder
These changes handle the Undefined shift runtime error reported
when bit position in huffman codeword reordering operation becomes
negative.

Bug: ossFuzz:62408
Test: poc in bug
2023-09-22 19:04:19 +05:30