Commit graph

439 commits

Author SHA1 Message Date
Dan Willemsen
e0b810f1ac Stop using __DATE__/__TIME__ on all builds
am: 4517537400

Change-Id: I18b87b747af44aea683d4a1b8528cb770fb358fd
2019-08-28 19:32:06 -07:00
Dan Willemsen
4517537400 Stop using __DATE__/__TIME__ on all builds
We're beginning to use remote caches with Android builds, so I'm turning
on -Werror=date-time so that host builds are also reproducible.

Test: treehugger
Test: mmma external/libhevc
Change-Id: I7fa1099d68cced587af46ad4d76cab5af4366e1e
2019-08-27 19:45:01 -07:00
Harish Mahendrakar
9fcd94f316 decoder: Fix valid SPS check in parsing SEI am: 61646846b3 am: 7f5da9039c am: e4237f852d
am: 824c19e4ca

Change-Id: I7b0970d485940b1c4c8eeea8f9cd316a84d1ac89
2019-06-20 21:20:00 -07:00
Saurabh Sood
f23d063692 Add push-pop for Neon D8-D15 registers
Bug: 68320413
Test: hevcdec with testbench updates to validate D8-D15

Change-Id: Ib62e68b69b016b1ded12cb00d1bb580de8a744c2
(cherry picked from commit 6acb36d25d)
2019-06-12 09:54:51 +00:00
Harish Mahendrakar
61646846b3 decoder: Fix valid SPS check in parsing SEI
When parsing SEI, ensure there is at least one valid SPS.

Test: poc in bug
Bug: 134420911

Change-Id: If3aa142b7fac324f8416e647572dfb002f56e06d
2019-06-07 16:23:17 -07:00
Saurabh Sood
907df0cf64 [automerger] Add push-pop for Neon D8-D15 registers am: 6acb36d25d am: 9acce62f78 am: 78acd1a8e7 am: 9313d3150d am: 61eb24a4f5 am: f82399d86a am: 091f45e3ad am: 0dce3a9137
am: 65974e7a26

Change-Id: I974dd9673b91ad80a72d27076fce4fe5697c7b8c
2019-05-31 14:51:24 -07:00
Android Build Merger (Role)
f82399d86a [automerger] Add push-pop for Neon D8-D15 registers am: 6acb36d25d am: 9acce62f78 am: 78acd1a8e7 am: 9313d3150d am: 61eb24a4f5
Change-Id: Ie4e0a965e53d25155ee7976e6588b4b797aa7ff0
2019-05-29 22:53:25 +00:00
Android Build Merger (Role)
9acce62f78 [automerger] Add push-pop for Neon D8-D15 registers am: 6acb36d25d
Change-Id: Ib972a88cef7e3ccb1388aede0d9e1919c218a66d
2019-05-29 22:53:14 +00:00
Saurabh Sood
6acb36d25d Add push-pop for Neon D8-D15 registers
Bug: 68320413
Test: hevcdec with testbench updates to validate D8-D15

Change-Id: Ib62e68b69b016b1ded12cb00d1bb580de8a744c2
2019-05-29 15:52:09 -07:00
Harish Mahendrakar
743001de6d Add few more checks for invalid parameters in sps
Following elements didn't have a bound check in SPS as spec doesn't list
the bounds on these explicitly.

log2_min_coding_block_size_minus3, log2_diff_max_min_coding_block_size,
log2_min_transform_block_size_minus2 and log2_diff_max_min_transform_block_size

Added appopriate error checks on these fields

Bug: 129366952
Bug: 130023983
Test: vendor
Merged-In: I59d95f43c2ef98300132d664095e88df8e87a164
Change-Id: I59d95f43c2ef98300132d664095e88df8e87a164
(cherry picked from commit 2f30da4ca2)
2019-05-15 05:32:20 +00:00
Harish Mahendrakar
34208286a1 Add bounds check for tile dimensions
Bug: 129976164
Bug: 130024844
Test: vendor/poc
Change-Id: I1e54babaec9c5ad199b60c7cfc1e24e36422f630
(cherry picked from commit 05f83e9458)
2019-05-15 05:32:16 +00:00
Harish Mahendrakar
76221fb693 Add missing return check for short_term_ref_pic_set()
Bug: 129401104
Bug: 130025324
Test: vendor
Change-Id: I685dd29ec13cca0ced5de8eb3aea1d0da5952a62
(cherry picked from commit 299cceb9e4)
2019-05-15 05:32:11 +00:00
Ray Essick
9e7930ac53 Merge "Add few more checks for invalid parameters in sps" into nyc-dev 2019-05-08 16:20:06 +00:00
Android Build Merger (Role)
8fb024bad3 [automerger] Add few more checks for invalid parameters in sps am: 2f30da4ca2 am: 59c1e4d23e am: 7dbf2eeb7f am: 4fd075fd4d am: e10f3d3c6d
Change-Id: I44b6ea6f4a0af681be55c893cb9241ef5e90ec4c
2019-05-07 20:47:48 +00:00
Android Build Merger (Role)
59c1e4d23e [automerger] Add few more checks for invalid parameters in sps am: 2f30da4ca2
Change-Id: I78d8b0b2a9e804f3af8fd090876fbd2750d1edf9
2019-05-07 20:47:43 +00:00
Harish Mahendrakar
2f30da4ca2 Add few more checks for invalid parameters in sps
Following elements didn't have a bound check in SPS as spec doesn't list
the bounds on these explicitly.

log2_min_coding_block_size_minus3, log2_diff_max_min_coding_block_size,
log2_min_transform_block_size_minus2 and log2_diff_max_min_transform_block_size

Added appopriate error checks on these fields

Bug: 129366952
Bug: 130023983
Test: vendor
Merged-In: I59d95f43c2ef98300132d664095e88df8e87a164
Change-Id: I59d95f43c2ef98300132d664095e88df8e87a164
2019-05-07 20:47:42 +00:00
Harish Mahendrakar
3d5a29afff Merge changes from topic "am-5b50c796-9c7d-4769-bc6c-f71bdac7c742" into oc-dev am: dce2f1a1a1 am: 7dd0807cdf am: cfebb9ec7d
am: 6b80fa9f71

Change-Id: I9a3853b7ca08ab2f10e2479721921dff59809449
2019-05-06 19:11:23 -07:00
Harish Mahendrakar
c34a29b7b5 [automerger] Add missing return check for short_term_ref_pic_set() am: 299cceb9e4 am: 2e8ae23656 am: 7ecb4083b9 am: 4fe71a567e am: 1561dc0fa9 am: 2b9fa38bb8 am: 6e96227190 am: cd5ac287ce
am: 0cdffda83f

Change-Id: I9086ab27ca823acc255239123cdeffe5671e3e18
2019-05-06 17:27:22 -07:00
TreeHugger Robot
d5130adfc5 Merge "Add bounds check for tile dimensions" into nyc-dev 2019-05-07 00:16:35 +00:00
TreeHugger Robot
dce2f1a1a1 Merge changes from topic "am-5b50c796-9c7d-4769-bc6c-f71bdac7c742" into oc-dev
* changes:
  [automerger] Add bounds check for tile dimensions am: 05f83e9458 am: 8ee7982e46 am: 7c6da2165b am: c11699b0f4 am: c0d441f4a7
  [automerger] Add bounds check for tile dimensions am: 05f83e9458 am: 8ee7982e46 am: 7c6da2165b am: c11699b0f4
  [automerger] Add bounds check for tile dimensions am: 05f83e9458 am: 8ee7982e46 am: 7c6da2165b
  [automerger] Add bounds check for tile dimensions am: 05f83e9458 am: 8ee7982e46
  [automerger] Add bounds check for tile dimensions am: 05f83e9458
  Add bounds check for tile dimensions
2019-05-07 00:16:35 +00:00
TreeHugger Robot
d683d78752 Merge changes from topic "am-5b50c796-9c7d-4769-bc6c-f71bdac7c742" into nyc-dr1-dev
* changes:
  [automerger] Add bounds check for tile dimensions am: 05f83e9458
  Add bounds check for tile dimensions
2019-05-07 00:16:35 +00:00
TreeHugger Robot
4f46e4b626 Merge "decoder: Report unsupported bitdepth and color format as fatal errors" into qt-dev 2019-05-01 22:15:00 +00:00
Harish Mahendrakar
7461e43ed8 decoder: Report unsupported bitdepth and color format as fatal errors
This will ensure clips with supported bitdepth or unsupport color
formats are not attempted to be decoded till end of the sequence.

Bug: 129796771
Bug: 130578045
Test: adb shell stagefright -s -S /sdcard/crowd422_hevc.mp4
Test: Ensure decoder doesn't attemp decoding all frames

Change-Id: I7c3cd58a0e231e7e64c278564d050086a079e12c
2019-04-30 15:50:13 -07:00
Harish Mahendrakar
8925a5b7fb Add few more checks for invalid parameters in sps
Following elements didn't have a bound check in SPS as spec doesn't list
the bounds on these explicitly.

log2_min_coding_block_size_minus3, log2_diff_max_min_coding_block_size,
log2_min_transform_block_size_minus2 and log2_diff_max_min_transform_block_size

Added appopriate error checks on these fields

Bug: 129366952
Bug: 130023983
Test: vendor
Change-Id: I59d95f43c2ef98300132d664095e88df8e87a164
2019-04-30 14:11:10 -07:00
Android Build Merger (Role)
2b9fa38bb8 [automerger] Add missing return check for short_term_ref_pic_set() am: 299cceb9e4 am: 2e8ae23656 am: 7ecb4083b9 am: 4fe71a567e am: 1561dc0fa9
Change-Id: I378a6e4f6f70931f36fd74acb02846096679e367
2019-04-23 22:29:03 +00:00
Android Build Merger (Role)
2e8ae23656 [automerger] Add missing return check for short_term_ref_pic_set() am: 299cceb9e4
Change-Id: I9c4d960ac4e58f57b637908524918558ae539ca4
2019-04-23 22:28:54 +00:00
Harish Mahendrakar
299cceb9e4 Add missing return check for short_term_ref_pic_set()
Bug: 129401104
Bug: 130025324
Test: vendor
Change-Id: I685dd29ec13cca0ced5de8eb3aea1d0da5952a62
2019-04-23 15:28:03 -07:00
Android Build Merger (Role)
adb9a9521f [automerger] Add bounds check for tile dimensions am: 05f83e9458 am: 8ee7982e46 am: 7c6da2165b am: c11699b0f4 am: c0d441f4a7
Change-Id: Id59eb1cae3db497e3b7d04abd207ff69819a2331
2019-04-23 22:07:43 +00:00
Android Build Merger (Role)
8ee7982e46 [automerger] Add bounds check for tile dimensions am: 05f83e9458
Change-Id: Ic7ecd009be03d4a991ffde51ba0081b4fc6998a6
2019-04-23 22:07:31 +00:00
Harish Mahendrakar
05f83e9458 Add bounds check for tile dimensions
Bug: 129976164
Bug: 130024844
Test: vendor/poc
Change-Id: I1e54babaec9c5ad199b60c7cfc1e24e36422f630
2019-04-23 15:06:48 -07:00
Snehal Bhamare
1b4ab78b5d Decoder: Fixing integer-overflow sanitizer issues
Bug: 111272481
Test: vendor
Change-Id: Idd5db33617ae55f70a1be67e0374adceafc174d3
2019-02-05 14:25:24 -08:00
S Hamsalekha
8669e83d71 Decoder: Fixing some more integer-overflow sanitizer issues
Bug: 111272481
Test: vendor
Change-Id: I8603d82a52def851a9af67da6fcb967963c44c69
2019-01-09 13:16:44 -08:00
Rakesh Kumar
06e94e9ceb Decoder: Fix integer-overflow sanitizer issues
Bug: 111272481
Test: vendor
Change-Id: If4266a33677d98f567884ebbc7908289e42fb94f
2019-01-09 13:16:37 -08:00
Rakesh Kumar
0896f571c1 [automerger] Decoder: Signal IVD_RES_CHANGED error for change in crop params am: fdbbd60bfe am: 2c56677a61 am: 5f668de48b am: 80f7bce01d am: 4ec0aaf69b am: fea57ee069 am: a28e5a297c am: 0cbc12f971 am: ca0f470122
am: 9a6283799f

Change-Id: I6496e47f1ef385ca92eb8b17d5831dcb6138a887
2018-11-19 17:44:24 -08:00
TreeHugger Robot
89937f03cd Merge "Decoder: Signal IVD_RES_CHANGED error for change in crop params" into nyc-dev 2018-11-20 01:13:59 +00:00
Android Build Merger (Role)
fea57ee069 [automerger] Decoder: Signal IVD_RES_CHANGED error for change in crop params am: fdbbd60bfe am: 2c56677a61 am: 5f668de48b am: 80f7bce01d am: 4ec0aaf69b
Change-Id: I26134694e5a2b87ff929a5076b15cdbe154b1b07
2018-11-14 21:53:30 +00:00
Android Build Merger (Role)
2c56677a61 [automerger] Decoder: Signal IVD_RES_CHANGED error for change in crop params am: fdbbd60bfe
Change-Id: I2058a5d409bbc7076c8a45a84521f37681ee38f2
2018-11-14 21:53:25 +00:00
Rakesh Kumar
fdbbd60bfe Decoder: Signal IVD_RES_CHANGED error for change in crop params
IVD_RES_CHANGED was not signaled when crop parameters changed, i.e.
display dimensions changed without change in decode dimensions.

In such cases, if output buffer was allocated as per the current
dimension being decoded, without IVD_RES_CHANGED signalled, there can be
an OOB write if the new buffer is smaller than the frame being returned
as output

Bug: 118453553
Test: vendor
Change-Id: Ic74c6fb9612403f75a8f9ddb3a93861bca82cf16
2018-11-14 13:42:41 -08:00
Shubham Tandle
9be2b750a0 [automerger] Add limits check for the CTB position in a frame am: 5a3dafc324 am: 1b95d7fa97 am: 0a5e519fc7 am: 10a9188110 am: 9d02c4ce08 am: 7a67bf3a4b am: 0f839f5785 am: b02053d366 am: b37c780786
am: 6423e5127b

Change-Id: I69ccf360a96e35a054aaf76424b307ba8da58151
2018-10-11 17:33:40 -07:00
Android Build Merger (Role)
7a67bf3a4b [automerger] Add limits check for the CTB position in a frame am: 5a3dafc324 am: 1b95d7fa97 am: 0a5e519fc7 am: 10a9188110 am: 9d02c4ce08
Change-Id: I3cd06c961d8df7555aa1fb87c34c9a9383a58cc1
2018-10-05 21:54:10 +00:00
Android Build Merger (Role)
1b95d7fa97 [automerger] Add limits check for the CTB position in a frame am: 5a3dafc324
Change-Id: I68b3694c6b6c8f1aa0df204b31f0ede6327ae9fb
2018-10-05 21:54:01 +00:00
Shubham Tandle
5a3dafc324 Add limits check for the CTB position in a frame
Bug: 113260892
Bug: 113261108
Bug: 113261310

The decoder does not support tile position > 255.
Added error checks to ensure the same.

Test: re-run POC
Change-Id: Id359c172c8630ded2fb3f47c447f373cd2d1bc34
2018-10-05 14:53:12 -07:00
Rakesh Kumar
303b662e0d Decoder: Memset allocated dynamic and static buffer to zero
Bug: 111764725
Bug: 112327675
Bug: 112326216
Test: manual
Change-Id: Ia775c77cb62fae89ac410805c9fca55522a2e555
2018-08-24 11:22:23 -07:00
Android Build Merger (Role)
a9a51a4940 [automerger] Return error for invalid st/lt sps parameters am: b93923e288 am: 797c104f3b am: 092cd28d04 am: 0e0458c8da am: 400d114e64 am: fa6d5fe71f am: 03831de632 am: 1a661cfc0e am: 8151a909f7
Change-Id: If66401894ec3e28da20fd560582fd97c78d4ec22
2018-04-20 21:13:43 +00:00
Android Build Merger (Role)
fa6d5fe71f [automerger] Return error for invalid st/lt sps parameters am: b93923e288 am: 797c104f3b am: 092cd28d04 am: 0e0458c8da am: 400d114e64
Change-Id: I492074238997f2ce090e3f579282578f6795779c
2018-04-20 21:13:39 +00:00
Android Build Merger (Role)
400d114e64 [automerger] Return error for invalid st/lt sps parameters am: b93923e288 am: 797c104f3b am: 092cd28d04 am: 0e0458c8da
Change-Id: I6b3d4070c6ec92d545664ae6cae43f0a2e1733e3
2018-04-20 21:13:37 +00:00
Android Build Merger (Role)
797c104f3b [automerger] Return error for invalid st/lt sps parameters am: b93923e288
Change-Id: I6b15a4359ef9228c6f707f4e104c587d189c6bfc
2018-04-20 21:13:32 +00:00
Naveen Kumar P
b93923e288 Return error for invalid st/lt sps parameters
When num_short_term_ref_pic_sets or num_long_term_ref_pics_sps in
sps is out of range, error is returned.

Bug: 77599438
Test: poc before/after
Change-Id: I652d27849438c3ea2d42fc6e9abb8aeb25ebdc22
2018-04-20 14:12:21 -07:00
TreeHugger Robot
dd9737ba12 Merge changes from topic "am-710d603e-2dfd-4779-8a9e-e8fd1e2198ef" into oc-dev
* changes:
  [automerger] Return error for invalid sps sub layers parameters am: f4486cdb2f am: 37579e833a am: 38e104d65a am: 247c93b227 am: 3e163fda73 am: d2eb213a27 am: 33805721b3 am: c9c55cb311 am: 7f03778448
  [automerger] Return error for invalid sps sub layers parameters am: f4486cdb2f am: 37579e833a am: 38e104d65a am: 247c93b227 am: 3e163fda73 am: d2eb213a27 am: 33805721b3 am: c9c55cb311
  [automerger] Return error for invalid sps sub layers parameters am: f4486cdb2f am: 37579e833a am: 38e104d65a am: 247c93b227 am: 3e163fda73 am: d2eb213a27 am: 33805721b3
  [automerger] Return error for invalid sps sub layers parameters am: f4486cdb2f am: 37579e833a am: 38e104d65a am: 247c93b227 am: 3e163fda73 am: d2eb213a27
  [automerger] Return error for invalid sps sub layers parameters am: f4486cdb2f am: 37579e833a am: 38e104d65a am: 247c93b227 am: 3e163fda73
  [automerger] Return error for invalid sps sub layers parameters am: f4486cdb2f am: 37579e833a am: 38e104d65a am: 247c93b227
  [automerger] Return error for invalid sps sub layers parameters am: f4486cdb2f am: 37579e833a am: 38e104d65a
  [automerger] Return error for invalid sps sub layers parameters am: f4486cdb2f am: 37579e833a
  [automerger] Return error for invalid sps sub layers parameters am: f4486cdb2f
  Return error for invalid sps sub layers parameters
2018-04-06 19:17:27 +00:00
TreeHugger Robot
08e9bcd2e8 Merge changes from topic "am-710d603e-2dfd-4779-8a9e-e8fd1e2198ef" into nyc-dr1-dev
* changes:
  [automerger] Return error for invalid sps sub layers parameters am: f4486cdb2f am: 37579e833a am: 38e104d65a am: 247c93b227 am: 3e163fda73
  [automerger] Return error for invalid sps sub layers parameters am: f4486cdb2f am: 37579e833a am: 38e104d65a am: 247c93b227
  [automerger] Return error for invalid sps sub layers parameters am: f4486cdb2f am: 37579e833a am: 38e104d65a
  [automerger] Return error for invalid sps sub layers parameters am: f4486cdb2f am: 37579e833a
  [automerger] Return error for invalid sps sub layers parameters am: f4486cdb2f
  Return error for invalid sps sub layers parameters
2018-04-06 19:17:27 +00:00