wrapper/libhevc-mirror
1
0
Fork 0
mirror of https://github.com/ittiam-systems/libhevc.git synced 2026-08-15 23:32:35 +07:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

Decoder: Signal IVD_RES_CHANGED error for change in crop params

Browse source 
IVD_RES_CHANGED was not signaled when crop parameters changed, i.e.
display dimensions changed without change in decode dimensions.

In such cases, if output buffer was allocated as per the current
dimension being decoded, without IVD_RES_CHANGED signalled, there can be
an OOB write if the new buffer is smaller than the frame being returned
as output

Bug: 118453553
Test: vendor
Change-Id: Ic74c6fb9612403f75a8f9ddb3a93861bca82cf16
This commit is contained in:
Rakesh Kumar 2018-11-12 18:00:27 +05:30 • committed by Ray Essick
parent 400d114e64
commit fdbbd60bfe
1 changed files with 12 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

12
decoder/ihevcd_parse_headers.c
View file

@ -1599,6 +1599,18 @@ IHEVCD_ERROR_T ihevcd_parse_sps(codec_t *ps_codec)
if((0 >= disp_wd) || (0 >= disp_ht))
return IHEVCD_INVALID_PARAMETER;
if((0 != ps_codec->u4_allocate_dynamic_done) &&
((ps_codec->i4_disp_wd != disp_wd) ||
(ps_codec->i4_disp_ht != disp_ht)))
{
if(0 == ps_codec->i4_first_pic_done)
{
return IHEVCD_INVALID_PARAMETER;
}
ps_codec->i4_reset_flag = 1;
return (IHEVCD_ERROR_T)IVD_RES_CHANGED;
}
ps_codec->i4_disp_wd = disp_wd;
ps_codec->i4_disp_ht = disp_ht;