Commit graph

335 commits

Author SHA1 Message Date
Android Build Merger (Role)
2e8ae23656 [automerger] Add missing return check for short_term_ref_pic_set() am: 299cceb9e4
Change-Id: I9c4d960ac4e58f57b637908524918558ae539ca4
2019-04-23 22:28:54 +00:00
Harish Mahendrakar
299cceb9e4 Add missing return check for short_term_ref_pic_set()
Bug: 129401104
Bug: 130025324
Test: vendor
Change-Id: I685dd29ec13cca0ced5de8eb3aea1d0da5952a62
2019-04-23 15:28:03 -07:00
TreeHugger Robot
89937f03cd Merge "Decoder: Signal IVD_RES_CHANGED error for change in crop params" into nyc-dev 2018-11-20 01:13:59 +00:00
Android Build Merger (Role)
2c56677a61 [automerger] Decoder: Signal IVD_RES_CHANGED error for change in crop params am: fdbbd60bfe
Change-Id: I2058a5d409bbc7076c8a45a84521f37681ee38f2
2018-11-14 21:53:25 +00:00
Rakesh Kumar
fdbbd60bfe Decoder: Signal IVD_RES_CHANGED error for change in crop params
IVD_RES_CHANGED was not signaled when crop parameters changed, i.e.
display dimensions changed without change in decode dimensions.

In such cases, if output buffer was allocated as per the current
dimension being decoded, without IVD_RES_CHANGED signalled, there can be
an OOB write if the new buffer is smaller than the frame being returned
as output

Bug: 118453553
Test: vendor
Change-Id: Ic74c6fb9612403f75a8f9ddb3a93861bca82cf16
2018-11-14 13:42:41 -08:00
Android Build Merger (Role)
1b95d7fa97 [automerger] Add limits check for the CTB position in a frame am: 5a3dafc324
Change-Id: I68b3694c6b6c8f1aa0df204b31f0ede6327ae9fb
2018-10-05 21:54:01 +00:00
Shubham Tandle
5a3dafc324 Add limits check for the CTB position in a frame
Bug: 113260892
Bug: 113261108
Bug: 113261310

The decoder does not support tile position > 255.
Added error checks to ensure the same.

Test: re-run POC
Change-Id: Id359c172c8630ded2fb3f47c447f373cd2d1bc34
2018-10-05 14:53:12 -07:00
Android Build Merger (Role)
fa6d5fe71f [automerger] Return error for invalid st/lt sps parameters am: b93923e288 am: 797c104f3b am: 092cd28d04 am: 0e0458c8da am: 400d114e64
Change-Id: I492074238997f2ce090e3f579282578f6795779c
2018-04-20 21:13:39 +00:00
Android Build Merger (Role)
400d114e64 [automerger] Return error for invalid st/lt sps parameters am: b93923e288 am: 797c104f3b am: 092cd28d04 am: 0e0458c8da
Change-Id: I6b3d4070c6ec92d545664ae6cae43f0a2e1733e3
2018-04-20 21:13:37 +00:00
Android Build Merger (Role)
797c104f3b [automerger] Return error for invalid st/lt sps parameters am: b93923e288
Change-Id: I6b15a4359ef9228c6f707f4e104c587d189c6bfc
2018-04-20 21:13:32 +00:00
Naveen Kumar P
b93923e288 Return error for invalid st/lt sps parameters
When num_short_term_ref_pic_sets or num_long_term_ref_pics_sps in
sps is out of range, error is returned.

Bug: 77599438
Test: poc before/after
Change-Id: I652d27849438c3ea2d42fc6e9abb8aeb25ebdc22
2018-04-20 14:12:21 -07:00
TreeHugger Robot
08e9bcd2e8 Merge changes from topic "am-710d603e-2dfd-4779-8a9e-e8fd1e2198ef" into nyc-dr1-dev
* changes:
  [automerger] Return error for invalid sps sub layers parameters am: f4486cdb2f am: 37579e833a am: 38e104d65a am: 247c93b227 am: 3e163fda73
  [automerger] Return error for invalid sps sub layers parameters am: f4486cdb2f am: 37579e833a am: 38e104d65a am: 247c93b227
  [automerger] Return error for invalid sps sub layers parameters am: f4486cdb2f am: 37579e833a am: 38e104d65a
  [automerger] Return error for invalid sps sub layers parameters am: f4486cdb2f am: 37579e833a
  [automerger] Return error for invalid sps sub layers parameters am: f4486cdb2f
  Return error for invalid sps sub layers parameters
2018-04-06 19:17:27 +00:00
TreeHugger Robot
91adc13b0e Merge changes from topic "am-710d603e-2dfd-4779-8a9e-e8fd1e2198ef" into nyc-dev
* changes:
  [automerger] Return error for invalid sps sub layers parameters am: f4486cdb2f am: 37579e833a am: 38e104d65a am: 247c93b227
  [automerger] Return error for invalid sps sub layers parameters am: f4486cdb2f am: 37579e833a am: 38e104d65a
  [automerger] Return error for invalid sps sub layers parameters am: f4486cdb2f am: 37579e833a
  [automerger] Return error for invalid sps sub layers parameters am: f4486cdb2f
  Return error for invalid sps sub layers parameters
2018-04-06 19:17:27 +00:00
TreeHugger Robot
3bc5ebb996 Merge changes from topic "am-710d603e-2dfd-4779-8a9e-e8fd1e2198ef" into mnc-dr-dev
* changes:
  [automerger] Return error for invalid sps sub layers parameters am: f4486cdb2f
  Return error for invalid sps sub layers parameters
2018-04-06 19:17:27 +00:00
TreeHugger Robot
de502938ff Merge changes from topic "am-492ad0fb-402d-4977-be93-b82e053bee6f" into nyc-dr1-dev
* changes:
  [automerger] Add limits check for depth hierarchy sps parameters am: f7287c7993 am: 46dc210bfd am: cd00b5307b am: 96f3a8ba91 am: 9b88c05de9
  [automerger] Add limits check for depth hierarchy sps parameters am: f7287c7993 am: 46dc210bfd am: cd00b5307b am: 96f3a8ba91
  [automerger] Add limits check for depth hierarchy sps parameters am: f7287c7993 am: 46dc210bfd am: cd00b5307b
  [automerger] Add limits check for depth hierarchy sps parameters am: f7287c7993 am: 46dc210bfd
  [automerger] Add limits check for depth hierarchy sps parameters am: f7287c7993
  Add limits check for depth hierarchy sps parameters
2018-04-06 19:08:18 +00:00
TreeHugger Robot
b6584f925d Merge changes from topic "am-492ad0fb-402d-4977-be93-b82e053bee6f" into nyc-dev
* changes:
  [automerger] Add limits check for depth hierarchy sps parameters am: f7287c7993 am: 46dc210bfd am: cd00b5307b am: 96f3a8ba91
  [automerger] Add limits check for depth hierarchy sps parameters am: f7287c7993 am: 46dc210bfd am: cd00b5307b
  [automerger] Add limits check for depth hierarchy sps parameters am: f7287c7993 am: 46dc210bfd
  [automerger] Add limits check for depth hierarchy sps parameters am: f7287c7993
  Add limits check for depth hierarchy sps parameters
2018-04-06 19:08:18 +00:00
TreeHugger Robot
f769fc96fe Merge changes from topic "am-492ad0fb-402d-4977-be93-b82e053bee6f" into mnc-dr-dev
* changes:
  [automerger] Add limits check for depth hierarchy sps parameters am: f7287c7993
  Add limits check for depth hierarchy sps parameters
2018-04-06 19:08:18 +00:00
Android Build Merger (Role)
914006b851 [automerger] Add limits check for depth hierarchy sps parameters am: f7287c7993 am: 46dc210bfd am: cd00b5307b am: 96f3a8ba91 am: 9b88c05de9
Change-Id: I2884bb46efb8272fc030b597e641e2b1cf3e9d30
2018-03-27 19:53:54 +00:00
Android Build Merger (Role)
9b88c05de9 [automerger] Add limits check for depth hierarchy sps parameters am: f7287c7993 am: 46dc210bfd am: cd00b5307b am: 96f3a8ba91
Change-Id: Ica2ca13d2d169fdc57fde89f503a005b506a2e6d
2018-03-27 19:53:53 +00:00
Android Build Merger (Role)
46dc210bfd [automerger] Add limits check for depth hierarchy sps parameters am: f7287c7993
Change-Id: I4b03b97ead99b399a9cdfcb4be05d422afc5ddf9
2018-03-27 19:53:49 +00:00
Naveen Kumar P
f7287c7993 Add limits check for depth hierarchy sps parameters
Bug: 73965890
Test: run poc before/after

According to the hevc specification, max_transform_hierarchy_depth_inter
and max_transform_hierarchy_depth_intra cannot be greater than
difference between log2_ctb_size and log2_min_transform_block_size.

Change-Id: I9a6f56b029957cead3e81bd07d7fb8392a1a98a2
2018-03-27 12:53:00 -07:00
Android Build Merger (Role)
d2eb213a27 [automerger] Return error for invalid sps sub layers parameters am: f4486cdb2f am: 37579e833a am: 38e104d65a am: 247c93b227 am: 3e163fda73
Change-Id: I0615554e3bcc95ed09c984f5cdbdabde278d53ff
2018-03-14 21:13:55 +00:00
Android Build Merger (Role)
3e163fda73 [automerger] Return error for invalid sps sub layers parameters am: f4486cdb2f am: 37579e833a am: 38e104d65a am: 247c93b227
Change-Id: I8e751caa7e9e0ffb3cb59923b466707d831b0ff7
2018-03-14 21:13:53 +00:00
Android Build Merger (Role)
37579e833a [automerger] Return error for invalid sps sub layers parameters am: f4486cdb2f
Change-Id: Ibf6aa79e101a3cf38914e54598d9b53d68c11a05
2018-03-14 21:13:49 +00:00
Android Build Merger (Role)
a5af46e7c4 [automerger] Return error for invalid reorder parameter am: 4286d31e9e am: df2bef9a86 am: e7950035a8 am: b596887685 am: 3d1c41dfb1
Change-Id: I49bcf6cf3713131d06edd5b29e02f60e1d757a0e
2018-03-14 21:12:59 +00:00
Android Build Merger (Role)
3d1c41dfb1 [automerger] Return error for invalid reorder parameter am: 4286d31e9e am: df2bef9a86 am: e7950035a8 am: b596887685
Change-Id: Ic1e961cc498ee24683f81ca13bd5d51c905d105e
2018-03-14 21:12:58 +00:00
Android Build Merger (Role)
df2bef9a86 [automerger] Return error for invalid reorder parameter am: 4286d31e9e
Change-Id: Idf58826d100160a8b79cd13d496c7bdcc5735350
2018-03-14 21:12:53 +00:00
Naveen Kumar P
f4486cdb2f Return error for invalid sps sub layers parameters
Return error for negative values of max_dec_pic_buffering and
num_reorder_pics sps parameters.

Bug: 73965867
Test: Ittiam
Change-Id: I6035b3b2fcbd29c6bbb1223f4714ba04b4bca6b3
2018-03-14 14:05:04 -07:00
Naveen Kumar P
4286d31e9e Return error for invalid reorder parameter
Bug: 62689208
Test: before/after process PoC on ASAN builds.
Change-Id: Ib1404bdf512fba28c2641f3f2022811a2a2d7751
2018-03-14 14:03:44 -07:00
TreeHugger Robot
6146ad7b56 Merge changes from topic "am-d9f32dd9-3390-41f5-bb22-01a4025e5105" into mnc-dev
* changes:
  [automerger] Update sps id after decoding the sps am: df865d1a3d am: f6dd7e59fc
  [automerger] Update sps id after decoding the sps am: df865d1a3d
  Update sps id after decoding the sps
2018-02-07 22:38:27 +00:00
TreeHugger Robot
988ded8972 Merge changes from topic "am-d9f32dd9-3390-41f5-bb22-01a4025e5105" into mnc-dr-dev
* changes:
  [automerger] Update sps id after decoding the sps am: df865d1a3d am: f6dd7e59fc am: fef5c42d9e
  [automerger] Update sps id after decoding the sps am: df865d1a3d am: f6dd7e59fc
  [automerger] Update sps id after decoding the sps am: df865d1a3d
  Update sps id after decoding the sps
2018-02-07 22:38:27 +00:00
TreeHugger Robot
b97daaf1c8 Merge changes from topic "am-d9f32dd9-3390-41f5-bb22-01a4025e5105" into nyc-dr1-dev
* changes:
  [automerger] Update sps id after decoding the sps am: df865d1a3d am: f6dd7e59fc am: fef5c42d9e am: e2882ef69c am: 43add9adfd am: 16c260efdb am: 18dd00f64d
  [automerger] Update sps id after decoding the sps am: df865d1a3d am: f6dd7e59fc am: fef5c42d9e am: e2882ef69c am: 43add9adfd am: 16c260efdb
  [automerger] Update sps id after decoding the sps am: df865d1a3d am: f6dd7e59fc am: fef5c42d9e am: e2882ef69c am: 43add9adfd
  [automerger] Update sps id after decoding the sps am: df865d1a3d am: f6dd7e59fc am: fef5c42d9e am: e2882ef69c
  [automerger] Update sps id after decoding the sps am: df865d1a3d am: f6dd7e59fc am: fef5c42d9e
  [automerger] Update sps id after decoding the sps am: df865d1a3d am: f6dd7e59fc
  [automerger] Update sps id after decoding the sps am: df865d1a3d
  Update sps id after decoding the sps
2018-02-07 22:38:27 +00:00
TreeHugger Robot
2333a1dcc0 Merge changes from topic "am-d9f32dd9-3390-41f5-bb22-01a4025e5105" into nyc-dev
* changes:
  [automerger] Update sps id after decoding the sps am: df865d1a3d am: f6dd7e59fc am: fef5c42d9e am: e2882ef69c am: 43add9adfd am: 16c260efdb
  [automerger] Update sps id after decoding the sps am: df865d1a3d am: f6dd7e59fc am: fef5c42d9e am: e2882ef69c am: 43add9adfd
  [automerger] Update sps id after decoding the sps am: df865d1a3d am: f6dd7e59fc am: fef5c42d9e am: e2882ef69c
  [automerger] Update sps id after decoding the sps am: df865d1a3d am: f6dd7e59fc am: fef5c42d9e
  [automerger] Update sps id after decoding the sps am: df865d1a3d am: f6dd7e59fc
  [automerger] Update sps id after decoding the sps am: df865d1a3d
  Update sps id after decoding the sps
2018-02-07 22:38:27 +00:00
TreeHugger Robot
8449611ab3 Merge changes from topic "am-bb3693f0-1b1d-44f9-bddc-f066f81f61d7" into mnc-dev
* changes:
  [automerger] Check limits for log2_max_pic_order_cnt_lsb_minus4 in sps am: 4d32ff55cf am: 1011e9b3e7
  [automerger] Check limits for log2_max_pic_order_cnt_lsb_minus4 in sps am: 4d32ff55cf
  Check limits for log2_max_pic_order_cnt_lsb_minus4 in sps
2018-01-31 22:25:38 +00:00
TreeHugger Robot
5e1f5045a6 Merge changes from topic "am-bb3693f0-1b1d-44f9-bddc-f066f81f61d7" into mnc-dr-dev
* changes:
  [automerger] Check limits for log2_max_pic_order_cnt_lsb_minus4 in sps am: 4d32ff55cf am: 1011e9b3e7 am: 840115bf1a
  [automerger] Check limits for log2_max_pic_order_cnt_lsb_minus4 in sps am: 4d32ff55cf am: 1011e9b3e7
  [automerger] Check limits for log2_max_pic_order_cnt_lsb_minus4 in sps am: 4d32ff55cf
  Check limits for log2_max_pic_order_cnt_lsb_minus4 in sps
2018-01-31 22:25:38 +00:00
TreeHugger Robot
2d20d394ca Merge changes from topic "am-bb3693f0-1b1d-44f9-bddc-f066f81f61d7" into nyc-dr1-dev
* changes:
  [automerger] Check limits for log2_max_pic_order_cnt_lsb_minus4 in sps am: 4d32ff55cf am: 1011e9b3e7 am: 840115bf1a am: 8a4369a73f am: 5dd91cba1c am: db58269ba7 am: a7c7893ba1
  [automerger] Check limits for log2_max_pic_order_cnt_lsb_minus4 in sps am: 4d32ff55cf am: 1011e9b3e7 am: 840115bf1a am: 8a4369a73f am: 5dd91cba1c am: db58269ba7
  [automerger] Check limits for log2_max_pic_order_cnt_lsb_minus4 in sps am: 4d32ff55cf am: 1011e9b3e7 am: 840115bf1a am: 8a4369a73f am: 5dd91cba1c
  [automerger] Check limits for log2_max_pic_order_cnt_lsb_minus4 in sps am: 4d32ff55cf am: 1011e9b3e7 am: 840115bf1a am: 8a4369a73f
  [automerger] Check limits for log2_max_pic_order_cnt_lsb_minus4 in sps am: 4d32ff55cf am: 1011e9b3e7 am: 840115bf1a
  [automerger] Check limits for log2_max_pic_order_cnt_lsb_minus4 in sps am: 4d32ff55cf am: 1011e9b3e7
  [automerger] Check limits for log2_max_pic_order_cnt_lsb_minus4 in sps am: 4d32ff55cf
  Check limits for log2_max_pic_order_cnt_lsb_minus4 in sps
2018-01-31 22:25:38 +00:00
TreeHugger Robot
3959371b90 Merge changes from topic "am-bb3693f0-1b1d-44f9-bddc-f066f81f61d7" into nyc-dev
* changes:
  [automerger] Check limits for log2_max_pic_order_cnt_lsb_minus4 in sps am: 4d32ff55cf am: 1011e9b3e7 am: 840115bf1a am: 8a4369a73f am: 5dd91cba1c am: db58269ba7
  [automerger] Check limits for log2_max_pic_order_cnt_lsb_minus4 in sps am: 4d32ff55cf am: 1011e9b3e7 am: 840115bf1a am: 8a4369a73f am: 5dd91cba1c
  [automerger] Check limits for log2_max_pic_order_cnt_lsb_minus4 in sps am: 4d32ff55cf am: 1011e9b3e7 am: 840115bf1a am: 8a4369a73f
  [automerger] Check limits for log2_max_pic_order_cnt_lsb_minus4 in sps am: 4d32ff55cf am: 1011e9b3e7 am: 840115bf1a
  [automerger] Check limits for log2_max_pic_order_cnt_lsb_minus4 in sps am: 4d32ff55cf am: 1011e9b3e7
  [automerger] Check limits for log2_max_pic_order_cnt_lsb_minus4 in sps am: 4d32ff55cf
  Check limits for log2_max_pic_order_cnt_lsb_minus4 in sps
2018-01-31 22:25:38 +00:00
Android Build Merger (Role)
484190d3e0 [automerger] Update sps id after decoding the sps am: df865d1a3d am: f6dd7e59fc am: fef5c42d9e am: e2882ef69c am: 43add9adfd am: 16c260efdb am: 18dd00f64d
Change-Id: Ifc362654e5d7a885fdde878cae6de93444701049
2018-01-31 18:44:52 +00:00
Android Build Merger (Role)
18dd00f64d [automerger] Update sps id after decoding the sps am: df865d1a3d am: f6dd7e59fc am: fef5c42d9e am: e2882ef69c am: 43add9adfd am: 16c260efdb
Change-Id: I01e19596b2c40d305f2e127456235d1d353fc1cd
2018-01-31 18:44:51 +00:00
Android Build Merger (Role)
e2882ef69c [automerger] Update sps id after decoding the sps am: df865d1a3d am: f6dd7e59fc am: fef5c42d9e
Change-Id: Iec62ef3e02e3f7b5c4dd97ff7150f782f9c22d44
2018-01-31 18:44:47 +00:00
Android Build Merger (Role)
fef5c42d9e [automerger] Update sps id after decoding the sps am: df865d1a3d am: f6dd7e59fc
Change-Id: Id0dbe58e46afab4c1a565d7c85737b1c493fad3d
2018-01-31 18:44:46 +00:00
Android Build Merger (Role)
f6dd7e59fc [automerger] Update sps id after decoding the sps am: df865d1a3d
Change-Id: I5f0a24ce894a00ed35ad65312897905bb38a0266
2018-01-31 18:44:44 +00:00
Naveen Kumar P
df865d1a3d Update sps id after decoding the sps
The update of sps_id in ps_codec is moved to the end of the sps
parsing function to ensure the sps is completely parsed without
any error

Bug: 71567394
Test: poc before/after
Change-Id: I072b7e0486170ffc46b5c6807aca492013b1b06e
2018-01-31 10:44:08 -08:00
Android Build Merger (Role)
7bcc6d9e73 [automerger] Check limits for log2_max_pic_order_cnt_lsb_minus4 in sps am: 4d32ff55cf am: 1011e9b3e7 am: 840115bf1a am: 8a4369a73f am: 5dd91cba1c am: db58269ba7 am: a7c7893ba1
Change-Id: I0df8b93e52295851c7e18fdc0758351ebc35dc3b
2018-01-26 20:53:37 +00:00
Android Build Merger (Role)
a7c7893ba1 [automerger] Check limits for log2_max_pic_order_cnt_lsb_minus4 in sps am: 4d32ff55cf am: 1011e9b3e7 am: 840115bf1a am: 8a4369a73f am: 5dd91cba1c am: db58269ba7
Change-Id: If3ab6137a30512fd6ad2f135fd4494e719c01a5b
2018-01-26 20:53:36 +00:00
Android Build Merger (Role)
8a4369a73f [automerger] Check limits for log2_max_pic_order_cnt_lsb_minus4 in sps am: 4d32ff55cf am: 1011e9b3e7 am: 840115bf1a
Change-Id: Ib6de9f35196c1accbfc3351d826b1079ce4b32b4
2018-01-26 20:53:33 +00:00
Android Build Merger (Role)
840115bf1a [automerger] Check limits for log2_max_pic_order_cnt_lsb_minus4 in sps am: 4d32ff55cf am: 1011e9b3e7
Change-Id: I5b0373be695152b8bacacdbf45b666404853a785
2018-01-26 20:53:32 +00:00
Android Build Merger (Role)
1011e9b3e7 [automerger] Check limits for log2_max_pic_order_cnt_lsb_minus4 in sps am: 4d32ff55cf
Change-Id: Ifccdd6f76e543106fb097e15d2782386ebe8bfaf
2018-01-26 20:53:31 +00:00
Naveen Kumar P
4d32ff55cf Check limits for log2_max_pic_order_cnt_lsb_minus4 in sps
Bug: 71766721

According to the spec, the value of log2_max_pic_order_cnt_lsb_minus4
shall be in the range of 0 to 12, inclusive.

Change-Id: Ibd199b6dea246c2fac6214c21e49f27d95c07659
2018-01-26 12:43:44 -08:00
Android Build Merger (Role)
dc6a93286c [automerger] Fix output buffer size check am: ce8a8db32e am: 38414e7695 am: 2ab44f7b06 am: 067b752888 am: 3ed61deace am: 324d31ea53 am: 11b4c7987a
Change-Id: I74315ca218b910693b11a706dc1616f5418b60f6
2018-01-26 19:19:35 +00:00