Harish Mahendrakar
3d5a29afff
Merge changes from topic "am-5b50c796-9c7d-4769-bc6c-f71bdac7c742" into oc-dev am: dce2f1a1a1 am: 7dd0807cdf am: cfebb9ec7d
...
am: 6b80fa9f71
2019-05-06 19:11:23 -07:00
Harish Mahendrakar
c34a29b7b5
[automerger] Add missing return check for short_term_ref_pic_set() am: 299cceb9e4 am: 2e8ae23656 am: 7ecb4083b9 am: 4fe71a567e am: 1561dc0fa9 am: 2b9fa38bb8 am: 6e96227190 am: cd5ac287ce
...
am: 0cdffda83f
2019-05-06 17:27:22 -07:00
TreeHugger Robot
dce2f1a1a1
Merge changes from topic "am-5b50c796-9c7d-4769-bc6c-f71bdac7c742" into oc-dev
...
* changes:
[automerger] Add bounds check for tile dimensions am: 05f83e94588ee7982e467c6da2165bc11699b0f4c0d441f4a705f83e94588ee7982e467c6da2165bc11699b0f405f83e94588ee7982e467c6da2165b05f83e94588ee7982e4605f83e9458
2019-05-07 00:16:35 +00:00
TreeHugger Robot
4f46e4b626
Merge "decoder: Report unsupported bitdepth and color format as fatal errors" into qt-dev
2019-05-01 22:15:00 +00:00
Harish Mahendrakar
7461e43ed8
decoder: Report unsupported bitdepth and color format as fatal errors
...
This will ensure clips with supported bitdepth or unsupport color
formats are not attempted to be decoded till end of the sequence.
Bug: 129796771
Bug: 130578045
Test: adb shell stagefright -s -S /sdcard/crowd422_hevc.mp4
Test: Ensure decoder doesn't attemp decoding all frames
Change-Id: I7c3cd58a0e231e7e64c278564d050086a079e12c
2019-04-30 15:50:13 -07:00
Harish Mahendrakar
8925a5b7fb
Add few more checks for invalid parameters in sps
...
Following elements didn't have a bound check in SPS as spec doesn't list
the bounds on these explicitly.
log2_min_coding_block_size_minus3, log2_diff_max_min_coding_block_size,
log2_min_transform_block_size_minus2 and log2_diff_max_min_transform_block_size
Added appopriate error checks on these fields
Bug: 129366952
Bug: 130023983
Test: vendor
Change-Id: I59d95f43c2ef98300132d664095e88df8e87a164
2019-04-30 14:11:10 -07:00
Android Build Merger (Role)
2b9fa38bb8
[automerger] Add missing return check for short_term_ref_pic_set() am: 299cceb9e4 am: 2e8ae23656 am: 7ecb4083b9 am: 4fe71a567e am: 1561dc0fa9
...
Change-Id: I378a6e4f6f70931f36fd74acb02846096679e367
2019-04-23 22:29:03 +00:00
Android Build Merger (Role)
2e8ae23656
[automerger] Add missing return check for short_term_ref_pic_set() am: 299cceb9e4
...
Change-Id: I9c4d960ac4e58f57b637908524918558ae539ca4
2019-04-23 22:28:54 +00:00
Harish Mahendrakar
299cceb9e4
Add missing return check for short_term_ref_pic_set()
...
Bug: 129401104
Bug: 130025324
Test: vendor
Change-Id: I685dd29ec13cca0ced5de8eb3aea1d0da5952a62
2019-04-23 15:28:03 -07:00
Android Build Merger (Role)
adb9a9521f
[automerger] Add bounds check for tile dimensions am: 05f83e9458 am: 8ee7982e46 am: 7c6da2165b am: c11699b0f4 am: c0d441f4a7
...
Change-Id: Id59eb1cae3db497e3b7d04abd207ff69819a2331
2019-04-23 22:07:43 +00:00
Android Build Merger (Role)
8ee7982e46
[automerger] Add bounds check for tile dimensions am: 05f83e9458
...
Change-Id: Ic7ecd009be03d4a991ffde51ba0081b4fc6998a6
2019-04-23 22:07:31 +00:00
Harish Mahendrakar
05f83e9458
Add bounds check for tile dimensions
...
Bug: 129976164
Bug: 130024844
Test: vendor/poc
Change-Id: I1e54babaec9c5ad199b60c7cfc1e24e36422f630
2019-04-23 15:06:48 -07:00
Snehal Bhamare
1b4ab78b5d
Decoder: Fixing integer-overflow sanitizer issues
...
Bug: 111272481
Test: vendor
Change-Id: Idd5db33617ae55f70a1be67e0374adceafc174d3
2019-02-05 14:25:24 -08:00
S Hamsalekha
8669e83d71
Decoder: Fixing some more integer-overflow sanitizer issues
...
Bug: 111272481
Test: vendor
Change-Id: I8603d82a52def851a9af67da6fcb967963c44c69
2019-01-09 13:16:44 -08:00
Rakesh Kumar
06e94e9ceb
Decoder: Fix integer-overflow sanitizer issues
...
Bug: 111272481
Test: vendor
Change-Id: If4266a33677d98f567884ebbc7908289e42fb94f
2019-01-09 13:16:37 -08:00
Rakesh Kumar
0896f571c1
[automerger] Decoder: Signal IVD_RES_CHANGED error for change in crop params am: fdbbd60bfe am: 2c56677a61 am: 5f668de48b am: 80f7bce01d am: 4ec0aaf69b am: fea57ee069 am: a28e5a297c am: 0cbc12f971 am: ca0f470122
...
am: 9a6283799f
2018-11-19 17:44:24 -08:00
TreeHugger Robot
89937f03cd
Merge "Decoder: Signal IVD_RES_CHANGED error for change in crop params" into nyc-dev
2018-11-20 01:13:59 +00:00
Android Build Merger (Role)
fea57ee069
[automerger] Decoder: Signal IVD_RES_CHANGED error for change in crop params am: fdbbd60bfe am: 2c56677a61 am: 5f668de48b am: 80f7bce01d am: 4ec0aaf69b
...
Change-Id: I26134694e5a2b87ff929a5076b15cdbe154b1b07
2018-11-14 21:53:30 +00:00
Android Build Merger (Role)
2c56677a61
[automerger] Decoder: Signal IVD_RES_CHANGED error for change in crop params am: fdbbd60bfe
...
Change-Id: I2058a5d409bbc7076c8a45a84521f37681ee38f2
2018-11-14 21:53:25 +00:00
Rakesh Kumar
fdbbd60bfe
Decoder: Signal IVD_RES_CHANGED error for change in crop params
...
IVD_RES_CHANGED was not signaled when crop parameters changed, i.e.
display dimensions changed without change in decode dimensions.
In such cases, if output buffer was allocated as per the current
dimension being decoded, without IVD_RES_CHANGED signalled, there can be
an OOB write if the new buffer is smaller than the frame being returned
as output
Bug: 118453553
Test: vendor
Change-Id: Ic74c6fb9612403f75a8f9ddb3a93861bca82cf16
2018-11-14 13:42:41 -08:00
Shubham Tandle
9be2b750a0
[automerger] Add limits check for the CTB position in a frame am: 5a3dafc324 am: 1b95d7fa97 am: 0a5e519fc7 am: 10a9188110 am: 9d02c4ce08 am: 7a67bf3a4b am: 0f839f5785 am: b02053d366 am: b37c780786
...
am: 6423e5127b
2018-10-11 17:33:40 -07:00
Android Build Merger (Role)
7a67bf3a4b
[automerger] Add limits check for the CTB position in a frame am: 5a3dafc324 am: 1b95d7fa97 am: 0a5e519fc7 am: 10a9188110 am: 9d02c4ce08
...
Change-Id: I3cd06c961d8df7555aa1fb87c34c9a9383a58cc1
2018-10-05 21:54:10 +00:00
Android Build Merger (Role)
1b95d7fa97
[automerger] Add limits check for the CTB position in a frame am: 5a3dafc324
...
Change-Id: I68b3694c6b6c8f1aa0df204b31f0ede6327ae9fb
2018-10-05 21:54:01 +00:00
Shubham Tandle
5a3dafc324
Add limits check for the CTB position in a frame
...
Bug: 113260892
Bug: 113261108
Bug: 113261310
The decoder does not support tile position > 255.
Added error checks to ensure the same.
Test: re-run POC
Change-Id: Id359c172c8630ded2fb3f47c447f373cd2d1bc34
2018-10-05 14:53:12 -07:00
Rakesh Kumar
303b662e0d
Decoder: Memset allocated dynamic and static buffer to zero
...
Bug: 111764725
Bug: 112327675
Bug: 112326216
Test: manual
Change-Id: Ia775c77cb62fae89ac410805c9fca55522a2e555
2018-08-24 11:22:23 -07:00
Android Build Merger (Role)
a9a51a4940
[automerger] Return error for invalid st/lt sps parameters am: b93923e288 am: 797c104f3b am: 092cd28d04 am: 0e0458c8da am: 400d114e64 am: fa6d5fe71f am: 03831de632 am: 1a661cfc0e am: 8151a909f7
...
Change-Id: If66401894ec3e28da20fd560582fd97c78d4ec22
2018-04-20 21:13:43 +00:00
Android Build Merger (Role)
fa6d5fe71f
[automerger] Return error for invalid st/lt sps parameters am: b93923e288 am: 797c104f3b am: 092cd28d04 am: 0e0458c8da am: 400d114e64
...
Change-Id: I492074238997f2ce090e3f579282578f6795779c
2018-04-20 21:13:39 +00:00
Android Build Merger (Role)
400d114e64
[automerger] Return error for invalid st/lt sps parameters am: b93923e288 am: 797c104f3b am: 092cd28d04 am: 0e0458c8da
...
Change-Id: I6b3d4070c6ec92d545664ae6cae43f0a2e1733e3
2018-04-20 21:13:37 +00:00
Android Build Merger (Role)
797c104f3b
[automerger] Return error for invalid st/lt sps parameters am: b93923e288
...
Change-Id: I6b15a4359ef9228c6f707f4e104c587d189c6bfc
2018-04-20 21:13:32 +00:00
Naveen Kumar P
b93923e288
Return error for invalid st/lt sps parameters
...
When num_short_term_ref_pic_sets or num_long_term_ref_pics_sps in
sps is out of range, error is returned.
Bug: 77599438
Test: poc before/after
Change-Id: I652d27849438c3ea2d42fc6e9abb8aeb25ebdc22
2018-04-20 14:12:21 -07:00
TreeHugger Robot
dd9737ba12
Merge changes from topic "am-710d603e-2dfd-4779-8a9e-e8fd1e2198ef" into oc-dev
...
* changes:
[automerger] Return error for invalid sps sub layers parameters am: f4486cdb2f37579e833a38e104d65a247c93b2273e163fda73d2eb213a2733805721b3c9c55cb3117f03778448f4486cdb2f37579e833a38e104d65a247c93b2273e163fda73d2eb213a2733805721b3c9c55cb311f4486cdb2f37579e833a38e104d65a247c93b2273e163fda73d2eb213a2733805721b3f4486cdb2f37579e833a38e104d65a247c93b2273e163fda73d2eb213a27f4486cdb2f37579e833a38e104d65a247c93b2273e163fda73f4486cdb2f37579e833a38e104d65a247c93b227f4486cdb2f37579e833a38e104d65af4486cdb2f37579e833af4486cdb2f
2018-04-06 19:17:27 +00:00
TreeHugger Robot
08e9bcd2e8
Merge changes from topic "am-710d603e-2dfd-4779-8a9e-e8fd1e2198ef" into nyc-dr1-dev
...
* changes:
[automerger] Return error for invalid sps sub layers parameters am: f4486cdb2f37579e833a38e104d65a247c93b2273e163fda73f4486cdb2f37579e833a38e104d65a247c93b227f4486cdb2f37579e833a38e104d65af4486cdb2f37579e833af4486cdb2f
2018-04-06 19:17:27 +00:00
TreeHugger Robot
91adc13b0e
Merge changes from topic "am-710d603e-2dfd-4779-8a9e-e8fd1e2198ef" into nyc-dev
...
* changes:
[automerger] Return error for invalid sps sub layers parameters am: f4486cdb2f37579e833a38e104d65a247c93b227f4486cdb2f37579e833a38e104d65af4486cdb2f37579e833af4486cdb2f
2018-04-06 19:17:27 +00:00
TreeHugger Robot
3bc5ebb996
Merge changes from topic "am-710d603e-2dfd-4779-8a9e-e8fd1e2198ef" into mnc-dr-dev
...
* changes:
[automerger] Return error for invalid sps sub layers parameters am: f4486cdb2f
2018-04-06 19:17:27 +00:00
TreeHugger Robot
152634b8b6
Merge changes from topic "am-492ad0fb-402d-4977-be93-b82e053bee6f" into oc-dev
...
* changes:
[automerger] Add limits check for depth hierarchy sps parameters am: f7287c799346dc210bfdcd00b5307b96f3a8ba919b88c05de9914006b851208dc7fec5e0195fdd6d8a2a757acbf7287c799346dc210bfdcd00b5307b96f3a8ba919b88c05de9914006b851208dc7fec5e0195fdd6df7287c799346dc210bfdcd00b5307b96f3a8ba919b88c05de9914006b851208dc7fec5f7287c799346dc210bfdcd00b5307b96f3a8ba919b88c05de9914006b851f7287c799346dc210bfdcd00b5307b96f3a8ba919b88c05de9f7287c799346dc210bfdcd00b5307b96f3a8ba91f7287c799346dc210bfdcd00b5307bf7287c799346dc210bfdf7287c7993
2018-04-06 19:08:18 +00:00
TreeHugger Robot
de502938ff
Merge changes from topic "am-492ad0fb-402d-4977-be93-b82e053bee6f" into nyc-dr1-dev
...
* changes:
[automerger] Add limits check for depth hierarchy sps parameters am: f7287c799346dc210bfdcd00b5307b96f3a8ba919b88c05de9f7287c799346dc210bfdcd00b5307b96f3a8ba91f7287c799346dc210bfdcd00b5307bf7287c799346dc210bfdf7287c7993
2018-04-06 19:08:18 +00:00
TreeHugger Robot
b6584f925d
Merge changes from topic "am-492ad0fb-402d-4977-be93-b82e053bee6f" into nyc-dev
...
* changes:
[automerger] Add limits check for depth hierarchy sps parameters am: f7287c799346dc210bfdcd00b5307b96f3a8ba91f7287c799346dc210bfdcd00b5307bf7287c799346dc210bfdf7287c7993
2018-04-06 19:08:18 +00:00
TreeHugger Robot
f769fc96fe
Merge changes from topic "am-492ad0fb-402d-4977-be93-b82e053bee6f" into mnc-dr-dev
...
* changes:
[automerger] Add limits check for depth hierarchy sps parameters am: f7287c7993
2018-04-06 19:08:18 +00:00
Android Build Merger (Role)
e34ac4f07d
[automerger] Add limits check for depth hierarchy sps parameters am: f7287c7993 am: 46dc210bfd am: cd00b5307b am: 96f3a8ba91 am: 9b88c05de9 am: 914006b851 am: 208dc7fec5 am: e0195fdd6d am: 8a2a757acb
...
Change-Id: I6036a3964aff3a04b52f3024e31252017dbee9e1
2018-03-27 19:53:59 +00:00
Android Build Merger (Role)
914006b851
[automerger] Add limits check for depth hierarchy sps parameters am: f7287c7993 am: 46dc210bfd am: cd00b5307b am: 96f3a8ba91 am: 9b88c05de9
...
Change-Id: I2884bb46efb8272fc030b597e641e2b1cf3e9d30
2018-03-27 19:53:54 +00:00
Android Build Merger (Role)
9b88c05de9
[automerger] Add limits check for depth hierarchy sps parameters am: f7287c7993 am: 46dc210bfd am: cd00b5307b am: 96f3a8ba91
...
Change-Id: Ica2ca13d2d169fdc57fde89f503a005b506a2e6d
2018-03-27 19:53:53 +00:00
Android Build Merger (Role)
46dc210bfd
[automerger] Add limits check for depth hierarchy sps parameters am: f7287c7993
...
Change-Id: I4b03b97ead99b399a9cdfcb4be05d422afc5ddf9
2018-03-27 19:53:49 +00:00
Naveen Kumar P
f7287c7993
Add limits check for depth hierarchy sps parameters
...
Bug: 73965890
Test: run poc before/after
According to the hevc specification, max_transform_hierarchy_depth_inter
and max_transform_hierarchy_depth_intra cannot be greater than
difference between log2_ctb_size and log2_min_transform_block_size.
Change-Id: I9a6f56b029957cead3e81bd07d7fb8392a1a98a2
2018-03-27 12:53:00 -07:00
Android Build Merger (Role)
a91aead14b
[automerger] Return error for invalid sps sub layers parameters am: f4486cdb2f am: 37579e833a am: 38e104d65a am: 247c93b227 am: 3e163fda73 am: d2eb213a27 am: 33805721b3 am: c9c55cb311 am: 7f03778448
...
Change-Id: Iead61c64b675a99470f9b9a7c43b99273ceeccbf
2018-03-14 21:14:00 +00:00
Android Build Merger (Role)
d2eb213a27
[automerger] Return error for invalid sps sub layers parameters am: f4486cdb2f am: 37579e833a am: 38e104d65a am: 247c93b227 am: 3e163fda73
...
Change-Id: I0615554e3bcc95ed09c984f5cdbdabde278d53ff
2018-03-14 21:13:55 +00:00
Android Build Merger (Role)
3e163fda73
[automerger] Return error for invalid sps sub layers parameters am: f4486cdb2f am: 37579e833a am: 38e104d65a am: 247c93b227
...
Change-Id: I8e751caa7e9e0ffb3cb59923b466707d831b0ff7
2018-03-14 21:13:53 +00:00
Android Build Merger (Role)
37579e833a
[automerger] Return error for invalid sps sub layers parameters am: f4486cdb2f
...
Change-Id: Ibf6aa79e101a3cf38914e54598d9b53d68c11a05
2018-03-14 21:13:49 +00:00
Android Build Merger (Role)
8c56e181af
[automerger] Return error for invalid reorder parameter am: 4286d31e9e am: df2bef9a86 am: e7950035a8 am: b596887685 am: 3d1c41dfb1 am: a5af46e7c4 am: a01ece8616 am: a4843b0735 am: 884157609f
...
Change-Id: I1578a37ea0fb33c258cd08550fc31c849fb1eaa4
2018-03-14 21:13:05 +00:00
Android Build Merger (Role)
a5af46e7c4
[automerger] Return error for invalid reorder parameter am: 4286d31e9e am: df2bef9a86 am: e7950035a8 am: b596887685 am: 3d1c41dfb1
...
Change-Id: I49bcf6cf3713131d06edd5b29e02f60e1d757a0e
2018-03-14 21:12:59 +00:00
Android Build Merger (Role)
3d1c41dfb1
[automerger] Return error for invalid reorder parameter am: 4286d31e9e am: df2bef9a86 am: e7950035a8 am: b596887685
...
Change-Id: Ic1e961cc498ee24683f81ca13bd5d51c905d105e
2018-03-14 21:12:58 +00:00
