Commit graph

1111 commits

Author SHA1 Message Date
Ray Essick
db0571cb3d Merge "Decoder: Fixed error handling for dangling fields" into mnc-dev am: 78334b2a24 am: cd5ebec24a am: f48987d2fc am: 1cbcdd7f16 am: 3a669baf18 am: 691577d923
am: 979ad81ebd

Change-Id: I499fe2b11eeba44ae7b900f7441e207ddc6c065e
2017-03-14 22:46:51 +00:00
Ray Essick
979ad81ebd Merge "Decoder: Fixed error handling for dangling fields" into mnc-dev am: 78334b2a24 am: cd5ebec24a am: f48987d2fc am: 1cbcdd7f16 am: 3a669baf18
am: 691577d923

Change-Id: I07c896c7b311fd35754434179061177df37c4b39
2017-03-14 22:40:51 +00:00
Ray Essick
691577d923 Merge "Decoder: Fixed error handling for dangling fields" into mnc-dev am: 78334b2a24 am: cd5ebec24a am: f48987d2fc am: 1cbcdd7f16
am: 3a669baf18

Change-Id: I828a75f93c0a49474f9be6d075ca3b75d27cf8fd
2017-03-14 22:35:50 +00:00
Ray Essick
3a669baf18 Merge "Decoder: Fixed error handling for dangling fields" into mnc-dev am: 78334b2a24 am: cd5ebec24a am: f48987d2fc
am: 1cbcdd7f16

Change-Id: I2adb58066b67a321c9b7275874a7ebb04e8e7c9d
2017-03-14 22:30:50 +00:00
Ray Essick
1cbcdd7f16 Merge "Decoder: Fixed error handling for dangling fields" into mnc-dev am: 78334b2a24 am: cd5ebec24a
am: f48987d2fc

Change-Id: Iacb3fa33b1acb4f9aac85b39e662b24ac7a3f9fd
2017-03-14 22:25:50 +00:00
Ray Essick
f48987d2fc Merge "Decoder: Fixed error handling for dangling fields" into mnc-dev am: 78334b2a24
am: cd5ebec24a

Change-Id: I47c0da6fb3609c0f31d59366ce7b3f89adbdec18
2017-03-14 22:20:20 +00:00
Ray Essick
cd5ebec24a Merge "Decoder: Fixed error handling for dangling fields" into mnc-dev
am: 78334b2a24

Change-Id: Id5cb9826e72c59890526300ad9e8833b61691c20
2017-03-14 22:15:20 +00:00
Ray Essick
78334b2a24 Merge "Decoder: Fixed error handling for dangling fields" into mnc-dev 2017-03-14 22:08:38 +00:00
Marco Nelissen
1d999b7cdf resolve merge conflicts of 3654ad0 to mnc-dr-dev am: 37345554fe am: 33d9d00a3c am: 858542d83e am: 2e4b53cfb4 am: 7c50684ef0
am: 834462327b

Change-Id: I14a897695081fad3099ca3e49abf1af8f8ac5cff
2017-02-14 23:08:32 +00:00
Marco Nelissen
834462327b resolve merge conflicts of 3654ad0 to mnc-dr-dev am: 37345554fe am: 33d9d00a3c am: 858542d83e am: 2e4b53cfb4
am: 7c50684ef0

Change-Id: I6d1c0a83bd9a265df26620121d805b8c1fb42e67
2017-02-14 23:06:02 +00:00
Marco Nelissen
7c50684ef0 resolve merge conflicts of 3654ad0 to mnc-dr-dev am: 37345554fe am: 33d9d00a3c am: 858542d83e
am: 2e4b53cfb4

Change-Id: I36252dfb66db49049efbc6fe9a8e59aaf90fae35
2017-02-14 23:03:32 +00:00
Marco Nelissen
2e4b53cfb4 resolve merge conflicts of 3654ad0 to mnc-dr-dev am: 37345554fe am: 33d9d00a3c
am: 858542d83e

Change-Id: I8376533d60ce908a6a08e260f57cb6163a7fa2dd
2017-02-14 23:01:52 +00:00
Marco Nelissen
858542d83e resolve merge conflicts of 3654ad0 to mnc-dr-dev am: 37345554fe
am: 33d9d00a3c

Change-Id: Ie055bb48e15a3edaef34a9dc30dd65c0769bc1ea
2017-02-14 22:59:01 +00:00
Marco Nelissen
33d9d00a3c resolve merge conflicts of 3654ad0 to mnc-dr-dev
am: 37345554fe

Change-Id: I7117544d1e2c909e353b7df3c42cfc25a9919ecf
2017-02-14 22:55:05 +00:00
Marco Nelissen
37345554fe resolve merge conflicts of 3654ad0 to mnc-dr-dev
Bug: 33818508
Bug: 34013472
Change-Id: I2e99cbceba1c00555d624e8975522725e362362b
2017-02-14 13:49:16 -08:00
Marco Nelissen
3654ad0da5 Merge changes Iec2941f1,I38be0e4c into mnc-dev
* changes:
  Decoder: Add supported width check for MBaff streams
  Decoder: Added a check for unsupported resolutions
2017-02-14 21:30:39 +00:00
Harish Mahendrakar
f837a7796b Decoder: Fixed initialization of first_slice_in_pic am: 0b23c81c3d am: 16fa990ce1 am: ab79eb3973 am: a37d120eb2 am: c011eeade7 am: 94e17dc822
am: 9117d918dd

Change-Id: Ib6af629d81306de0abac63f619a54df3ad7fe4a9
2017-02-14 17:16:08 +00:00
Harish Mahendrakar
9432beb534 Decoder: Moved end of pic processing to end of decode call am: 494561291a am: ba7f9e2aed am: 26bb8b98ee am: 89fa016b5f am: df2fa01c9e am: 7944003371
am: fd5c8e352a

Change-Id: Ied461d89e4513b8de517c62c29fef4a7af6f180e
2017-02-14 17:13:44 +00:00
Harish Mahendrakar
9117d918dd Decoder: Fixed initialization of first_slice_in_pic am: 0b23c81c3d am: 16fa990ce1 am: ab79eb3973 am: a37d120eb2 am: c011eeade7
am: 94e17dc822

Change-Id: I41f7075004b024988d94b53be3a0b49b992e8da4
2017-02-14 17:13:37 +00:00
Harish Mahendrakar
981e88d5b8 Decoder: Treat first slice in a picture as part of new picture always am: 8b5fd8f24e am: 8b75cdae9b am: fb68ae8960 am: a8a3dc84b0 am: 3007985473 am: b19aa035f6
am: 43fa87413a

Change-Id: Ia4b5daea548db133043581e9816cea55b86f10a1
2017-02-14 17:13:37 +00:00
Harish Mahendrakar
fd5c8e352a Decoder: Moved end of pic processing to end of decode call am: 494561291a am: ba7f9e2aed am: 26bb8b98ee am: 89fa016b5f am: df2fa01c9e
am: 7944003371

Change-Id: I708b0d3bf0ec35c92ae58ac3b1efdfd8800b1ec2
2017-02-14 17:11:45 +00:00
Harish Mahendrakar
94e17dc822 Decoder: Fixed initialization of first_slice_in_pic am: 0b23c81c3d am: 16fa990ce1 am: ab79eb3973 am: a37d120eb2
am: c011eeade7

Change-Id: I3f850497c864277c2b2524fab07d14a249e48afc
2017-02-14 17:11:38 +00:00
Harish Mahendrakar
43fa87413a Decoder: Treat first slice in a picture as part of new picture always am: 8b5fd8f24e am: 8b75cdae9b am: fb68ae8960 am: a8a3dc84b0 am: 3007985473
am: b19aa035f6

Change-Id: I636809114c259353bac6a090a4b996fecb637970
2017-02-14 17:11:38 +00:00
Harish Mahendrakar
7944003371 Decoder: Moved end of pic processing to end of decode call am: 494561291a am: ba7f9e2aed am: 26bb8b98ee am: 89fa016b5f
am: df2fa01c9e

Change-Id: Ifc329cbccad01c70ff1fea0d483cb155b15b3cc1
2017-02-14 17:08:45 +00:00
Harish Mahendrakar
c011eeade7 Decoder: Fixed initialization of first_slice_in_pic am: 0b23c81c3d am: 16fa990ce1 am: ab79eb3973
am: a37d120eb2

Change-Id: Ib3eb4da620fc964a15a35d8e862b91e55a611bd4
2017-02-14 17:08:36 +00:00
Harish Mahendrakar
b19aa035f6 Decoder: Treat first slice in a picture as part of new picture always am: 8b5fd8f24e am: 8b75cdae9b am: fb68ae8960 am: a8a3dc84b0
am: 3007985473

Change-Id: I2570766293b1d7fae490523607390873ed0016f0
2017-02-14 17:08:36 +00:00
Harish Mahendrakar
df2fa01c9e Decoder: Moved end of pic processing to end of decode call am: 494561291a am: ba7f9e2aed am: 26bb8b98ee
am: 89fa016b5f

Change-Id: Ib8de0752f0e90dfea59d9e8380d2006dd9643312
2017-02-14 17:07:16 +00:00
Harish Mahendrakar
a37d120eb2 Decoder: Fixed initialization of first_slice_in_pic am: 0b23c81c3d am: 16fa990ce1
am: ab79eb3973

Change-Id: I04510ac0c549313e2082c28d81bd634df6115729
2017-02-14 17:07:07 +00:00
Harish Mahendrakar
3007985473 Decoder: Treat first slice in a picture as part of new picture always am: 8b5fd8f24e am: 8b75cdae9b am: fb68ae8960
am: a8a3dc84b0

Change-Id: I172945f3e9d84d77ae21d1f737258851529f94c7
2017-02-14 17:07:07 +00:00
Harish Mahendrakar
89fa016b5f Decoder: Moved end of pic processing to end of decode call am: 494561291a am: ba7f9e2aed
am: 26bb8b98ee

Change-Id: I0e3b1bba6e4bdb11f1d09f8d693f443c8a183198
2017-02-14 17:04:45 +00:00
Harish Mahendrakar
a8a3dc84b0 Decoder: Treat first slice in a picture as part of new picture always am: 8b5fd8f24e am: 8b75cdae9b
am: fb68ae8960

Change-Id: I7b1a01391a4bece53fc64fe4c2173c23c8137cd3
2017-02-14 17:04:37 +00:00
Harish Mahendrakar
ab79eb3973 Decoder: Fixed initialization of first_slice_in_pic am: 0b23c81c3d
am: 16fa990ce1

Change-Id: Id1b05214b3f7d67fea7b7d0a01cbb53b0182c30e
2017-02-14 17:04:36 +00:00
Harish Mahendrakar
26bb8b98ee Decoder: Moved end of pic processing to end of decode call am: 494561291a
am: ba7f9e2aed

Change-Id: I0d8d0bb4265e458dbe1932bf9fc5ff11e367d909
2017-02-14 17:03:15 +00:00
Harish Mahendrakar
16fa990ce1 Decoder: Fixed initialization of first_slice_in_pic
am: 0b23c81c3d

Change-Id: I55e49ca9616a151456342bad7673d0986098b448
2017-02-14 17:03:06 +00:00
Harish Mahendrakar
fb68ae8960 Decoder: Treat first slice in a picture as part of new picture always am: 8b5fd8f24e
am: 8b75cdae9b

Change-Id: Iaadac2cc30016f8a47d85b7b73c130761bb6f004
2017-02-14 17:03:06 +00:00
Harish Mahendrakar
ba7f9e2aed Decoder: Moved end of pic processing to end of decode call
am: 494561291a

Change-Id: Id3867f5dd0788f12f6827ed311a309d1fa58c535
2017-02-14 17:00:16 +00:00
Harish Mahendrakar
8b75cdae9b Decoder: Treat first slice in a picture as part of new picture always
am: 8b5fd8f24e

Change-Id: Ia14e9fae4a08143ff86439b5440ab9cf5e3052e3
2017-02-14 17:00:07 +00:00
Harish Mahendrakar
0b23c81c3d Decoder: Fixed initialization of first_slice_in_pic
To handle some errors, first_slice_in_pic was being set to 2.
This is now cleaned up and first_slice_in_pic is set to 1 only once per pic.
This will ensure picture level initializations are done only once even in case
of error clips

Bug: 33717589
Bug: 33551775
Bug: 33716442
Bug: 33677995

Change-Id: If341436b3cbaa724017eedddd88c2e6fac36d8ba
2017-02-14 16:59:09 +00:00
Harish Mahendrakar
494561291a Decoder: Moved end of pic processing to end of decode call
ih264d_end_of_pic() was called after parsing slice of a new picture.
This is now being done at the end of decode of the current picture.
decode_gaps_in_frame_num which needs frame_num of new slice is now
done after decoding frame_num in new slice.

This helps in handling errors in picaff streams with gaps in frames

Bug: 33588051
Bug: 33641588
Bug: 34097231
Change-Id: I1a26e611aaa2c19e2043e05a210849bd21b22220
2017-02-14 16:58:07 +00:00
Harish Mahendrakar
8b5fd8f24e Decoder: Treat first slice in a picture as part of new picture always
This is needed to decode streams with consecutive IDRs.

Bug: 34097231
Test: successful run of POC in security bug
Change-Id: Ib737a4ef4b8c5bb7a57c90292102dd28af0615fe
2017-02-14 04:41:02 +00:00
Harish Mahendrakar
4aab0f9614 DO NOT MERGE: Decoder: Fixes an out of bound write in bitstream buffer am: 1f0ab0b089 -s ours am: 4543cf41ad am: f086bb9a89 am: 2b63f25938 -s ours am: 580daabe65 am: 293fbba256
am: 9be100c242

Change-Id: Id72346d338fa9cd22bf6f78a07f44dc41381abe5
2017-02-14 00:32:40 +00:00
Harish Mahendrakar
9be100c242 DO NOT MERGE: Decoder: Fixes an out of bound write in bitstream buffer am: 1f0ab0b089 -s ours am: 4543cf41ad am: f086bb9a89 am: 2b63f25938 -s ours am: 580daabe65
am: 293fbba256

Change-Id: I107be2bad3e0269c76d44697aabd23dc62b741be
2017-02-14 00:30:10 +00:00
Harish Mahendrakar
293fbba256 DO NOT MERGE: Decoder: Fixes an out of bound write in bitstream buffer am: 1f0ab0b089 -s ours am: 4543cf41ad am: f086bb9a89 am: 2b63f25938 -s ours
am: 580daabe65

Change-Id: Ie4027efff2801f9548753cc8beb8bc3ee6d6af97
2017-02-14 00:27:40 +00:00
Harish Mahendrakar
580daabe65 DO NOT MERGE: Decoder: Fixes an out of bound write in bitstream buffer am: 1f0ab0b089 -s ours am: 4543cf41ad am: f086bb9a89
am: 2b63f25938  -s ours

Change-Id: If83559a5567460bceb3c6c0d8d7b5f97d9de4813
2017-02-14 00:24:38 +00:00
Harish Mahendrakar
2b63f25938 DO NOT MERGE: Decoder: Fixes an out of bound write in bitstream buffer am: 1f0ab0b089 -s ours am: 4543cf41ad
am: f086bb9a89

Change-Id: I1f132937d0d61c029e6add1210920db60f484b92
2017-02-14 00:21:09 +00:00
Harish Mahendrakar
f086bb9a89 DO NOT MERGE: Decoder: Fixes an out of bound write in bitstream buffer am: 1f0ab0b089 -s ours
am: 4543cf41ad

Change-Id: I1e9aee3d7423476c5662e3e89dd6adb2e0ea89bb
2017-02-14 00:18:09 +00:00
Harish Mahendrakar
4543cf41ad DO NOT MERGE: Decoder: Fixes an out of bound write in bitstream buffer
am: 1f0ab0b089  -s ours

Change-Id: Ifeab263e38c6c3ff67d6e2fe432f0b1596c17844
2017-02-14 00:15:09 +00:00
Harish Mahendrakar
69b5191865 Decoder: Add supported width check for MBaff streams
In case of MBAff streams, decoder processes two rows at a time,
this limits maximum supported width to 1920 for MBAff streams.

Bug: 33818508
Bug: 34013472
Change-Id: Iec2941f116cf3c36b63013a930319960023a3b42
2017-02-13 15:30:57 -08:00
Harish Mahendrakar
9d60a0c5da Decoder: Added a check for unsupported resolutions
Decoder now returns an error for resolutions greater than 3840x2176

Bug: 24542936

Change-Id: I38be0e4c5cf2a980bfd4c781f3b49171f73b5ccb
2017-02-13 15:30:46 -08:00
Harish Mahendrakar
1f0ab0b089 DO NOT MERGE: Decoder: Fixes an out of bound write in bitstream buffer
[this is for mnc-dev only, not any other mnc-*-dev flavors;
there is a different patch for mnc-dr-dev, nyc-* and going forward]

After emulation prevention, data is written as an int,
so at least 3 additional bytes should be available.
And since bitstream functions read 8 bytes ahead, 8 extra bytes
should be available in the bitstream buffer.

Bug: 33934721
Test: Ittiam testing, POC in the bug no longer fails
Change-Id: I444ec6f85d01b0bade9f827e15c4b476779d6c69
2017-02-13 14:44:11 -08:00