Commit graph

2539 commits

Author SHA1 Message Date
Harish Mahendrakar
cce42ea920 decoder: Move initialization of dbp_mgr entries to init_decoder() am: 01da7b5a52
am: 41fcd228ae

Change-Id: Id8fa44c3401f7ac1d2a540fa35cf0f4346da2c42
2019-11-05 16:31:59 -08:00
Harish Mahendrakar
41fcd228ae decoder: Move initialization of dbp_mgr entries to init_decoder()
am: 01da7b5a52

Change-Id: I93871c49b268b3ead96db8e44eb268c70f124379
2019-11-05 16:25:58 -08:00
Harish Mahendrakar
01da7b5a52 decoder: Move initialization of dbp_mgr entries to init_decoder()
Earlier these were only initialized during static buffer allocations.
Initializing them in init_decoder() will ensure that these get
initialized to default values during reset() as well. Without this,
in some error cases, there is a possibility of heap-use-after free,
when resolution changes and these pointers point to memory that is freed

Bug: 142602711
Test: poc in bug
Change-Id: Ie39fee0eca56bf32cdc558099bf167d05eb89620
2019-10-29 19:52:49 -07:00
Rakesh Kumar
224bcf4592 [automerger] Decoder: Delete node from st if lt and st point to same am: f312a1d305 am: f82a1f8d7f am: ae2c8cfdc1 am: 8332d0bfa2 am: 1e6ef7fee5 am: b1734142ff
am: 9460fbd521

Change-Id: I0c53bc30225153ff03d44670f6967a05e161c654
2019-05-29 14:16:23 -07:00
Rakesh Kumar
9460fbd521 [automerger] Decoder: Delete node from st if lt and st point to same am: f312a1d305 am: f82a1f8d7f am: ae2c8cfdc1 am: 8332d0bfa2 am: 1e6ef7fee5
am: b1734142ff

Change-Id: I86f63de8c4eb3c534aeafbbb592c738f8805188c
2019-05-29 14:11:21 -07:00
Android Build Merger (Role)
b1734142ff [automerger] Decoder: Delete node from st if lt and st point to same am: f312a1d305 am: f82a1f8d7f am: ae2c8cfdc1 am: 8332d0bfa2 am: 1e6ef7fee5
Change-Id: Id6d3411d949ae069369d7bef1c50f904cf9c97dc
2019-05-08 18:45:13 +00:00
Android Build Merger (Role)
1e6ef7fee5 [automerger] Decoder: Delete node from st if lt and st point to same am: f312a1d305 am: f82a1f8d7f am: ae2c8cfdc1 am: 8332d0bfa2
Change-Id: Ie1677fa6ad378564e164729d80b7d1edf4bd214c
2019-05-08 18:45:11 +00:00
Android Build Merger (Role)
8332d0bfa2 [automerger] Decoder: Delete node from st if lt and st point to same am: f312a1d305 am: f82a1f8d7f am: ae2c8cfdc1
Change-Id: Iebc6317ca7ae7f6417cfd1e1cff39110e6fe82db
2019-05-08 18:45:09 +00:00
Android Build Merger (Role)
ae2c8cfdc1 [automerger] Decoder: Delete node from st if lt and st point to same am: f312a1d305 am: f82a1f8d7f
Change-Id: Ibca538dbd7a3d262fa87ca47d3f951a9b6c1e9f4
2019-05-08 18:45:07 +00:00
Android Build Merger (Role)
f82a1f8d7f [automerger] Decoder: Delete node from st if lt and st point to same am: f312a1d305
Change-Id: I90a0c3fca5d7542301994711448d7c79fe98e704
2019-05-08 18:45:05 +00:00
Rakesh Kumar
f312a1d305 Decoder: Delete node from st if lt and st point to same
If lt_list and st_list point to same node then delete it from st.
If there is error while adding a node in bottom field of lt_list (top is
already added) then this node will be pointed by st_list also. So we need
to remove it from st_list

bug: 73552574
Test: poc before/after on Android N security branch
Change-Id: I95304c242c5854b18c5c7220d114ce6215760124
2019-05-08 11:44:40 -07:00
Harish Mahendrakar
7a6b55da22 [automerger] decoder: Signal IVD_RES_CHANGED error for change in crop params am: 442a01bf37 am: 1d7d7f9bf6 am: acacf063c2 am: f33c02ed73 am: c09d3f99ab am: 145ae0d049
am: 4402b34a4f

Change-Id: I16ce7cfc21dcb0ccf10b4ce8109a61e272765120
2018-11-27 12:10:36 -08:00
Harish Mahendrakar
4402b34a4f [automerger] decoder: Signal IVD_RES_CHANGED error for change in crop params am: 442a01bf37 am: 1d7d7f9bf6 am: acacf063c2 am: f33c02ed73 am: c09d3f99ab
am: 145ae0d049

Change-Id: I83f9555eed25009c0e8067383e938f1caf822fc3
2018-11-27 12:07:34 -08:00
Android Build Merger (Role)
145ae0d049 [automerger] decoder: Signal IVD_RES_CHANGED error for change in crop params am: 442a01bf37 am: 1d7d7f9bf6 am: acacf063c2 am: f33c02ed73 am: c09d3f99ab
Change-Id: I0dda0584bd0bf112fade0827b0460a82f8c14437
2018-11-10 18:16:37 +00:00
Android Build Merger (Role)
c09d3f99ab [automerger] decoder: Signal IVD_RES_CHANGED error for change in crop params am: 442a01bf37 am: 1d7d7f9bf6 am: acacf063c2 am: f33c02ed73
Change-Id: I8bbf6662b1fef6cc3de87422a9809b14b394a2d2
2018-11-10 18:16:36 +00:00
Android Build Merger (Role)
f33c02ed73 [automerger] decoder: Signal IVD_RES_CHANGED error for change in crop params am: 442a01bf37 am: 1d7d7f9bf6 am: acacf063c2
Change-Id: I2fd29d8974797d8b7d864d73a1c59d37b40aa0d9
2018-11-10 18:16:35 +00:00
Android Build Merger (Role)
acacf063c2 [automerger] decoder: Signal IVD_RES_CHANGED error for change in crop params am: 442a01bf37 am: 1d7d7f9bf6
Change-Id: Ifc70d8423a211de3c488f75a289c1566d836242e
2018-11-10 18:16:34 +00:00
Android Build Merger (Role)
1d7d7f9bf6 [automerger] decoder: Signal IVD_RES_CHANGED error for change in crop params am: 442a01bf37
Change-Id: I05d6d693a8e8d18cd3cf74d95271efd8a339e06f
2018-11-10 18:16:32 +00:00
Harish Mahendrakar
442a01bf37 decoder: Signal IVD_RES_CHANGED error for change in crop params
IVD_RES_CHANGED was not signaled when crop parameters changed, i.e.
display dimensions changed without change in decode dimensions.

In such cases, if output buffer was allocated as per the current
dimension being decoded, without IVD_RES_CHANGED signalled, there can be
an OOB write if the new buffer is smaller than the frame being returned
as output

Bug: 118399205
Test: vendor
Change-Id: Ia750a99cda08a3254a6f8ea8b55d07e655b34d05
2018-11-10 10:16:06 -08:00
Hamsalekha S
5703c42e4c [automerger] Bug fix for flush without valid frames am: 10c1176f1b am: 54fe392964 am: 6261ed297b am: 051d4fb2dc am: 1863b7cc03 am: e6d4971fdb am: 309f184ed5 am: 99015cf2e6 skipped: eb9952c5f1 am: 8788730e4b
am: 7ff5530ec9

Change-Id: I4993adfc92850633be431d922d1ff822a1d66ac2
2018-05-25 14:10:19 -07:00
Hamsalekha S
7ff5530ec9 [automerger] Bug fix for flush without valid frames am: 10c1176f1b am: 54fe392964 am: 6261ed297b am: 051d4fb2dc am: 1863b7cc03 am: e6d4971fdb am: 309f184ed5 am: 99015cf2e6 skipped: eb9952c5f1
am: 8788730e4b

Change-Id: I57570577b07891092037e205db524574b36fdf8a
2018-05-25 14:05:48 -07:00
Android Build Merger (Role)
8788730e4b [automerger] Bug fix for flush without valid frames am: 10c1176f1b am: 54fe392964 am: 6261ed297b am: 051d4fb2dc am: 1863b7cc03 am: e6d4971fdb am: 309f184ed5 am: 99015cf2e6 skipped: eb9952c5f1
Change-Id: I40ed642f6851cb04bcf578922f1f4cf4dce81bc5
2018-05-21 23:45:34 +00:00
Android Build Merger (Role)
eb9952c5f1 [automerger] Bug fix for flush without valid frames am: 10c1176f1b am: 54fe392964 am: 6261ed297b am: 051d4fb2dc am: 1863b7cc03 am: e6d4971fdb am: 309f184ed5 am: 99015cf2e6
Change-Id: I1fbf4c51536d8b759988b7869e3762854d832aa0
2018-05-21 23:36:29 +00:00
Android Build Merger (Role)
99015cf2e6 [automerger] Bug fix for flush without valid frames am: 10c1176f1b am: 54fe392964 am: 6261ed297b am: 051d4fb2dc am: 1863b7cc03 am: e6d4971fdb am: 309f184ed5
Change-Id: I1a46096968e5ba105ab3c8d8adf8891b097575bb
2018-05-21 23:36:28 +00:00
Android Build Merger (Role)
309f184ed5 [automerger] Bug fix for flush without valid frames am: 10c1176f1b am: 54fe392964 am: 6261ed297b am: 051d4fb2dc am: 1863b7cc03 am: e6d4971fdb
Change-Id: I24d6ff4f49063c54f1326e0280caea4ed636c5d9
2018-05-21 23:36:27 +00:00
Android Build Merger (Role)
e6d4971fdb [automerger] Bug fix for flush without valid frames am: 10c1176f1b am: 54fe392964 am: 6261ed297b am: 051d4fb2dc am: 1863b7cc03
Change-Id: Ibd65acb3016732e53b25cb4aee2ec58076f6340f
2018-05-21 23:36:25 +00:00
Android Build Merger (Role)
1863b7cc03 [automerger] Bug fix for flush without valid frames am: 10c1176f1b am: 54fe392964 am: 6261ed297b am: 051d4fb2dc
Change-Id: I836923c5188a8b7090f8d0afa76de02f501df147
2018-05-21 23:36:24 +00:00
Android Build Merger (Role)
051d4fb2dc [automerger] Bug fix for flush without valid frames am: 10c1176f1b am: 54fe392964 am: 6261ed297b
Change-Id: I6dc330eae917f98dc8be65b123c8f77aa4b75ddd
2018-05-21 23:36:23 +00:00
Android Build Merger (Role)
6261ed297b [automerger] Bug fix for flush without valid frames am: 10c1176f1b am: 54fe392964
Change-Id: Ie3423ba1be63c8a26a05d0c1c7ca1c0281ed95ca
2018-05-21 23:36:22 +00:00
Android Build Merger (Role)
54fe392964 [automerger] Bug fix for flush without valid frames am: 10c1176f1b
Change-Id: Ie26a4e3f41ab437f9d41bddb0a1166274fc3a261
2018-05-21 23:36:19 +00:00
Hamsalekha S
10c1176f1b Bug fix for flush without valid frames
We now return fail and get out of flush mode to accept bitstream in the next call.

Bug: 35585952
Bug: 63521984
Test: test case does not hang
Change-Id: Id22cc98d4a47714475a67918990a181a805c4c9f
2018-05-21 15:36:09 -07:00
Akshata Jadhav
f01457548f [automerger] Encoder: Return error for odd resolution am: 9fa58d4db3 am: f56e0c0ed3 am: db53adff11 am: 538e4ed787 am: c8fc4c0206 am: 2e1c177836 am: 353851c307 am: 207d68137f am: 0bc2eef47a am: 1f7f247c05
am: f4ad409786

Change-Id: If3199503d8f6ff797a85bfe31ce691e884bc220c
2018-04-14 16:15:44 -07:00
Akshata Jadhav
f4ad409786 [automerger] Encoder: Return error for odd resolution am: 9fa58d4db3 am: f56e0c0ed3 am: db53adff11 am: 538e4ed787 am: c8fc4c0206 am: 2e1c177836 am: 353851c307 am: 207d68137f am: 0bc2eef47a
am: 1f7f247c05

Change-Id: I50b2531f3de70bf439b6fb17678075501e0f9784
2018-04-14 16:01:07 -07:00
Ray Essick
aae5950f58 Merge "Encoder: Return error for odd resolution" into mnc-dev 2018-04-14 18:41:19 +00:00
Android Build Merger (Role)
1f7f247c05 [automerger] Encoder: Return error for odd resolution am: 9fa58d4db3 am: f56e0c0ed3 am: db53adff11 am: 538e4ed787 am: c8fc4c0206 am: 2e1c177836 am: 353851c307 am: 207d68137f am: 0bc2eef47a
Change-Id: I297abfd8a036563e093bdb3100ff7cee48f228c2
2018-04-14 18:39:01 +00:00
Android Build Merger (Role)
0bc2eef47a [automerger] Encoder: Return error for odd resolution am: 9fa58d4db3 am: f56e0c0ed3 am: db53adff11 am: 538e4ed787 am: c8fc4c0206 am: 2e1c177836 am: 353851c307 am: 207d68137f
Change-Id: Id55265d63847b1e8f0b402d073525025c075f15c
2018-04-14 18:39:00 +00:00
Android Build Merger (Role)
207d68137f [automerger] Encoder: Return error for odd resolution am: 9fa58d4db3 am: f56e0c0ed3 am: db53adff11 am: 538e4ed787 am: c8fc4c0206 am: 2e1c177836 am: 353851c307
Change-Id: Ibf72a41273b0464a106ef0896cf7af463cf214b4
2018-04-14 18:38:59 +00:00
Android Build Merger (Role)
353851c307 [automerger] Encoder: Return error for odd resolution am: 9fa58d4db3 am: f56e0c0ed3 am: db53adff11 am: 538e4ed787 am: c8fc4c0206 am: 2e1c177836
Change-Id: I601a128879fde004c128a78cc0345228f7e598f7
2018-04-14 18:38:58 +00:00
Android Build Merger (Role)
2e1c177836 [automerger] Encoder: Return error for odd resolution am: 9fa58d4db3 am: f56e0c0ed3 am: db53adff11 am: 538e4ed787 am: c8fc4c0206
Change-Id: Iafdb9ee561ac366c63959b5b392e37fe81771a9f
2018-04-14 18:38:56 +00:00
Android Build Merger (Role)
c8fc4c0206 [automerger] Encoder: Return error for odd resolution am: 9fa58d4db3 am: f56e0c0ed3 am: db53adff11 am: 538e4ed787
Change-Id: I58ab8312cb0a5a4bd85eedb2ff55f2c82fa5e79d
2018-04-14 18:38:55 +00:00
Android Build Merger (Role)
538e4ed787 [automerger] Encoder: Return error for odd resolution am: 9fa58d4db3 am: f56e0c0ed3 am: db53adff11
Change-Id: I30c26c96a6934aa4f4d1927faf05bb37e8066b06
2018-04-14 18:38:54 +00:00
Android Build Merger (Role)
db53adff11 [automerger] Encoder: Return error for odd resolution am: 9fa58d4db3 am: f56e0c0ed3
Change-Id: I7911535cdf5465bf732869272705b17ed1f165a3
2018-04-14 18:38:52 +00:00
Android Build Merger (Role)
f56e0c0ed3 [automerger] Encoder: Return error for odd resolution am: 9fa58d4db3
Change-Id: I4b71af182f1d2be051bc831dfe134b4c012048af
2018-04-14 18:38:50 +00:00
Ritu Baldwa
777146501f [automerger] Decoder: Modify setting short term reference field flag am: 47cc04b40c am: 1991ec77e7 am: c18d0ab03a am: 8f05a87c39 am: ce46d15877 am: 8781a2aa9b am: 9cb460fb64 am: bae32f4c46 am: b8dd278100 am: 2dfd8c6d91
am: e44fbd93cb

Change-Id: Ie4be903f762a324339626d2ce95aca16592fa213
2018-04-05 18:22:54 -07:00
Ritu Baldwa
e44fbd93cb [automerger] Decoder: Modify setting short term reference field flag am: 47cc04b40c am: 1991ec77e7 am: c18d0ab03a am: 8f05a87c39 am: ce46d15877 am: 8781a2aa9b am: 9cb460fb64 am: bae32f4c46 am: b8dd278100
am: 2dfd8c6d91

Change-Id: Icc4b494ef1b45fdb38f478395532d47de6b5e572
2018-04-05 18:16:23 -07:00
Android Build Merger (Role)
2dfd8c6d91 [automerger] Decoder: Modify setting short term reference field flag am: 47cc04b40c am: 1991ec77e7 am: c18d0ab03a am: 8f05a87c39 am: ce46d15877 am: 8781a2aa9b am: 9cb460fb64 am: bae32f4c46 am: b8dd278100
Change-Id: I9d0d825dc092c033eea729ea51eb8915c2502a68
2018-03-28 17:26:02 +00:00
Android Build Merger (Role)
b8dd278100 [automerger] Decoder: Modify setting short term reference field flag am: 47cc04b40c am: 1991ec77e7 am: c18d0ab03a am: 8f05a87c39 am: ce46d15877 am: 8781a2aa9b am: 9cb460fb64 am: bae32f4c46
Change-Id: I08654a8c17e20ca0dd1ab433e85f98127418634f
2018-03-28 17:26:01 +00:00
Android Build Merger (Role)
bae32f4c46 [automerger] Decoder: Modify setting short term reference field flag am: 47cc04b40c am: 1991ec77e7 am: c18d0ab03a am: 8f05a87c39 am: ce46d15877 am: 8781a2aa9b am: 9cb460fb64
Change-Id: Ia59cc5ad109277c015f14f84f91df875ba0a35fd
2018-03-28 17:26:00 +00:00
Android Build Merger (Role)
9cb460fb64 [automerger] Decoder: Modify setting short term reference field flag am: 47cc04b40c am: 1991ec77e7 am: c18d0ab03a am: 8f05a87c39 am: ce46d15877 am: 8781a2aa9b
Change-Id: Iee68471f672970bf11e1066da18be4208d87c595
2018-03-28 17:25:59 +00:00
Android Build Merger (Role)
8781a2aa9b [automerger] Decoder: Modify setting short term reference field flag am: 47cc04b40c am: 1991ec77e7 am: c18d0ab03a am: 8f05a87c39 am: ce46d15877
Change-Id: I9946acaead19bd15f5953a791429e12c5a5cf9df
2018-03-28 17:25:57 +00:00