Harish Mahendrakar
c011eeade7
Decoder: Fixed initialization of first_slice_in_pic am: 0b23c81c3d am: 16fa990ce1 am: ab79eb3973
...
am: a37d120eb2
2017-02-14 17:08:36 +00:00
Harish Mahendrakar
df2fa01c9e
Decoder: Moved end of pic processing to end of decode call am: 494561291a am: ba7f9e2aed am: 26bb8b98ee
...
am: 89fa016b5f
2017-02-14 17:07:16 +00:00
Harish Mahendrakar
a37d120eb2
Decoder: Fixed initialization of first_slice_in_pic am: 0b23c81c3d am: 16fa990ce1
...
am: ab79eb3973
2017-02-14 17:07:07 +00:00
Harish Mahendrakar
3007985473
Decoder: Treat first slice in a picture as part of new picture always am: 8b5fd8f24e am: 8b75cdae9b am: fb68ae8960
...
am: a8a3dc84b0
2017-02-14 17:07:07 +00:00
Harish Mahendrakar
89fa016b5f
Decoder: Moved end of pic processing to end of decode call am: 494561291a am: ba7f9e2aed
...
am: 26bb8b98ee
2017-02-14 17:04:45 +00:00
Harish Mahendrakar
a8a3dc84b0
Decoder: Treat first slice in a picture as part of new picture always am: 8b5fd8f24e am: 8b75cdae9b
...
am: fb68ae8960
2017-02-14 17:04:37 +00:00
Harish Mahendrakar
ab79eb3973
Decoder: Fixed initialization of first_slice_in_pic am: 0b23c81c3d
...
am: 16fa990ce1
2017-02-14 17:04:36 +00:00
Harish Mahendrakar
26bb8b98ee
Decoder: Moved end of pic processing to end of decode call am: 494561291a
...
am: ba7f9e2aed
2017-02-14 17:03:15 +00:00
Harish Mahendrakar
fb68ae8960
Decoder: Treat first slice in a picture as part of new picture always am: 8b5fd8f24e
...
am: 8b75cdae9b
2017-02-14 17:03:06 +00:00
Harish Mahendrakar
16fa990ce1
Decoder: Fixed initialization of first_slice_in_pic
...
am: 0b23c81c3d
2017-02-14 17:03:06 +00:00
Harish Mahendrakar
ba7f9e2aed
Decoder: Moved end of pic processing to end of decode call
...
am: 494561291a
2017-02-14 17:00:16 +00:00
Harish Mahendrakar
8b75cdae9b
Decoder: Treat first slice in a picture as part of new picture always
...
am: 8b5fd8f24e
2017-02-14 17:00:07 +00:00
Harish Mahendrakar
0b23c81c3d
Decoder: Fixed initialization of first_slice_in_pic
...
To handle some errors, first_slice_in_pic was being set to 2.
This is now cleaned up and first_slice_in_pic is set to 1 only once per pic.
This will ensure picture level initializations are done only once even in case
of error clips
Bug: 33717589
Bug: 33551775
Bug: 33716442
Bug: 33677995
Change-Id: If341436b3cbaa724017eedddd88c2e6fac36d8ba
2017-02-14 16:59:09 +00:00
Harish Mahendrakar
494561291a
Decoder: Moved end of pic processing to end of decode call
...
ih264d_end_of_pic() was called after parsing slice of a new picture.
This is now being done at the end of decode of the current picture.
decode_gaps_in_frame_num which needs frame_num of new slice is now
done after decoding frame_num in new slice.
This helps in handling errors in picaff streams with gaps in frames
Bug: 33588051
Bug: 33641588
Bug: 34097231
Change-Id: I1a26e611aaa2c19e2043e05a210849bd21b22220
2017-02-14 16:58:07 +00:00
Harish Mahendrakar
8b5fd8f24e
Decoder: Treat first slice in a picture as part of new picture always
...
This is needed to decode streams with consecutive IDRs.
Bug: 34097231
Test: successful run of POC in security bug
Change-Id: Ib737a4ef4b8c5bb7a57c90292102dd28af0615fe
2017-02-14 04:41:02 +00:00
Harish Mahendrakar
580daabe65
DO NOT MERGE: Decoder: Fixes an out of bound write in bitstream buffer am: 1f0ab0b089 -s ours am: 4543cf41ad am: f086bb9a89
...
am: 2b63f25938
2017-02-14 00:24:38 +00:00
Harish Mahendrakar
2b63f25938
DO NOT MERGE: Decoder: Fixes an out of bound write in bitstream buffer am: 1f0ab0b089 -s ours am: 4543cf41ad
...
am: f086bb9a89
2017-02-14 00:21:09 +00:00
Harish Mahendrakar
f086bb9a89
DO NOT MERGE: Decoder: Fixes an out of bound write in bitstream buffer am: 1f0ab0b089 -s ours
...
am: 4543cf41ad
2017-02-14 00:18:09 +00:00
Harish Mahendrakar
4543cf41ad
DO NOT MERGE: Decoder: Fixes an out of bound write in bitstream buffer
...
am: 1f0ab0b089
2017-02-14 00:15:09 +00:00
Harish Mahendrakar
1f0ab0b089
DO NOT MERGE: Decoder: Fixes an out of bound write in bitstream buffer
...
[this is for mnc-dev only, not any other mnc-*-dev flavors;
there is a different patch for mnc-dr-dev, nyc-* and going forward]
After emulation prevention, data is written as an int,
so at least 3 additional bytes should be available.
And since bitstream functions read 8 bytes ahead, 8 extra bytes
should be available in the bitstream buffer.
Bug: 33934721
Test: Ittiam testing, POC in the bug no longer fails
Change-Id: I444ec6f85d01b0bade9f827e15c4b476779d6c69
2017-02-13 14:44:11 -08:00
Ray Essick
933d00bfdc
Merge "Decoder: Return correct error code for slice header errors" into mnc-dev am: 51ecbcabfb am: cf05624312 am: f0bcc3dfaa
...
am: 3780d87265
2017-02-13 19:29:08 +00:00
Ray Essick
ec93be1ae9
Merge "Decoder: Initialize default reference buffers for all pictures" into mnc-dev am: d61abc5195 am: 16306f7347 am: 0fbfecd7ce
...
am: 6fe876a014
2017-02-13 19:28:57 +00:00
Harish Mahendrakar
2785504d50
Fix in returning end of bitstream error for MBAFF am: 7950bf47b6 am: 73f74a84e1 am: f23ebcfab1
...
am: c8b03b10df
2017-02-13 19:28:49 +00:00
Ray Essick
3780d87265
Merge "Decoder: Return correct error code for slice header errors" into mnc-dev am: 51ecbcabfb am: cf05624312
...
am: f0bcc3dfaa
2017-02-13 19:26:39 +00:00
Ray Essick
6fe876a014
Merge "Decoder: Initialize default reference buffers for all pictures" into mnc-dev am: d61abc5195 am: 16306f7347
...
am: 0fbfecd7ce
2017-02-13 19:26:29 +00:00
Harish Mahendrakar
c8b03b10df
Fix in returning end of bitstream error for MBAFF am: 7950bf47b6 am: 73f74a84e1
...
am: f23ebcfab1
2017-02-13 19:26:20 +00:00
Ray Essick
f0bcc3dfaa
Merge "Decoder: Return correct error code for slice header errors" into mnc-dev am: 51ecbcabfb
...
am: cf05624312
2017-02-13 19:23:36 +00:00
Ray Essick
0fbfecd7ce
Merge "Decoder: Initialize default reference buffers for all pictures" into mnc-dev am: d61abc5195
...
am: 16306f7347
2017-02-13 19:23:27 +00:00
Harish Mahendrakar
f23ebcfab1
Fix in returning end of bitstream error for MBAFF am: 7950bf47b6
...
am: 73f74a84e1
2017-02-13 19:23:18 +00:00
Ray Essick
cf05624312
Merge "Decoder: Return correct error code for slice header errors" into mnc-dev
...
am: 51ecbcabfb
2017-02-13 19:21:06 +00:00
Ray Essick
16306f7347
Merge "Decoder: Initialize default reference buffers for all pictures" into mnc-dev
...
am: d61abc5195
2017-02-13 19:20:57 +00:00
Harish Mahendrakar
73f74a84e1
Fix in returning end of bitstream error for MBAFF
...
am: 7950bf47b6
2017-02-13 19:20:47 +00:00
Ray Essick
51ecbcabfb
Merge "Decoder: Return correct error code for slice header errors" into mnc-dev
2017-02-13 19:15:36 +00:00
Ray Essick
d61abc5195
Merge "Decoder: Initialize default reference buffers for all pictures" into mnc-dev
2017-02-13 19:15:31 +00:00
Harish Mahendrakar
9a00f562a6
Decoder: Return correct error code for slice header errors
...
Return ERROR_INV_SLICE_HDR_T instead of ERROR_INV_SPS_PPS_T for slice
header errors.
Bug: 34097915
Change-Id: I45d14a71f2322ff349058baaf65fb0f3c1140fba
2017-02-13 19:14:59 +00:00
Harish Mahendrakar
f634481e94
Decoder: Initialize default reference buffers for all pictures
...
Reference buffer is now initialized to default value for
each pic before decoding the first slice in the pic
Bug: 34097866
Change-Id: Id64b123af2188217ce833f11db0e6c0681d41dfd
2017-02-13 19:14:50 +00:00
Harish Mahendrakar
7950bf47b6
Fix in returning end of bitstream error for MBAFF
...
In case of MBAFF streams, slices should terminate on
even MB boundary. If bytes are exhausted with odd number
of MBs decoded for MBAff, then treat that as error.
Bug: 33933140
Change-Id: Ifc26b66ff8ebdb3aec5c0d6c512e4cac3f54c5b7
2017-02-13 19:14:18 +00:00
Harish Mahendrakar
73a3e320d8
Decoder: Fixes an out of bound write in bitstream buffer am: 33ef7de9dd am: 0aab4958fb
...
am: 9f72b6eca1
2017-02-13 18:49:46 +00:00
Harish Mahendrakar
9f72b6eca1
Decoder: Fixes an out of bound write in bitstream buffer am: 33ef7de9dd
...
am: 0aab4958fb
2017-02-13 18:47:15 +00:00
Harish Mahendrakar
0aab4958fb
Decoder: Fixes an out of bound write in bitstream buffer
...
am: 33ef7de9dd
2017-02-13 18:44:45 +00:00
Harish Mahendrakar
33ef7de9dd
Decoder: Fixes an out of bound write in bitstream buffer
...
[for mnc-dr-dev and later; mnc-dev gets a different patch]
After emulation prevention, data is written as an int,
so at least 3 additional bytes should be available.
And since bitstream functions read 8 bytes ahead, 8 extra bytes
should be available in the bitstream buffer.
Bug: 33934721
Change-Id: I444ec6f85d01b0bade9f827e15c4b476779d6c69
2017-01-19 09:17:00 -08:00
Ray Essick
2131a8fa75
Merge "Decoder: Initialize ps_cur_slice->u1_mbaff_frame_flag correctly for error cases" into mnc-dev am: 43a184ad48 am: ab0e425406 am: ecfc52702b
...
am: 9b41bebc84
2017-01-18 21:17:49 +00:00
Harish Mahendrakar
f8b3e57266
Decoder: Initialize ps_cur_slice->u1_mbaff_frame_flag correctly for error cases am: 1d5640f2f9 am: 5a26569fa3 am: 18a58ec2b6
...
am: 575fdb281f
2017-01-18 21:17:41 +00:00
Ray Essick
9b41bebc84
Merge "Decoder: Initialize ps_cur_slice->u1_mbaff_frame_flag correctly for error cases" into mnc-dev am: 43a184ad48 am: ab0e425406
...
am: ecfc52702b
2017-01-18 21:15:21 +00:00
Harish Mahendrakar
575fdb281f
Decoder: Initialize ps_cur_slice->u1_mbaff_frame_flag correctly for error cases am: 1d5640f2f9 am: 5a26569fa3
...
am: 18a58ec2b6
2017-01-18 21:15:11 +00:00
Ray Essick
ecfc52702b
Merge "Decoder: Initialize ps_cur_slice->u1_mbaff_frame_flag correctly for error cases" into mnc-dev am: 43a184ad48
...
am: ab0e425406
2017-01-18 21:13:19 +00:00
Harish Mahendrakar
18a58ec2b6
Decoder: Initialize ps_cur_slice->u1_mbaff_frame_flag correctly for error cases am: 1d5640f2f9
...
am: 5a26569fa3
2017-01-18 21:13:12 +00:00
Ray Essick
ab0e425406
Merge "Decoder: Initialize ps_cur_slice->u1_mbaff_frame_flag correctly for error cases" into mnc-dev
...
am: 43a184ad48
2017-01-18 21:11:12 +00:00
Harish Mahendrakar
5a26569fa3
Decoder: Initialize ps_cur_slice->u1_mbaff_frame_flag correctly for error cases
...
am: 1d5640f2f9
2017-01-18 21:11:11 +00:00
Ray Essick
43a184ad48
Merge "Decoder: Initialize ps_cur_slice->u1_mbaff_frame_flag correctly for error cases" into mnc-dev
2017-01-18 21:00:19 +00:00
