No description
7a7f386648
## Summary Modifiers on functional utilities that resolve a named theme value are silently dropped instead of invalidating the candidate. For example, with the default theme: - `rounded-sm/[5]` emits the same CSS as `rounded-sm` (the `[5]` is ignored) - `shadow-sm/foo`, `inset-shadow-sm/foo`, `text-shadow/foo`, and `drop-shadow/foo` emit the full shadow CSS with the invalid `foo` modifier ignored This is inconsistent with how every sibling code path behaves: `rounded/foo`, `rounded-[4px]/foo`, `rounded-sm/5`, and `drop-shadow-xl/foo` all correctly produce no output, because those paths check `candidate.modifier`. This PR adds the missing guards: - In the generic `functionalUtility` handler, a candidate whose named value resolves from the theme now rejects modifiers (except fractions like `w-1/2`, where the modifier is part of the resolved value). - The `shadow`, `inset-shadow`, and `text-shadow` utilities now apply the same `if (candidate.modifier && !alpha) return` guard in their default-value, arbitrary-value, and named-size branches that `drop-shadow` already applies, and `drop-shadow` gets it in its default-value branch too. Existing tests asserting candidates like `drop-shadow/foo` produce no output were passing for the wrong reason: they run without a theme, so the theme lookup fails before the modifier is ever considered. The new tests provide a theme so the invalid modifier is what invalidates the candidate. ## Test plan - Added assertions to the `rounded`, `filter`, `shadow`, `inset-shadow`, and `text-shadow` tests that compile candidates with invalid modifiers against a theme that defines the relevant values, and expect no output. All of them fail without the fix. - `pnpm vitest run packages/tailwindcss/src/utilities.test.ts` — 398 passed. --------- Co-authored-by: Robin Malfait <malfait.robin@gmail.com> |
||
|---|---|---|
| .github | ||
| crates | ||
| integrations | ||
| packages | ||
| patches | ||
| playgrounds | ||
| scripts | ||
| .gitignore | ||
| .prettierignore | ||
| Cargo.lock | ||
| Cargo.toml | ||
| CHANGELOG.md | ||
| LICENSE | ||
| package.json | ||
| pnpm-lock.yaml | ||
| pnpm-workspace.yaml | ||
| README.md | ||
| rust-toolchain.toml | ||
| turbo.json | ||
| vitest.config.mts | ||
A utility-first CSS framework for rapidly building custom user interfaces.
Documentation
For full documentation, visit tailwindcss.com.
Community
For help, discussion about best practices, or feature ideas:
Discuss Tailwind CSS on GitHub
Contributing
If you're interested in contributing to Tailwind CSS, please read our contributing docs before submitting a pull request.