wrapper/tailwindcss
1
0
Fork 0
Code Issues Pull requests Projects Releases 1 Packages Wiki Activity Actions

fix: correct column number to be 1-based

Browse source 
createLineTable().find() returns 0-based columns per source map spec,
but users expect 1-based column numbers. Add 1 to column before
formatting error message so both line and column are 1-based and accurate.

Addresses reviewer feedback about off-by-one column numbers.
This commit is contained in:
ish1416 2025-11-10 13:05:38 +05:30
parent 2aa3682cb5
commit d9d5ea31f3
2 changed files with 5 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

8
packages/tailwindcss/src/css-parser.test.ts
View file

@ -1219,7 +1219,7 @@ describe.each(['Unix', 'Windows'])('Line endings: %s', (lineEndings) => {
it('should include filename and line number in error messages when from option is provided', () => {
expect(() => {
CSS.parse('.test { */ }', { from: 'test.css' })
}).toThrow(/CssSyntaxError: Invalid declaration: `\*\/` at test\.css:1:9/)
}).toThrow(/CssSyntaxError: Invalid declaration: `\*\/` at test\.css:1:10/)
})
it('should include filename and line number for multi-line CSS errors', () => {
@ -1230,7 +1230,7 @@ describe.each(['Unix', 'Windows'])('Line endings: %s', (lineEndings) => {
}`
expect(() => {
CSS.parse(multiLineCss, { from: 'styles.css' })
}).toThrow(/CssSyntaxError: Invalid declaration: `\*\/` at styles\.css:4:3/)
}).toThrow(/CssSyntaxError: Invalid declaration: `\*\/` at styles\.css:4:4/)
})
it('should include filename and line number for missing opening brace errors', () => {
@ -1243,7 +1243,7 @@ describe.each(['Unix', 'Windows'])('Line endings: %s', (lineEndings) => {
}`
expect(() => {
CSS.parse(cssWithMissingBrace, { from: 'broken.css' })
}).toThrow(/CssSyntaxError: Missing opening \{ at broken\.css:7:1/)
}).toThrow(/CssSyntaxError: Missing opening \{ at broken\.css:7:2/)
})
it('should include filename and line number for unterminated string errors', () => {
@ -1253,7 +1253,7 @@ describe.each(['Unix', 'Windows'])('Line endings: %s', (lineEndings) => {
}`
expect(() => {
CSS.parse(cssWithUnterminatedString, { from: 'string-error.css' })
}).toThrow(/CssSyntaxError: Unterminated string: "Hello world!" at string-error\.css:2:12/)
}).toThrow(/CssSyntaxError: Unterminated string: "Hello world!" at string-error\.css:2:13/)
})
})

2
packages/tailwindcss/src/css-parser.ts
View file

@ -43,7 +43,7 @@ export class CssSyntaxError extends Error {
super(message)
} else {
const { line, column } = createLineTable(source.code).find(position)
super(`${message} at ${source.file}:${line}:${column}`)
super(`${message} at ${source.file}:${line}:${column + 1}`)
}
this.name = 'CssSyntaxError'
}