From 93cddddaa0baac725d72feeb768d7fa4b82b1f0b Mon Sep 17 00:00:00 2001 From: Dave Wasmer Date: Mon, 4 May 2020 22:26:55 -0600 Subject: [PATCH 1/2] Improve error message for missing variant --- src/lib/substituteVariantsAtRules.js | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/lib/substituteVariantsAtRules.js b/src/lib/substituteVariantsAtRules.js index 931ebacfc..01d9885b8 100644 --- a/src/lib/substituteVariantsAtRules.js +++ b/src/lib/substituteVariantsAtRules.js @@ -78,6 +78,9 @@ export default function(config, { variantGenerators: pluginVariantGenerators }) } _.forEach(_.without(ensureIncludesDefault(variants), 'responsive'), variant => { + if (!variantGenerators[variant]) { + throw new Error(`Your config mentions the "${variant}" variant, but "${variant}" doesn't appear to be a variant. Did you forget or misconfigure a plugin that supplies that variant?`); + } variantGenerators[variant](atRule, config) }) From 9d6e8bc8b30a3c4acb0b471967ddd2b59c2c2380 Mon Sep 17 00:00:00 2001 From: Adam Wathan Date: Tue, 5 May 2020 07:47:57 -0400 Subject: [PATCH 2/2] Fix style --- src/lib/substituteVariantsAtRules.js | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/lib/substituteVariantsAtRules.js b/src/lib/substituteVariantsAtRules.js index 01d9885b8..2ae282846 100644 --- a/src/lib/substituteVariantsAtRules.js +++ b/src/lib/substituteVariantsAtRules.js @@ -79,7 +79,9 @@ export default function(config, { variantGenerators: pluginVariantGenerators }) _.forEach(_.without(ensureIncludesDefault(variants), 'responsive'), variant => { if (!variantGenerators[variant]) { - throw new Error(`Your config mentions the "${variant}" variant, but "${variant}" doesn't appear to be a variant. Did you forget or misconfigure a plugin that supplies that variant?`); + throw new Error( + `Your config mentions the "${variant}" variant, but "${variant}" doesn't appear to be a variant. Did you forget or misconfigure a plugin that supplies that variant?` + ) } variantGenerators[variant](atRule, config) })