tailwindcss/tests/minimum-impact-selector.test.js

30 lines
2.2 KiB
JavaScript
Raw Permalink Normal View History

Enable optimize universal defaults by default (#5635) * enabled `optimizeUniversalDefaults` by default This PR is done in a way so that the default is set to `true`, but you can still disable it if it causes issues. In this case we do appreciate an issue in that case 😅. * update tests to use optimized universal selector * update integration tests * add dedicated tests for the optimized universal selector * improve minimumImpactSelector algorithm I think I cracked the algorithm, but I will probably need another pair of eyes on the subject. The current implementation works like this: Prerequisites: - The selector should already have been parsed using the selectorParser from 'postcss-selector-parser'. Algorithm: 1. Remove all of the pseudo classes from the list of nodes. 1.1. We do want to keep pseudo elements (E.g.: `::before`, `::first-line`, ...) 1.2. We do want to keep pseudo classes that contain nodes (E.g.: `:not(...)`) 2. Reverse the list of nodes. This will make it easier to search from the end to the start. For example `.group:hover .group-hover` should result in `.group-hover` not `.group`. 2.1. Find the index of the best match (class, id, attribute), and convert the node if required. (E.g.: `span#app` -> `#app` => `[id="app"]`) 2.2. Remove the rest of the selector that is not important anymore 2.3. Re-join the left-over nodes together * update tests using new algorithm * also look for `tag` types * take `tag` into account * simplify logic * add test to prove `rest.reverse()` in first case is required In case we don't find a match (idx === -1), we use `rest.reverse()`. However, it looks like you can just use `nodes` instead. This is not entirely true, because the `rest` variable will contain only the nodes that are not pseudo elements. `*:hover` would result in `*:hover` instead of just `*` * replace all nodes after > with a single universal selector
2021-10-06 17:45:26 +02:00
import { elementSelectorParser } from '../src/lib/resolveDefaultsAtRules'
it.each`
before | after
${'*'} | ${'*'}
${'*:hover'} | ${'*'}
${'* > *'} | ${'* > *'}
${'.foo'} | ${'.foo'}
${'.foo:hover'} | ${'.foo'}
${'.foo:focus:hover'} | ${'.foo'}
${'li:first-child'} | ${'li'}
${'li:before'} | ${'li:before'}
${'li::before'} | ${'li::before'}
${'#app .foo'} | ${'.foo'}
${'#app'} | ${'[id=app]'}
${'#app.other'} | ${'.other'}
${'input[type="text"]'} | ${'[type="text"]'}
${'input[type="text"].foo'} | ${'.foo'}
${'.group .group\\:foo'} | ${'.group\\:foo'}
${'.group:hover .group-hover\\:foo'} | ${'.group-hover\\:foo'}
${'.owl > * + *'} | ${'.owl > *'}
${'.owl > :not([hidden]) + :not([hidden])'} | ${'.owl > *'}
${'.group:hover .group-hover\\:owl > :not([hidden]) + :not([hidden])'} | ${'.group-hover\\:owl > *'}
${'.peer:first-child ~ .peer-first\\:shadow-md'} | ${'.peer-first\\:shadow-md'}
${'.whats ~ .next > span:hover'} | ${'span'}
${'.foo .bar ~ .baz > .next > span > article:hover'} | ${'article'}
`('should generate "$after" from "$before"', ({ before, after }) => {
expect(elementSelectorParser.transformSync(before).join(', ')).toEqual(after)
})