diff --git a/.github/workflows/nodejs.yml b/.github/workflows/nodejs.yml index 5c6d04d..37aec88 100644 --- a/.github/workflows/nodejs.yml +++ b/.github/workflows/nodejs.yml @@ -7,7 +7,7 @@ jobs: runs-on: ubuntu-latest strategy: matrix: - node-version: [18.x, 20.x, 22.x] + node-version: [14.x, 16.x, 18.x] steps: - uses: actions/checkout@v3 diff --git a/package-lock.json b/package-lock.json index bf91413..58f4639 100644 --- a/package-lock.json +++ b/package-lock.json @@ -1,12 +1,12 @@ { "name": "@eyevinn/srt", - "version": "0.8.3", + "version": "0.8.2", "lockfileVersion": 2, "requires": true, "packages": { "": { "name": "@eyevinn/srt", - "version": "0.8.3", + "version": "0.8.2", "hasInstallScript": true, "license": "MIT", "dependencies": { diff --git a/package.json b/package.json index 8ee47dd..5d81fb2 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "@eyevinn/srt", - "version": "0.8.3", + "version": "0.8.2", "description": "Nodejs bindings for Secure Reliable Transport SDK", "main": "index.js", "scripts": { diff --git a/scripts/build-srt-sdk.js b/scripts/build-srt-sdk.js index 9bd557f..0475e32 100755 --- a/scripts/build-srt-sdk.js +++ b/scripts/build-srt-sdk.js @@ -13,7 +13,7 @@ const os = require('os'); const env = process.env; const SRT_REPO = env.NODE_SRT_REPO || "https://github.com/Haivision/srt.git"; -const SRT_CHECKOUT = "v1.5.4"; +const SRT_CHECKOUT = "v1.5.2"; const srtRepoPath = env.NODE_SRT_LOCAL_REPO ? `file://${path.join(__dirname, env.NODE_SRT_LOCAL_REPO)}` : SRT_REPO; const srtCheckout = env.NODE_SRT_CHECKOUT || SRT_CHECKOUT; diff --git a/src/async.js b/src/async.js index 1f56349..c2bafc2 100644 --- a/src/async.js +++ b/src/async.js @@ -25,7 +25,7 @@ class AsyncSRT extends EventEmitter { static TimeoutMs = DEFAULT_PROMISE_TIMEOUT_MS; constructor() { - super() + DEBUG && debug('Creating task-runner worker instance'); this._worker = new Worker(path.resolve(__dirname, './async-worker.js')); diff --git a/src/node-srt.cc b/src/node-srt.cc index 1dbd457..4f8dd4f 100644 --- a/src/node-srt.cc +++ b/src/node-srt.cc @@ -177,7 +177,7 @@ Napi::Value NodeSRT::Accept(const Napi::CallbackInfo& info) { Napi::Error::New(env, srt_getlasterror_str()).ThrowAsJavaScriptException(); return Napi::Number::New(env, SRT_ERROR); } - + srt_close(socketValue); socketValue = Napi::Number::New(env, SRT_INVALID_SOCK); return Napi::Number::New(env, their_fd); } diff --git a/src/srt-server.js b/src/srt-server.js index 92f5b10..3f72fa2 100644 --- a/src/srt-server.js +++ b/src/srt-server.js @@ -99,7 +99,7 @@ class SRTConnection extends EventEmitter { this.emit('closing'); const result = await asyncSrt.close(this.fd); this.emit('closed', result); - this.removeAllListeners(); + this.off(); return result; } @@ -113,14 +113,6 @@ class SRTConnection extends EventEmitter { this._gotFirstData = true; } } - - async getSocketOpt(opt) { - return await this._asyncSrt.getSockOpt(this.fd, opt); - } - - async setSocketOpt(opt, val) { - return await this._asyncSrt.setSockOpt(this.fd, opt, val); - } } /** diff --git a/types/srt-api-async.d.ts b/types/srt-api-async.d.ts index 7f000f9..40b56f9 100644 --- a/types/srt-api-async.d.ts +++ b/types/srt-api-async.d.ts @@ -1,11 +1,11 @@ -import { EventEmitter } from "events"; + import { SRTLoggingLevel, SRTResult, SRTSockOpt, SRTSockStatus } from "../src/srt-api-enums"; import { SRTReadReturn, SRTFileDescriptor, SRTEpollEvent, SRTSockOptValue, SRTStats } from "./srt-api" export type AsyncSRTCallback = (result: T) => void; -export class AsyncSRT extends EventEmitter { +export class AsyncSRT { static TimeoutMs: number; diff --git a/types/srt-server.d.ts b/types/srt-server.d.ts index 339c7ac..39996a2 100644 --- a/types/srt-server.d.ts +++ b/types/srt-server.d.ts @@ -30,9 +30,6 @@ export class SRTConnection extends EventEmitter { onData(): void; getReaderWriter(): AsyncReaderWriter; - - getSocketOpt(opt: number): Promise; - setSocketOpt(opt: number, val: number|boolean|string): Promise; } export class SRTServer extends EventEmitter /**/ {