Commit graph

21 commits

Author SHA1 Message Date
Ramesh Katuri
69f8d42a89 Fix for stack buffer underflow in sbr
Sbr frame size is not getting updated in all the sbr decoder
calling paths, because of which in one of the paths the number
of samples are passed as 0 to sbr decode call.

Inside the sbr decode call one of the buffer is accessed with
(shifted value of this number of samples - offset),
which is becoming negative in this cause. This negative offset
is causing OOB read access.

Bug:113263695
Test: poc from bug
Change-Id: I8fb5391a6ba9dd4919f8b761de295d02dda685b4
2018-09-04 10:39:04 -07:00
Ramesh Katuri
cad0d07efc Fix for segementation fault in mps_apply function
Bug: 111050781

This fix has a depedency on fix provided for Bug: 110469747

Change-Id: I928c7de376eb806e38501c4c662567e29540f118
Test: poc from bug
2018-08-23 16:00:28 -07:00
TreeHugger Robot
d191a180be Merge "Fix for segmentation fault in ixheaacd_sbr_dec_from_mps" 2018-07-13 20:31:22 +00:00
Ray Essick
a5c232f0d2 Merge changes I345fc5a4,I5495b01d,I4ca17f0c,I24b01b4a,I40f74385, ...
* changes:
  Fix for Segmentation fault in esbr co variance calcualtion
  Fix for Segmentation fault in ixheaacd_sbr_dec_from_mps
  Fix for segmentation fault in ixheaacd_dec_envelope
  Fix for sanitizer multiplication overflow error
  Fix for Segmentation fault in ixheaacd_mps_apply_pre_matrix
  Fix for ubsan add-overflow
  Fix for sub-overflow in aarch64 binary
  Fix memory leak in XAAC
2018-07-13 18:27:40 +00:00
Ray Essick
d73533ed86 Merge "Changes based on review comments" 2018-07-13 18:24:54 +00:00
Ramesh Katuri
7e90d745c2 Fix for stack corruption in esbr
Bug: 110769924
Test: poc from bug before/after
Change-Id: I99c6e89902064849ea1310c271064bdeccf7f20e
2018-07-10 16:55:00 -07:00
Ramesh Katuri
ffaed483f8 Fix for segmentation fault in ixheaacd_sbr_dec_from_mps
Bug: 110469747
Test: re-run poc
Change-Id: I576c06a1f3fa16d2818a2f2a2190ae382f38c5e3
2018-07-03 15:00:30 -07:00
Ramesh Katuri
ed94c80fe8 Fix for Segmentation fault in esbr co variance calcualtion
Bug: 110770874
Test: re-run poc
Change-Id: I345fc5a410a95e2b313c6c5b773c3a68733d6bd7
2018-07-03 14:26:48 -07:00
Ramesh Katuri
70396d6ced Fix for Segmentation fault in ixheaacd_sbr_dec_from_mps
Bug: 110629822
Test: re-run poc
Change-Id: I5495b01d5d0c779185ff04eb8f1c048f353396b2
2018-07-03 14:18:07 -07:00
Ramesh Katuri
ed84995ea7 Fix for segmentation fault in ixheaacd_dec_envelope
Bug: 110617740
Test: rerun poc
Change-Id: I4ca17f0c3e350c8020d2eecfb1519980c7cdff6f
2018-07-03 14:07:15 -07:00
Ramesh Katuri
8cacf1f5bc Fix for sanitizer multiplication overflow error
Bug: 110596152
Test: re-run POC
Change-Id: I24b01b4ab13987abd028f013262f732cd06e81f8
2018-07-03 13:57:13 -07:00
Ramesh Katuri
8ca0eedc54 Fix for Segmentation fault in ixheaacd_mps_apply_pre_matrix
Bug: 110649314
Test: run poc
Change-Id: I40f74385499064c0e982608181d98e9e577df84c
2018-07-03 13:45:37 -07:00
Ramesh Katuri
9ccb84f227 Fix for ubsan add-overflow
Bug: 110468609
Test: poc before/after
Change-Id: Ic8698c6b4eb20a1204488fc1bdd14def7fa1d171
2018-07-03 13:30:00 -07:00
Ramesh Katuri
b9c0352dce Fix for sub-overflow in aarch64 binary
Bug: 110471303
Test: poc
Change-Id: Ic9933bc5151d77358fcc3662ece04f58781c0a97
2018-07-03 12:26:44 -07:00
Ray Essick
1f49d8004a Fix memory leak in XAAC
also restructures the code so it uses a local variable rather than
allocating on the heap.

Bug: 77287124
Test: CTS DecoderTest
Change-Id: I408caf29e163068d1338c480501f03348af888a5
2018-07-03 11:21:59 -07:00
Harish Mahendrakar
dca80eae32 Changes based on review comments
Test: CTS android.media.cts.DecoderTest

Formatting changes in test folder

Bug: 80493357
Change-Id: Iaa9521521b2278b78ba789d026360a8b2eb9b54c

Changes based on the received review comments

Bug: 109679313
Change-Id: I9cd35ab4fb131f12a8970e772f464d44519496b9
2018-07-03 11:21:47 -07:00
Ramesh Katuri
b3226ce6f8 Formatting changes
Formatting .c and .h files using clang-format
Formatting .s files

Bug: 80493357
Test: compare object sizes
Change-Id: I38296083c9d2d566a6a2564db2e391e4b2bd43a9
2018-06-07 16:52:19 -07:00
Harish Mahendrakar
8eb646f89b Collected Cleanups from Ittiam
Test: CTS android.media.cts.DecoderTest{AacDrc,XheAac}

Added __ARM_NEON__ check to generic function selector

Bug: 80432407
Change-Id: I66c7879fda1369da88ccaea5f8792ea54657cdaf

Added support to build for mips

Bug: 80432286
Change-Id: I908029bbaddd3c1fbc39be1192926b56d981576e

Add optimized versions for qmf_dec for armv7 and armv8

Separating common functions and platform specific functions
in ixheaacd_qmf_dec.c. Platform specific functions are moved
to qmf_dec in armv7, armv8 and generic folder.

Bug: 80431870
Change-Id: I860cb79a1870e228d2108b7915418e1c003cefc5

Fixes for crashes reported by Fuzzer tool

Bug: 109697676
Change-Id: I862fc054b99ee9d427d20596bc8d2e85522a7188
2018-06-05 13:04:22 -07:00
Ramesh Katuri
36ef96da45 Fix to resolve CTS test case testDecodeUsacDrcEffectTypeM4a
Bug: 80133175
Test: CTS android.metia.cts.DecoderTestXheAac
Change-Id: Ic1962238eabe4ad98e4fa0ea85acc5494e762d30
2018-06-01 09:56:14 -07:00
Ray Essick
4908247643 Sanitization fixes from new CTS tests
Updates from vendor to remedy issues exposed by new CTS tests

Bug: 77287124
Test: CTS DecoderTest, DecoderTest{AacDrc,XheAac}

@ Sanitizer fixes in libxaac

Fixes few integer overflow sanitizer errors
Progagate few errors
ENABLE_DRC macro is removed
AMMENDMENT1 macro is removed

Change-Id: Ic61163dfd6318bd4a00ed45e1295c819cb0f637b

@ Add support for audio pre-roll and DRC effect type

Also includes the following
MPEG-D DRC parameters related changes
USAC config switch changes
SBR config switch changes

Bug: 80133175
Change-Id: I0ab25641768cf523b66f7b0fcb4137429c1c4a77

@ Fixed trailing spaces

Change-Id: I32de0c9d3f7237e1fbf8dfef1cac485ef8458173

@ Replaced tabs

Change-Id: Ic741ee13d7b978b37edc27d087903caaa40b8d90
2018-05-25 11:35:52 -07:00
Ray Essick
51aa06e124 Bring xHE-AAC into pi-dev branch
bring the multi-commit integration from master to pi-dev

libxaac multi-arch cleanup

Change-Id: Ibcefa14f439e75f48a54955c9abf1a06c418e41e
Change-Id: Ia7a9b1e4de0add847c136f6f545b81dc8087521d
Change-Id: I12c3f8414dc9971017de223e88f292f8982a5c9b

Fix dependency error in Android.bp
Change-Id: Ic54f688736b3f2a70172676e4cee22aea4cbd705

Localized Android.bp
Change-Id: I68c4fc24fca279104c8ce2129fd4a3ed8d116b9b

Import xHE-AAC decoder from Ittiam
Change-Id: I3c8d124033f967b29d6e384cce5c843ee17a7bb1

Bug: 77287124
Test: build, cts DecoderTest
2018-05-17 14:36:48 -07:00