Commit graph

53 commits

Author SHA1 Message Date
Ray Essick
e79457567e Merge "Fix for OOB write in loudness info set ext" into pi-dev am: 69e7a92ab9
am: 2dd49bc124

Change-Id: I04e80eafebc7241034af28dc615e385c473a0c4b
2018-10-30 15:24:28 -07:00
Ray Essick
6391584b4a Merge "Fix for OOB write in parsing eq sub band gain vector in drc" into pi-dev am: 86a4367f4c
am: 2b463e4b0a

Change-Id: Id6d1b6f8d44baf643927dd8dba8157566d74a8e6
2018-10-30 15:24:13 -07:00
Ramesh Katuri
85589b0353 Fix for stack buffer overflow in drc loudness control am: 851d0d122a
am: 8a2678ef55

Change-Id: Ic73f4ee2630999d39c270afeda1111370612b928
2018-10-30 15:23:36 -07:00
Ray Essick
69e7a92ab9 Merge "Fix for OOB write in loudness info set ext" into pi-dev 2018-10-30 21:54:50 +00:00
Ray Essick
86a4367f4c Merge "Fix for OOB write in parsing eq sub band gain vector in drc" into pi-dev 2018-10-30 21:51:39 +00:00
Ramesh Katuri
6bd9129c03 Fix for OOB write in parsing eq sub band gain vector in drc
bounds checking on subband information.

Bug:115908308
Test: vendor
Change-Id: I8cb2684c7f02b287065ef8b0b1a11c7dcf88e6d1
2018-10-29 16:17:55 -07:00
Ramesh Katuri
851d0d122a Fix for stack buffer overflow in drc loudness control
Bug:114749542
Test: vendor
Change-Id: I3b394faf8e6659724ee361fb94ec7d89f60eaf5e
2018-10-29 15:47:53 -07:00
Ray Essick
dbcbdb48e3 Merge "Fix for stack over flow write in drc set pre selection" into pi-dev am: 3ddab42b81
am: e9f01642ae

Change-Id: I290beae7f39906fbab952640efe6d7b48c0a7060
2018-10-29 15:22:18 -07:00
Ray Essick
3ddab42b81 Merge "Fix for stack over flow write in drc set pre selection" into pi-dev 2018-10-29 22:08:57 +00:00
Ray Essick
8c4d76093e Merge "Fix for stack overflow in impd parse equalizer coefficients" into pi-dev am: e99fa1316d
am: a4076520bc

Change-Id: I2994b12f333055c8ddddd9147e36f9c91ac6184a
2018-10-29 14:47:54 -07:00
Ray Essick
1fe53b9203 Merge "Fix for OOB in parse drc config extension" into pi-dev am: 402fce8468
am: 19b90a410d

Change-Id: I58be68b51be085ea38a994094e653fa1c0943c72
2018-10-29 14:39:00 -07:00
Ray Essick
e99fa1316d Merge "Fix for stack overflow in impd parse equalizer coefficients" into pi-dev 2018-10-29 21:28:05 +00:00
Ray Essick
402fce8468 Merge "Fix for OOB in parse drc config extension" into pi-dev 2018-10-29 21:19:30 +00:00
Ramesh Katuri
d3c1212562 Merge "Fix for stack overflow in eq selection in drc module" into pi-dev am: 09cc55d5fa
am: 226f011619

Change-Id: Iccb00e370ec58bafe5d5d162e318b15b31786bb8
2018-10-29 13:58:20 -07:00
TreeHugger Robot
09cc55d5fa Merge "Fix for stack overflow in eq selection in drc module" into pi-dev 2018-10-29 20:43:22 +00:00
Ramesh Katuri
5f8f916bfa Fix for OOB in parsing loud equalizer instruction in drc am: 7e8303bbaa
am: ba8cab6f2d

Change-Id: I77408c0bd6d0d493346c580b05d04642afdf5060
2018-10-29 11:50:37 -07:00
Ramesh Katuri
8e1635aaea Fix for OOB in parse drc config extension
Bug:117100617
Test: vendor
Change-Id: I0e6bcbdfb21f40b9687b2d36366112bc67cee88a
2018-10-27 13:32:43 -07:00
Ramesh Katuri
7e8303bbaa Fix for OOB in parsing loud equalizer instruction in drc
Bug:116117112
Test: vendor
Change-Id: I9d69d07dc36e8874d1784b4cf1f1a0a4fc99cee7
2018-10-27 13:23:13 -07:00
Ramesh Katuri
06296604c8 Fix for OOB write in loudness info set ext
Bug:117099943
Bug: 117100484
Test: Vendor
Change-Id: Id657372bde3b0218108c3d8aa7f9f898cde5b583
2018-10-27 10:38:12 -07:00
Ramesh Katuri
c14b25793c Fix for stack overflow in impd parse equalizer coefficients
Bug:115907334
Test: vendor
Change-Id: I031ba8064d24bec2db3ea68beea713387ea19762
2018-10-27 10:01:23 -07:00
Ramesh Katuri
0c81453dd3 Fix for stack over flow write in drc set pre selection
Bug:114745929
Test: vendor
Change-Id: I3bbb434d61ce1784db60c47fe7154a9931f97820
2018-10-27 09:51:20 -07:00
Ramesh Katuri
c26e43d759 Fix for stack overflow in eq selection in drc module
Bug:114735603
Test: vendor
Change-Id: I83be3dfe1111caa1acd244b0a9ba2a8944c92981
2018-10-27 09:31:58 -07:00
Ramesh Katuri
ed631b4da6 Merge "Fix for OOB write in parsing drc ext" into pi-dev am: 3eaf99dd1d
am: 5f5b0e05a9

Change-Id: Ibc56c5d74393565d28a93fbec240cb0aa15e0d5c
2018-10-08 13:20:55 -07:00
TreeHugger Robot
3eaf99dd1d Merge "Fix for OOB write in parsing drc ext" into pi-dev 2018-10-08 19:59:34 +00:00
TreeHugger Robot
ddd686f4fd Merge "Fix for NPD in manage drc complexity" 2018-10-06 00:15:21 +00:00
Ramesh Katuri
f544a9813a Fix for crash due to un-initailized variables in drc module am: 988f5bd17c
am: fb716d4167

Change-Id: I42dadd51af6155e592ea655e126175263e9b1115
2018-10-05 11:48:25 -07:00
Ramesh Katuri
7fce5ed13c Fix for NPD in manage drc complexity
check pointer returned from impd_select_drc_coeff3() before using it.

Bug: 114749884
Test: vendor
Change-Id: I682c107dee5ae5cddfdb7413854ad3065421fa4a
2018-10-05 10:04:50 -07:00
Ramesh Katuri
988f5bd17c Fix for crash due to un-initailized variables in drc module
Nested loop used wrong subscript in inner loop, leading to bad
iteration count and haphazard clearing of data structure.

Bug: 113885537
Test: vendor
Change-Id: Ia9cb53205f4e91ee99268202114fc2001eae2de3
2018-10-04 10:59:52 -07:00
Ramesh Katuri
b3c5bcb7bd Merge "Fix for heap buffer over flow in drc bit stream parsing" into pi-dev am: 8630b598a9
am: f635721bc0

Change-Id: Id70277c8ae7e1e558a1a1627a3491e3bc1633442
2018-10-02 20:29:02 -07:00
Ramesh Katuri
52128bb031 Merge "Fix for OOB loudness eq instruction parsing" into pi-dev am: c7c160e98c
am: f3efd5a31b

Change-Id: Ie9a1b0fec5a3e8dffd4de03f1faf99c3157998b1
2018-10-02 20:28:43 -07:00
Ramesh Katuri
a48d66302a Merge "Fix for OOB write in filter block parsing in drc" into pi-dev am: 84b3433dbd
am: cb41b4fd48

Change-Id: Ibf2ba4586af7f898115f78da43e7e3477d5839df
2018-10-02 20:22:29 -07:00
Ramesh Katuri
4f33cab59b Merge "Fix for OOB write in parametric drc instruction parsing" into pi-dev am: a97968adcd
am: ecb0d6f203

Change-Id: Ia7b4153889b2eb9139606f09b544450e30e82d49
2018-10-02 20:21:33 -07:00
Ramesh Katuri
a4b8a3ae6c Merge "Fix of OOB write in drc downmix instruction count parsing" into pi-dev am: cbc35bf28a
am: 31442931bf

Change-Id: I017e5332a0bc7a6216e48115781b851e1cdfb8f9
2018-10-02 20:12:22 -07:00
Ramesh Katuri
800e33dda4 Fix for OOB write in split drc characteristic parsing am: 599ca4428a
am: dd526f9763

Change-Id: I77e5ad8281039621d63f135d418d0db804f86d38
2018-10-02 20:05:03 -07:00
TreeHugger Robot
8630b598a9 Merge "Fix for heap buffer over flow in drc bit stream parsing" into pi-dev 2018-10-03 00:47:21 +00:00
TreeHugger Robot
c7c160e98c Merge "Fix for OOB loudness eq instruction parsing" into pi-dev 2018-10-03 00:38:36 +00:00
TreeHugger Robot
84b3433dbd Merge "Fix for OOB write in filter block parsing in drc" into pi-dev 2018-10-03 00:31:00 +00:00
Ramesh Katuri
17825d4a75 Fix for OOB write in parsing drc ext
Validate drc coefficient counts as we parse them from the stream.

Bug: 116224432
Test: vendor
Change-Id: I5a78521b8acfcdc7af96b91e5687d4f02ce49e54
2018-10-02 17:00:13 -07:00
TreeHugger Robot
a97968adcd Merge "Fix for OOB write in parametric drc instruction parsing" into pi-dev 2018-10-02 23:17:33 +00:00
TreeHugger Robot
cbc35bf28a Merge "Fix of OOB write in drc downmix instruction count parsing" into pi-dev 2018-10-02 23:16:51 +00:00
Ramesh Katuri
c90eeb6e61 Fix for heap buffer over flow in drc bit stream parsing
Bound values that we parse from the input stream.

Bug: 115375616
Test: vendor
Change-Id: I357d8e19e377fbe5156e5a639ed9ab99cbfeed52
2018-10-02 15:56:02 -07:00
Ramesh Katuri
69a69acbc9 Fix for OOB write in filter block parsing in drc
Bug: 116467350
Bug: 116469592
Test: vendor
Change-Id: I2f7bff1cec3d0d60e9d43217290392bf4e23d207
2018-10-02 15:51:13 -07:00
Ramesh Katuri
cd74db5553 Fix for OOB loudness eq instruction parsing
Bounds checking on value parsed from input stream.

Bug: 116020594
Test: vendor
Change-Id: I915f36ca27b982c8f1b11a533969e40fbff3b765
2018-10-02 15:29:07 -07:00
Ramesh Katuri
599ca4428a Fix for OOB write in split drc characteristic parsing
added bounds check on values parsed from input stream.

Bug: 116619337
Test: vendor
Change-Id: Ia938ce45cb0503c1ddcbeaa5d036c0f57521a38f
2018-10-02 13:18:16 -07:00
Ramesh Katuri
df1030d8b9 Fix of OOB write in drc downmix instruction count parsing
Check bounds of parsed value.

Bug: 116619387
Test: vendor
Change-Id: Iada4937f7d99744594a1d457ae1bddefe961ba4f
2018-10-02 11:21:44 -07:00
Ramesh Katuri
d735e2e329 Fix for OOB write in parametric drc instruction parsing
Bug: 116715245
Test: vendor
Change-Id: I24c7ce7cd8c928d53a9914d116de4c6b408cfb09
2018-10-02 10:08:37 -07:00
Ramesh Katuri
f0ec571e6c Fix for OOB write in gain set param's parsing am: 90b76d9431
am: 5d2f71e575

Change-Id: I4020eef00283f57d973ffc512d9541b2dcae46f5
2018-10-01 13:28:54 -07:00
Ramesh Katuri
90b76d9431 Fix for OOB write in gain set param's parsing
Check extracted size against array sizing before proceeding.

Bug: 116715937
Test: poc
Change-Id: Ic26b85683342fa5f508b66f4ad71badb06540f17
2018-09-30 19:54:50 -07:00
Harish Mahendrakar
dca80eae32 Changes based on review comments
Test: CTS android.media.cts.DecoderTest

Formatting changes in test folder

Bug: 80493357
Change-Id: Iaa9521521b2278b78ba789d026360a8b2eb9b54c

Changes based on the received review comments

Bug: 109679313
Change-Id: I9cd35ab4fb131f12a8970e772f464d44519496b9
2018-07-03 11:21:47 -07:00
Ramesh Katuri
b3226ce6f8 Formatting changes
Formatting .c and .h files using clang-format
Formatting .s files

Bug: 80493357
Test: compare object sizes
Change-Id: I38296083c9d2d566a6a2564db2e391e4b2bd43a9
2018-06-07 16:52:19 -07:00