wrapper/libxaac
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix for integer overflow in ixheaacd_cal_fac_data

Browse source 
Negation overflow occurs in ixheaacd_cal_fac_data.

As fix, added saturation check in absolute value
calculation.

Bug:120250030
Test: vendor
Change-Id: Ie310d9d21fc12fc76135fa7b411572d3673fe871
This commit is contained in:
Tripti Tiwari 2018-12-10 14:45:55 +05:30 • committed by Ray Essick
parent 4d7d9daad6
commit f86897eaad
1 changed files with 2 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

3
decoder/ixheaacd_imdct.c
View file

@ -254,7 +254,8 @@ WORD8 ixheaacd_cal_fac_data(ia_usac_data_struct *usac_data, WORD32 i_ch,
i_aq = NULL;
for (k = 0; k < lfac; k++) {
if (ABS(fac_data[k + 1]) > itemp) itemp = ABS(fac_data[k + 1]);
if (ixheaacd_abs32_sat(fac_data[k + 1]) > itemp)
itemp = ixheaacd_abs32_sat(fac_data[k + 1]);
}
qshift1 = ixheaacd_norm32(itemp);