Commit graph

18 commits

Author SHA1 Message Date
Harish Mahendrakar
facc3c62f3 xaacdec: Add host support am: f6ce5d9483 am: b31bec889e am: 2d6690e9d6
am: f063ce82e1

Change-Id: I94195a6d8f2919e68d2ae00d8545fbae5360e9a0
2019-09-11 09:47:03 -07:00
Harish Mahendrakar
f6ce5d9483 xaacdec: Add host support
Test: Build xaacdec on host
Bug: 139379050
Change-Id: I2cfb401b71240dd0966b80cc208e9a9798c8a51e
2019-09-05 11:27:29 -07:00
Ramesh Katuri
ce7b4e93ce Fix for correcting #include delimiters
This CL contains changes to make #include delimiters stying
consistent. For all system files inclusion we will use <> and
all user files we will use ""

Bug: 125443111
Test: compilation
Change-Id: Ie5f609b9bef8357877affb7f48d46df7c387d142
2019-08-26 13:35:44 -07:00
Rajat Kumar
61cdf5e6b5 Fix for global buffer overflow in error handler function
Added error handling for few unhandled error
returned from library to ixheaacd_error.c file.

Bug:133133640
Test: poc in bug

Change-Id: I584da0278ebcb04fc48538b5ae55e8ab2e65c684
2019-07-23 14:59:21 -07:00
Rajat Kumar
f6b2d77787 Fixes to incorporate latest conformance criteria
Bug:128648229
Test: atest android.media.cts.DecoderTestXheAac
Test: atest android.media.cts.DecoderTestAacDrc
Change-Id: Ic85bacc660c91096e29cd0cbe24323f4a6109c9a
2019-07-03 10:23:20 -07:00
Ray Essick
ff1452f96f Merge "Fix for out of bound write in xaacdec test bench" 2019-04-03 22:51:57 +00:00
TreeHugger Robot
c99fe20ffc Merge "Fix for testbench crash due to invalid file handle" 2019-04-03 00:36:27 +00:00
Ray Essick
360bd4fd75 Merge changes from topic "b124323156"
* changes:
  Initialize all allocated memory blocks to zero
  Update cfi blacklist to include few more assembly functions
  LDR changed to MOV instruction in armv8 and armv7 assemblies
2019-04-02 22:13:05 +00:00
Rajat Kumar
ce6d37faa2 Fix for testbench crash due to invalid file handle
Added checks to handle cases when input, output or
meta files are not passed in arguments of xaacdec.
Removed process command mode support and related
code from testbench.
Removed interface file read support and moved the
condition for drc to be on, if effect type or target
loudness is present in the command line arguments.

Bug:124627497
Test: poc
Change-Id: I97e216f5bc6ba6c52dcdc6438ee4152f0cb1682c
2019-03-30 17:08:55 -07:00
Rajat Kumar
7b43401d30 Initialize all allocated memory blocks to zero
Bug: 124323156
Test: poc
Change-Id: I69b035d1b6bab81244dde319d4fceb3f42837380
2019-03-27 15:49:39 -07:00
Rajat Kumar
18eeb62fd1 Fix for memory leak in meta read file.
meta_info->ia_mp4_stsz_size once allocated, was never freed,
hence giving memory leaks.
As a fix, added free when decoder de-initializes and when
this memory is reallocated.

Bug:124831933
Test: vendor
Change-Id: Ie9465496fca15501bc7dffc29a4f6eccf3880e6d
2019-03-27 15:37:32 -07:00
Rajat Kumar
7f66587c3b Fix for out of bound write in xaacdec test bench
Check has been added to avoid reading more than input buffer's size.

Bug:123907312
Test: vendor+poc
Change-Id: I53438028e920271d6966ba95dc4ed110c8ba8a10
2019-02-22 18:59:23 -08:00
Ramesh Katuri
fe1d70bf7e Cleanup memory allocation for DRC buffers
This fixes un intialized data access in loudness equalizer selection
Memory allocation and distribution inside DRC module was cleaned up.
Memory clean-up changes were done inside the library and in test bench.
Similar changes were done in OMX and C2 plug-in as well.

Bug: 115509210
Test: vendor+poc
Change-Id: I6a2bf5fe6eeecc5d0fec395af020aef8221a5f93
2019-02-04 12:12:13 -08:00
Ramesh Katuri
5148d0d287 Fix for heap buffer overflow in xaac decoder test bench
In Xaac decoder frame size information is obtained from  ia_mp4_stsz_size array
using frame counter. Due to some bad frames in the stream frame counter is not
getting updated properly which is causing heap buffer overflow.

As a fix

1. We added check on frame counter value before accessing  ia_mp4_stsz_size[]
2. Frame counter value is updated properly even if input frame is an erroneous
   frame

Bug:119005793
Test: vendor, poc
Change-Id: I402cf9b4d5641545fdaaf433f0a4a43c293e5dd9
2019-01-04 12:20:07 -08:00
Ramesh Katuri
9ccb84f227 Fix for ubsan add-overflow
Bug: 110468609
Test: poc before/after
Change-Id: Ic8698c6b4eb20a1204488fc1bdd14def7fa1d171
2018-07-03 13:30:00 -07:00
Harish Mahendrakar
dca80eae32 Changes based on review comments
Test: CTS android.media.cts.DecoderTest

Formatting changes in test folder

Bug: 80493357
Change-Id: Iaa9521521b2278b78ba789d026360a8b2eb9b54c

Changes based on the received review comments

Bug: 109679313
Change-Id: I9cd35ab4fb131f12a8970e772f464d44519496b9
2018-07-03 11:21:47 -07:00
Ray Essick
4908247643 Sanitization fixes from new CTS tests
Updates from vendor to remedy issues exposed by new CTS tests

Bug: 77287124
Test: CTS DecoderTest, DecoderTest{AacDrc,XheAac}

@ Sanitizer fixes in libxaac

Fixes few integer overflow sanitizer errors
Progagate few errors
ENABLE_DRC macro is removed
AMMENDMENT1 macro is removed

Change-Id: Ic61163dfd6318bd4a00ed45e1295c819cb0f637b

@ Add support for audio pre-roll and DRC effect type

Also includes the following
MPEG-D DRC parameters related changes
USAC config switch changes
SBR config switch changes

Bug: 80133175
Change-Id: I0ab25641768cf523b66f7b0fcb4137429c1c4a77

@ Fixed trailing spaces

Change-Id: I32de0c9d3f7237e1fbf8dfef1cac485ef8458173

@ Replaced tabs

Change-Id: Ic741ee13d7b978b37edc27d087903caaa40b8d90
2018-05-25 11:35:52 -07:00
Ray Essick
51aa06e124 Bring xHE-AAC into pi-dev branch
bring the multi-commit integration from master to pi-dev

libxaac multi-arch cleanup

Change-Id: Ibcefa14f439e75f48a54955c9abf1a06c418e41e
Change-Id: Ia7a9b1e4de0add847c136f6f545b81dc8087521d
Change-Id: I12c3f8414dc9971017de223e88f292f8982a5c9b

Fix dependency error in Android.bp
Change-Id: Ic54f688736b3f2a70172676e4cee22aea4cbd705

Localized Android.bp
Change-Id: I68c4fc24fca279104c8ce2129fd4a3ed8d116b9b

Import xHE-AAC decoder from Ittiam
Change-Id: I3c8d124033f967b29d6e384cce5c843ee17a7bb1

Bug: 77287124
Test: build, cts DecoderTest
2018-05-17 14:36:48 -07:00