mirror of
https://github.com/ittiam-systems/libhevc.git
synced 2026-10-02 08:42:42 +07:00
0aa9a2566f
When transquant bypass is enabled in HBD streams, decoded frames mismatched the reference output due to two issues: 1. Intra boundary filtering: In the 8-bit path, boundary filtering for horizontal (mode 10) and vertical (mode 26) intra predictions is disabled when transquant bypass is active with implicit RDPCM. However, the HBD reconstruction path was passing raw u1_luma_pred_mode instead of disable_boundary_filter, and the HBD filter functions ignored the mode parameter. 2. SAO Scratch Buffer Overflow: During shifted CTB SAO processing, transquant bypass blocks are temporarily backed up into pu1_tmp_buf_luma and restored afterwards to keep them lossless. In HBD, each sample requires 2 bytes (UWORD16), but the static scratch buffer was allocated for 8-bit samples (sizeof(UWORD8)). Because the shifted CTB processing window spans beyond standard CTB boundaries to handle delayed neighbor boundaries, the 16-bit luma backup exceeded the allocated buffer capacity and overflowed into pu1_tmp_buf_chroma. Consequently, chroma backup overwrote the luma backup data, resulting in corrupted samples upon restoration. This commit resolves the above issues with the following changes: - common/ihevc_hbd_intra_pred_filters.c: Check 'disable_boundary_filter' to bypass boundary filtering in ihevc_hbd_intra_pred_luma_horz and ihevc_hbd_intra_pred_luma_ver. - decoder/ihevcd_iquant_itrans_recon_ctb.c: Pass disable_boundary_filter to apf_hbd_intra_pred_luma for modes 10 and 26. - decoder/ihevcd_api.c: Scale SAO temporary scratch buffer allocation (pu1_tmp_buf_luma and pu1_tmp_buf_chroma) by sizeof(UWORD16) to prevent buffer collision in HBD mode. |
||
|---|---|---|
| .. | ||
| arm | ||
| arm64 | ||
| riscv64 | ||
| x86 | ||
| ihevcd_api.c | ||
| ihevcd_bitstream.c | ||
| ihevcd_bitstream.h | ||
| ihevcd_boundary_strength.c | ||
| ihevcd_boundary_strength.h | ||
| ihevcd_cabac.c | ||
| ihevcd_cabac.h | ||
| ihevcd_common_tables.c | ||
| ihevcd_common_tables.h | ||
| ihevcd_cxa.h | ||
| ihevcd_deblk.c | ||
| ihevcd_deblk.h | ||
| ihevcd_debug.h | ||
| ihevcd_decode.c | ||
| ihevcd_decode.h | ||
| ihevcd_defs.h | ||
| ihevcd_error.h | ||
| ihevcd_fmt_conv.c | ||
| ihevcd_fmt_conv.h | ||
| ihevcd_func_types.h | ||
| ihevcd_function_selector.h | ||
| ihevcd_function_selector_generic.c | ||
| ihevcd_get_mv.c | ||
| ihevcd_get_mv.h | ||
| ihevcd_ilf_padding.h | ||
| ihevcd_inter_pred.c | ||
| ihevcd_inter_pred.h | ||
| ihevcd_intra_pred_mode_prediction.c | ||
| ihevcd_intra_pred_mode_prediction.h | ||
| ihevcd_iquant_itrans_recon_ctb.c | ||
| ihevcd_iquant_itrans_recon_ctb.h | ||
| ihevcd_itrans_recon_dc.c | ||
| ihevcd_itrans_recon_dc.h | ||
| ihevcd_ittiam_logo.h | ||
| ihevcd_job_queue.c | ||
| ihevcd_job_queue.h | ||
| ihevcd_mv_merge.c | ||
| ihevcd_mv_merge.h | ||
| ihevcd_mv_pred.c | ||
| ihevcd_mv_pred.h | ||
| ihevcd_nal.c | ||
| ihevcd_nal.h | ||
| ihevcd_parse_headers.c | ||
| ihevcd_parse_headers.h | ||
| ihevcd_parse_residual.c | ||
| ihevcd_parse_residual.h | ||
| ihevcd_parse_slice.c | ||
| ihevcd_parse_slice.h | ||
| ihevcd_parse_slice_header.c | ||
| ihevcd_parse_slice_header.h | ||
| ihevcd_process_slice.c | ||
| ihevcd_process_slice.h | ||
| ihevcd_profile.h | ||
| ihevcd_ref_list.c | ||
| ihevcd_ref_list.h | ||
| ihevcd_sao.c | ||
| ihevcd_sao.h | ||
| ihevcd_statistics.h | ||
| ihevcd_structs.h | ||
| ihevcd_trace.h | ||
| ihevcd_utils.c | ||
| ihevcd_utils.h | ||
| ihevcd_version.c | ||
| libhevcdec.cmake | ||