Naveen Kumar P
ad70f9c5e2
Merge "Fix slice address zero for not first slice in pic" into lmp-dev
...
am: 114aff802c
2017-11-03 19:05:33 +00:00
Wei Jia
7ec4d76835
Merge "Fix prev slice incomplete check" into lmp-dev
...
am: 94c2e4ad73
2017-11-03 19:03:34 +00:00
TreeHugger Robot
114aff802c
Merge "Fix slice address zero for not first slice in pic" into lmp-dev
2017-11-03 19:01:28 +00:00
Wei Jia
94c2e4ad73
Merge "Fix prev slice incomplete check" into lmp-dev
2017-11-03 18:59:15 +00:00
Naveen Kumar P
9fb45f7a68
Fix incomplete frame error
...
am: ee0e003a0f
2017-11-03 18:52:32 +00:00
Naveen Kumar P
ee0e003a0f
Fix incomplete frame error
...
Bug: 63522067
Bug: 64380403
Test: ran POC before/after
Change-Id: If22f2ed8936e0ead9fcfa64ddde99e85c10cecd2
2017-11-01 12:42:30 -07:00
Naveen Kumar P
ed3f6bb877
Fix slice address zero for not first slice in pic
...
The parameter slice address is parsed only slices that are not
first slice in the pic and the value cannot be zero.
Bug: 64380202
Test: ran PoC on master
Change-Id: Ic21c40cf67c916806113d2425790a27cb658b5d2
2017-10-31 14:57:18 -07:00
Naveen Kumar P
9c24714e25
Fix prev slice incomplete check
...
Bug: 64552185
Bug: 65034175
Move the decision to signal missing ctbs as skipped ctbs of
previous slice to the end of current slice hdr parsing to
ensure no error in slice hdr parsing.
Change-Id: Ia33b4be31dad6225b04e7b20b9000059c87941c4
(cherry picked from commit 74f35f191022c06863dacd33a3651a33be3ef08d)
2017-10-30 15:40:08 -07:00
Naveen Kumar P
27e8401a7c
Merge "Set error skip ctbs as multiple 8x8 pus" into lmp-dev
...
am: 6587d735fa
2017-10-20 19:52:10 +00:00
TreeHugger Robot
6587d735fa
Merge "Set error skip ctbs as multiple 8x8 pus" into lmp-dev
2017-10-20 19:44:51 +00:00
Ray Essick
512ea0e115
Alloc extra bytes for bits buf for parse optimzation
...
am: 2ae456c2a3
2017-10-10 02:58:15 +00:00
Naveen Kumar P
2b9fb0c207
Set error skip ctbs as multiple 8x8 pus
...
Bug: 65123471
This is required for incomplete ctbs at the frame
boundaries
Change-Id: I7e41a3ac2f6e35a929ba4ff3ca4cfcc859a7b867
2017-10-05 13:56:13 -07:00
Ray Essick
2ae456c2a3
Alloc extra bytes for bits buf for parse optimzation
...
Without this extra allocation, if a nal fills entire bits
buffer, there will be out of bound memory read access.
Bug: 65719872
Test: ran poc before/after on ASAN of master
Change-Id: I9f4fca0739db84db023b1252c1365bfd13355541
Merged-In: I1c36821505bdc4fe6c23f30a02ab2fb0fb657946
2017-10-03 16:04:33 -07:00
Robert Shih
b49adbf304
Merge "Added an out of bound check on u4_num_bufs in input argument" into lmp-dev
...
am: 4b5c23e393
2017-09-13 20:36:55 +00:00
Robert Shih
4b5c23e393
Merge "Added an out of bound check on u4_num_bufs in input argument" into lmp-dev
2017-09-13 20:15:11 +00:00
Marco Nelissen
b1d1fad9f6
Merge "Fix tile index buf alloc size" into lmp-dev
...
am: 4b9053c15c
2017-09-13 05:51:33 +00:00
Marco Nelissen
4b9053c15c
Merge "Fix tile index buf alloc size" into lmp-dev
2017-09-13 05:00:56 +00:00
Harish Mahendrakar
8221313d58
Added an out of bound check on u4_num_bufs in input argument
...
ps_dec_ip->s_out_buffer.u4_num_bufs was missing out of bound checks
Bug: 35430570
Change-Id: Ibbf9891a885f69e208107725e34e7217147b891e
2017-09-12 13:13:26 -07:00
Naveen Kumar P
578f676115
Fix heap buffer overflow
...
am: f6ba5eae65
2017-09-11 23:50:27 +00:00
Naveen Kumar P
334f896e61
Fix tile index buf alloc size
...
Bug: 64893226
2017-09-11 15:40:03 -07:00
Naveen Kumar P
f6ba5eae65
Fix heap buffer overflow
...
Test:
- Push multi_rec.hevc (in the bug thread) to the device
- Build:
mmm external/libhevc
- Run on device:
hevcdec --input multi_res.hevc --num_frames -1 --num_cores 2
Bug: 62815506
Merged-In: I7e0828c9a9bb1e9997c379544ea5f4eb3556417d
Change-Id: I7e0828c9a9bb1e9997c379544ea5f4eb3556417d
2017-09-08 21:14:34 -07:00
Harish Mahendrakar
419fd4b745
Merge "Ensure CTB size > 16 for clips with tiles and width/height >= 4096" into lmp-dev
...
am: db15dd7102
2017-08-03 18:40:37 +00:00
TreeHugger Robot
db15dd7102
Merge "Ensure CTB size > 16 for clips with tiles and width/height >= 4096" into lmp-dev
2017-08-03 18:28:53 +00:00
Harish Mahendrakar
248e72c7a8
Ensure CTB size > 16 for clips with tiles and width/height >= 4096
...
For clips with tiles and dimensions >= 4096,
CTB size of 16 can result in tile position > 255.
This is not supported by the decoder
Bug: 37930177
Test: ran poc w/o crashing
Change-Id: I2f223a124c4ea9bfd98343343fd010d80a5dd8bd
2017-07-24 12:33:29 -07:00
Harish Mahendrakar
34ec365ad3
Merge "Limit boundary PU sizes in case of errors" into lmp-dev
...
am: f661b00835
2017-07-10 19:38:57 +00:00
TreeHugger Robot
f661b00835
Merge "Limit boundary PU sizes in case of errors" into lmp-dev
2017-07-10 19:29:45 +00:00
Naveen Kumar P
41d5957422
Merge "Check number of output buffers and sizes" into lmp-dev
...
am: 493410548a
2017-06-16 23:32:02 +00:00
TreeHugger Robot
493410548a
Merge "Check number of output buffers and sizes" into lmp-dev
2017-06-16 23:26:32 +00:00
Naveen Kumar P
870c70383d
Return error for invalid crop parameters
...
am: e8c26c16d7
2017-06-16 18:28:38 +00:00
Naveen Kumar P
e8c26c16d7
Return error for invalid crop parameters
...
Test: run poc with and without the patch
Bug: 62214264
Change-Id: If627ee9a8f0dbd65963897966e1c2d39f5fbd428
2017-06-15 20:19:16 +00:00
Harish Mahendrakar
62830d130b
Limit boundary PU sizes in case of errors
...
In case of error clips, some PUs are marked as skip.
Ensure such PUs stay within the picture
Bug: 37615911
Test: ran POC included with the bug.
Change-Id: Ie0aeccc752cf556f9dea84de61c15a7906e1060b
2017-06-13 14:54:58 -07:00
Naveen Kumar P
1ffb19f7ae
Check number of output buffers and sizes
...
Bug: 37435531
Bug: 36817631
Bug: 36492741
Change-Id: I85e3da9a8aaefaac0b494868fdc94d858e4cf8e6
2017-06-07 15:28:48 -07:00
Naveen Kumar P
c1451ed95b
Merge "Fix OOB issue in nal unit parsing" into lmp-dev
...
am: 1ce65aea9f
2017-06-06 20:50:48 +00:00
TreeHugger Robot
1ce65aea9f
Merge "Fix OOB issue in nal unit parsing" into lmp-dev
2017-06-06 20:42:09 +00:00
Marco Nelissen
e30fa58cf0
Merge "DO NOT MERGE Added check for invalid log2_max_transform_block_size in SPS" into lmp-dev
2017-06-06 20:10:10 +00:00
Naveen Kumar P
18a176494f
Merge "Set pic_present at end of pic_init instead of beginning" into lmp-dev
...
am: 95cd002d79
2017-06-06 19:33:37 +00:00
TreeHugger Robot
95cd002d79
Merge "Set pic_present at end of pic_init instead of beginning" into lmp-dev
2017-06-06 19:22:09 +00:00
Harish Mahendrakar
d272cd6369
DO NOT MERGE Added check for invalid log2_max_transform_block_size in SPS
...
Bug: 33918236
Bug: 33964497
Bug: 33965905
Bug: 33862021
Change-Id: If121221d0f6e983c05d95d123af9bed378d1961f
2017-06-05 14:36:00 -07:00
Naveen Kumar P
62ebc32761
Fix OOB issue in nal unit parsing
...
Bug: 37712181
Test: ran patched against POC on nyc-mr2
Change-Id: I5408b3afd898db99265f94573d1163ef83c9b99c
2017-06-02 15:20:48 -07:00
Naveen Kumar P
c83ae25b05
Handle error return in parse slice
...
am: 4535874899
2017-06-01 21:04:23 +00:00
Naveen Kumar P
4535874899
Handle error return in parse slice
...
Bug: 37430213
Change-Id: I77f5973db54edccc0972649035b0fbde961c10dd
(cherry picked from commit 16c8c8cceeb74c7f4634803723a0b8b1f4881dc9)
2017-05-30 09:38:36 -07:00
Naveen Kumar P
d012a1ffc0
Set pic_present at end of pic_init instead of beginning
...
Bug: 37469795
In pic_init, pic_present was set in the beggining. If pic_present
was set, process and buffer managment were done. For an error
stream, a crash occured when pic_init returned with error after setting
pic_present.
Change-Id: Iea42e6ad2bc5a74517188fa5e4cc434bb96d46c7
2017-05-23 10:32:34 -07:00
Harish Mahendrakar
89e719dc77
Fix heap buffer overflow while searching for valid PPS
...
am: 5204651228
2017-05-17 10:04:11 +00:00
Harish Mahendrakar
5204651228
Fix heap buffer overflow while searching for valid PPS
...
Bug: 37094889
Test: Tested POC on ASAN build
Change-Id: Id4e52cd10a4d5eac015efe4b752162dc39cc30b8
2017-05-16 16:48:29 -07:00
Naveen Kumar P
f7635dd278
Merge "Check for buffer overflow in pps/slice header parsing" into lmp-dev
...
am: 1853d3871a
2017-05-16 22:24:02 +00:00
Harish Mahendrakar
c1c11822d6
Merge "memset SPS to zero" into lmp-dev
...
am: 31e21c5134
2017-05-16 22:23:52 +00:00
TreeHugger Robot
1853d3871a
Merge "Check for buffer overflow in pps/slice header parsing" into lmp-dev
2017-05-16 22:20:33 +00:00
TreeHugger Robot
31e21c5134
Merge "memset SPS to zero" into lmp-dev
2017-05-16 22:18:29 +00:00
Naveen Kumar P
d61d5e5f6a
Check for buffer overflow in pps/slice header parsing
...
Bug: 36215950
Bug: 36215953
Bug: 36216719
Change-Id: Ibdc05e1d5aa21d060d7c683fd9af4bed8537053f
2017-05-15 15:45:50 -07:00
Harish Mahendrakar
2e0e75aede
memset SPS to zero
...
SPS structure is memset to zero in parse_sps()
Bug: 33966031
Bug: 37458993
Change-Id: I7d4c04d2d25d7e9c8f581bd470260fc4394a564b
2017-05-12 16:21:21 -07:00
