Commit graph

471 commits

Author SHA1 Message Date
Manisha Jajoo
dcef8335b7 decoder: Fix memory uninitialized issue in ihevcd_sao_shift_ctb
Test: poc in bug
Bug: 158484516

Change-Id: I83e89056be52b96760d95f5826c2bfdcfd3962e2
2020-07-22 22:34:37 -07:00
TreeHugger Robot
7d3d14afcf Merge "decoder: Fix integer overflow while parsing num_long_term_pics" into qt-qpr1-dev am: 1e1b2c7f1e
Change-Id: Id3954a471692be4b737fd1409fcb0515f7fd6c03
2020-03-20 02:58:38 +00:00
TreeHugger Robot
1e1b2c7f1e Merge "decoder: Fix integer overflow while parsing num_long_term_pics" into qt-qpr1-dev 2020-03-20 02:31:08 +00:00
TreeHugger Robot
1b481aebd6 Merge "Fix DoS in NAL search" into qt-qpr1-dev 2020-03-19 18:39:44 +00:00
Harish Mahendrakar
7dcf82ada4 decoder: Fix integer overflow while parsing num_long_term_pics
Bug: 143826590
Test: poc in bug
Change-Id: I190a8e27a400f686cba88edd5c8721404e53b9cb
2020-02-11 16:23:38 -08:00
Harish Mahendrakar
75db1b8e48 Do not call SIMD format conversion for width < 32
Neon SIMD functions do not support width < 32.

Bug: 143464314
Test: poc in bug

Change-Id: I2445c3d98c0b1afbb1ef480403bbc67add629cac
(cherry picked from commit 6219b83299)
2020-02-04 19:31:27 +00:00
Harish Mahendrakar
196e72450a Fix DoS in NAL search
Bug: 139939283
Test: poc in bug
Change-Id: I345232790e2d351d82e9dc6973a5ef86ce513ef3
(cherry picked from commit e52410163e)
2020-02-04 05:09:05 +00:00
Automerger Merge Worker
468df916ac libhevcdec: iquant-itrans issue in chroma planes am: 445e0d8d5e am: bc614efab5 am: a17ed8aea7
Change-Id: I709937cf73009a6c37261f20a53ad2d514dc3969
2020-01-29 02:50:19 +00:00
Akshata Jadhav
445e0d8d5e libhevcdec: iquant-itrans issue in chroma planes
Misplaced local array on stack is resulting in color artifacts in
decoded yuv. It worked so far, because the array luma_nbr_flags_4x4[]
was always allocated on the same address and thus preserved values from
previous iteration.

Bug: 148157334
Test: atest android.media.cts.HeifWriterTest
Change-Id: Ic2b1964895bf26101508ff2ac82a94192b7b74f8
2020-01-28 04:56:13 +00:00
TreeHugger Robot
4622685ea4 Merge "Do not call SIMD format conversion for width < 32" 2019-12-04 00:15:53 +00:00
Harish Mahendrakar
6219b83299 Do not call SIMD format conversion for width < 32
Neon SIMD functions do not support width < 32.

Bug: 143464314
Test: poc in bug

Change-Id: I2445c3d98c0b1afbb1ef480403bbc67add629cac
2019-12-01 13:44:59 -08:00
Harish Mahendrakar
40dbcab01b decoder: Return error if first slice decoded in a frame is dependent slice
Dependent slice copies slice header from a previously decoded slice.
In case of errors, when the first slice is missing and subsequent slice to
be decoded is a dependent slice, it has no valid slice header to copy
from. Ignore such slices.

Bug: 141688974
Test: poc in bug
Change-Id: Idc1bed45ab37aeee4d373deb00e1b465ca84cfeb
2019-12-01 13:30:58 -08:00
Harish Mahendrakar
e52410163e Fix DoS in NAL search
Bug: 139939283
Test: poc in bug
Change-Id: I345232790e2d351d82e9dc6973a5ef86ce513ef3
2019-10-21 21:27:04 -07:00
Harish Mahendrakar
b5b07b5539 Merge "decoder: Reset slice header at start of slice header decode" into oc-dev am: 930597cb2e am: 588f78b7d7 am: 7b1140f957 am: 399938e52e am: 7aa6102559 am: 8bfa119917 am: 60f9768c9e
am: 3ef502bf64

Change-Id: I1092b88bb7903ae932a58c7ba71b869fc31e381e
2019-09-28 09:53:32 -07:00
Harish Mahendrakar
3ef502bf64 Merge "decoder: Reset slice header at start of slice header decode" into oc-dev am: 930597cb2e am: 588f78b7d7 am: 7b1140f957 am: 399938e52e am: 7aa6102559 am: 8bfa119917
am: 60f9768c9e

Change-Id: I2616ea213ca2d2790e597fcaa302b05118a0213b
2019-09-28 09:47:47 -07:00
Harish Mahendrakar
75d1ac1026 Merge "decoder: Reset slice header at start of slice header decode" into oc-dev am: 930597cb2e am: 588f78b7d7 am: 7b1140f957 am: 399938e52e am: 7aa6102559
am: 8bfa119917

Change-Id: I03efa8acbeeed1e82a49ac632a78a777b3419452
2019-09-28 09:41:58 -07:00
Harish Mahendrakar
60f9768c9e Merge "decoder: Reset slice header at start of slice header decode" into oc-dev am: 930597cb2e am: 588f78b7d7 am: 7b1140f957 am: 399938e52e am: 7aa6102559
am: 8bfa119917

Change-Id: Iec721bd520b328bb7d81d51106733715ea0105c8
2019-09-28 09:41:58 -07:00
Harish Mahendrakar
7aa6102559 Merge "decoder: Reset slice header at start of slice header decode" into oc-dev am: 930597cb2e am: 588f78b7d7 am: 7b1140f957
am: 399938e52e

Change-Id: I3107c7d7a21921561cbf1a9ebb34a8645011094d
2019-09-28 09:30:23 -07:00
TreeHugger Robot
930597cb2e Merge "decoder: Reset slice header at start of slice header decode" into oc-dev 2019-09-28 14:09:32 +00:00
Harish Mahendrakar
10bda93c03 Check change in CTB size when decoding multiple SPS with same id am: 70940fbabd am: a9fc115a23 am: a368569d61
am: 06aa42bdc7

Change-Id: I653fc906cffc10f57e7183b6696c4df4e77b44dc
2019-09-27 14:45:22 -07:00
Harish Mahendrakar
06aa42bdc7 Check change in CTB size when decoding multiple SPS with same id am: 70940fbabd am: a9fc115a23
am: a368569d61

Change-Id: I8b9eae557279323378b728e6452550f2547610c6
2019-09-27 14:37:21 -07:00
Harish Mahendrakar
12ef0d291b Check change in CTB size when decoding multiple SPS with same id am: 70940fbabd
am: a9fc115a23

Change-Id: I5b9cbfb2e9c11d1b66c22cc52aef64f9e263ad62
2019-09-27 14:30:47 -07:00
Harish Mahendrakar
a368569d61 Check change in CTB size when decoding multiple SPS with same id am: 70940fbabd
am: a9fc115a23

Change-Id: I962ca2ef87273ec6082d10abb1ee32b16a0c8118
2019-09-27 14:30:46 -07:00
Harish Mahendrakar
072f9084f4 Check change in CTB size when decoding multiple SPS with same id
If an SPS is being overwritten, ensure CTB size remains same.
If not, return from decoder and reset the decoder state in the
subsequent decode call.

Bug: 140322595
Test: poc in bug
Change-Id: Ie1a18b18704d6ef099535149fe21a1921bcbeeaf
Merged-In: I5f1e52d3bd2b48874a088ab32054f5a89e62eeb5
2019-09-19 21:34:52 -07:00
Harish Mahendrakar
70940fbabd Check change in CTB size when decoding multiple SPS with same id
If an SPS is being overwritten, ensure CTB size remains same.
If not, return from decoder and reset the decoder state in the
subsequent decode call.

Bug: 140322595
Test: poc in bug

Change-Id: I5f1e52d3bd2b48874a088ab32054f5a89e62eeb5
2019-09-19 21:17:50 -07:00
Harish Mahendrakar
42f70ae4ef decoder: Reset slice header at start of slice header decode
Reset slice header to zero, to avoid using invalid slice header
contents from prior headers parsed.

Bug: 140692129
Test: poc in bug
Change-Id: Ib2b7c006069b0226b5f2d741f9da7b681be26f82
2019-09-19 08:43:56 -07:00
Harish Mahendrakar
d23ca4b695 Decoder: Add support for returning reorder_depth and display index am: c7bf85f8ae
am: c9634afbf8

Change-Id: Ia627d30993c35d38b2e6c2f5b2b3c798f8885080
2019-09-12 11:20:30 -07:00
Harish Mahendrakar
c9634afbf8 Decoder: Add support for returning reorder_depth and display index
am: c7bf85f8ae

Change-Id: Idc4cf03240921d539946863e0395ed7e6cf27a59
2019-09-12 11:11:27 -07:00
Harish Mahendrakar
c7bf85f8ae Decoder: Add support for returning reorder_depth and display index
Bug: 138627015
Test: Verify reorder depth for few clips

Change-Id: Idea3ae794e1a54e630e6ee1ca8a4594978a3c8a2
2019-09-11 00:25:25 -07:00
Dan Willemsen
871711a4ce Stop using __DATE__/__TIME__ on all builds am: 4517537400 am: e0b810f1ac am: fa79eaab37 am: 2fc2323a51
am: 7d0bd44a9f

Change-Id: I23df03a0e5669eb6ef60dcd8708603179df369ed
2019-08-28 20:08:11 -07:00
Dan Willemsen
e0b810f1ac Stop using __DATE__/__TIME__ on all builds
am: 4517537400

Change-Id: I18b87b747af44aea683d4a1b8528cb770fb358fd
2019-08-28 19:32:06 -07:00
Dan Willemsen
4517537400 Stop using __DATE__/__TIME__ on all builds
We're beginning to use remote caches with Android builds, so I'm turning
on -Werror=date-time so that host builds are also reproducible.

Test: treehugger
Test: mmma external/libhevc
Change-Id: I7fa1099d68cced587af46ad4d76cab5af4366e1e
2019-08-27 19:45:01 -07:00
Harish Mahendrakar
406fb2aa0e common: Fix unintialized reads in intra pred sse functions
Bug: 137565646
Bug: 137228292
Test: poc in bug
Change-Id: I2830a30230cf566b17dca77a68136c9c4bd82215
2019-08-05 12:01:35 -07:00
Harish Mahendrakar
cf80d4f83c decoder: Fix integer overflow while parsing slice_qp_delta
Test: poc in bug
Bug: 136568826
Change-Id: Id1371249e80cb5858b1f93b5b25c8e4a43dbde04
2019-07-17 14:14:25 -07:00
Harish Mahendrakar
9fcd94f316 decoder: Fix valid SPS check in parsing SEI am: 61646846b3 am: 7f5da9039c am: e4237f852d
am: 824c19e4ca

Change-Id: I7b0970d485940b1c4c8eeea8f9cd316a84d1ac89
2019-06-20 21:20:00 -07:00
Saurabh Sood
f23d063692 Add push-pop for Neon D8-D15 registers
Bug: 68320413
Test: hevcdec with testbench updates to validate D8-D15

Change-Id: Ib62e68b69b016b1ded12cb00d1bb580de8a744c2
(cherry picked from commit 6acb36d25d)
2019-06-12 09:54:51 +00:00
Harish Mahendrakar
61646846b3 decoder: Fix valid SPS check in parsing SEI
When parsing SEI, ensure there is at least one valid SPS.

Test: poc in bug
Bug: 134420911

Change-Id: If3aa142b7fac324f8416e647572dfb002f56e06d
2019-06-07 16:23:17 -07:00
Saurabh Sood
907df0cf64 [automerger] Add push-pop for Neon D8-D15 registers am: 6acb36d25d am: 9acce62f78 am: 78acd1a8e7 am: 9313d3150d am: 61eb24a4f5 am: f82399d86a am: 091f45e3ad am: 0dce3a9137
am: 65974e7a26

Change-Id: I974dd9673b91ad80a72d27076fce4fe5697c7b8c
2019-05-31 14:51:24 -07:00
Android Build Merger (Role)
f82399d86a [automerger] Add push-pop for Neon D8-D15 registers am: 6acb36d25d am: 9acce62f78 am: 78acd1a8e7 am: 9313d3150d am: 61eb24a4f5
Change-Id: Ie4e0a965e53d25155ee7976e6588b4b797aa7ff0
2019-05-29 22:53:25 +00:00
Android Build Merger (Role)
9acce62f78 [automerger] Add push-pop for Neon D8-D15 registers am: 6acb36d25d
Change-Id: Ib972a88cef7e3ccb1388aede0d9e1919c218a66d
2019-05-29 22:53:14 +00:00
Saurabh Sood
6acb36d25d Add push-pop for Neon D8-D15 registers
Bug: 68320413
Test: hevcdec with testbench updates to validate D8-D15

Change-Id: Ib62e68b69b016b1ded12cb00d1bb580de8a744c2
2019-05-29 15:52:09 -07:00
Harish Mahendrakar
743001de6d Add few more checks for invalid parameters in sps
Following elements didn't have a bound check in SPS as spec doesn't list
the bounds on these explicitly.

log2_min_coding_block_size_minus3, log2_diff_max_min_coding_block_size,
log2_min_transform_block_size_minus2 and log2_diff_max_min_transform_block_size

Added appopriate error checks on these fields

Bug: 129366952
Bug: 130023983
Test: vendor
Merged-In: I59d95f43c2ef98300132d664095e88df8e87a164
Change-Id: I59d95f43c2ef98300132d664095e88df8e87a164
(cherry picked from commit 2f30da4ca2)
2019-05-15 05:32:20 +00:00
Harish Mahendrakar
34208286a1 Add bounds check for tile dimensions
Bug: 129976164
Bug: 130024844
Test: vendor/poc
Change-Id: I1e54babaec9c5ad199b60c7cfc1e24e36422f630
(cherry picked from commit 05f83e9458)
2019-05-15 05:32:16 +00:00
Harish Mahendrakar
76221fb693 Add missing return check for short_term_ref_pic_set()
Bug: 129401104
Bug: 130025324
Test: vendor
Change-Id: I685dd29ec13cca0ced5de8eb3aea1d0da5952a62
(cherry picked from commit 299cceb9e4)
2019-05-15 05:32:11 +00:00
Ray Essick
9e7930ac53 Merge "Add few more checks for invalid parameters in sps" into nyc-dev 2019-05-08 16:20:06 +00:00
Android Build Merger (Role)
8fb024bad3 [automerger] Add few more checks for invalid parameters in sps am: 2f30da4ca2 am: 59c1e4d23e am: 7dbf2eeb7f am: 4fd075fd4d am: e10f3d3c6d
Change-Id: I44b6ea6f4a0af681be55c893cb9241ef5e90ec4c
2019-05-07 20:47:48 +00:00
Android Build Merger (Role)
59c1e4d23e [automerger] Add few more checks for invalid parameters in sps am: 2f30da4ca2
Change-Id: I78d8b0b2a9e804f3af8fd090876fbd2750d1edf9
2019-05-07 20:47:43 +00:00
Harish Mahendrakar
2f30da4ca2 Add few more checks for invalid parameters in sps
Following elements didn't have a bound check in SPS as spec doesn't list
the bounds on these explicitly.

log2_min_coding_block_size_minus3, log2_diff_max_min_coding_block_size,
log2_min_transform_block_size_minus2 and log2_diff_max_min_transform_block_size

Added appopriate error checks on these fields

Bug: 129366952
Bug: 130023983
Test: vendor
Merged-In: I59d95f43c2ef98300132d664095e88df8e87a164
Change-Id: I59d95f43c2ef98300132d664095e88df8e87a164
2019-05-07 20:47:42 +00:00
Harish Mahendrakar
3d5a29afff Merge changes from topic "am-5b50c796-9c7d-4769-bc6c-f71bdac7c742" into oc-dev am: dce2f1a1a1 am: 7dd0807cdf am: cfebb9ec7d
am: 6b80fa9f71

Change-Id: I9a3853b7ca08ab2f10e2479721921dff59809449
2019-05-06 19:11:23 -07:00
Harish Mahendrakar
c34a29b7b5 [automerger] Add missing return check for short_term_ref_pic_set() am: 299cceb9e4 am: 2e8ae23656 am: 7ecb4083b9 am: 4fe71a567e am: 1561dc0fa9 am: 2b9fa38bb8 am: 6e96227190 am: cd5ac287ce
am: 0cdffda83f

Change-Id: I9086ab27ca823acc255239123cdeffe5671e3e18
2019-05-06 17:27:22 -07:00