Commit graph

172 commits

Author SHA1 Message Date
Marco Nelissen
92c2b4cc1a Merge "Fix tile index buf alloc size" into mnc-dr-dev 2017-10-31 17:50:36 +00:00
Naveen Kumar P
44b8f080fb Merge "Set error skip ctbs as multiple 8x8 pus" into lmp-dev am: 6587d735fa am: 27e8401a7c
am: 862bb09d83

Change-Id: I5de0426f1e6ab5ae6611f32881196290260b775f
2017-10-20 19:56:40 +00:00
Naveen Kumar P
862bb09d83 Merge "Set error skip ctbs as multiple 8x8 pus" into lmp-dev am: 6587d735fa
am: 27e8401a7c

Change-Id: Ia7712ae3fa31002fbde12b2491d42c8532555a26
2017-10-20 19:54:10 +00:00
Naveen Kumar P
27e8401a7c Merge "Set error skip ctbs as multiple 8x8 pus" into lmp-dev
am: 6587d735fa

Change-Id: Iec9ffae348591115bb7d21c93acbdbb69adbf703
2017-10-20 19:52:10 +00:00
TreeHugger Robot
6587d735fa Merge "Set error skip ctbs as multiple 8x8 pus" into lmp-dev 2017-10-20 19:44:51 +00:00
Robert Shih
556af11a03 Merge "Added an out of bound check on u4_num_bufs in input argument" into lmp-dev am: 4b5c23e393 am: b49adbf304
am: 4ff7f4bfee

Change-Id: Idd6ee6f7ce322c025864b954cabe098776718ca7
2017-10-18 18:43:28 +00:00
Naveen Kumar P
1ee4f5d773 Fix tile index buf alloc size
Bug: 64893226

Change-Id: Iec02f6a7b65804cc3daadf6e29d57a7ad955d517
(cherry picked from commit 6921d875c1)
2017-10-18 18:29:40 +00:00
Ray Essick
425ee10a01 Alloc extra bytes for bits buf for parse optimzation am: 2ae456c2a3
am: 512ea0e115

Change-Id: I5c6c1817e1033548246f37a66b0c4f273526eec5
2017-10-18 18:12:48 +00:00
Robert Shih
4ff7f4bfee Merge "Added an out of bound check on u4_num_bufs in input argument" into lmp-dev am: 4b5c23e393
am: b49adbf304

Change-Id: I8798964119251ab311a0884ccdc326f7fba11871
2017-10-18 18:12:17 +00:00
Marco Nelissen
8db8414337 Merge "Fix tile index buf alloc size" into lmp-dev am: 4b9053c15c
am: b1d1fad9f6

Change-Id: I71d054275736897960883d16b3fe6cb1807b39a4
2017-10-18 18:11:58 +00:00
Ray Essick
512ea0e115 Alloc extra bytes for bits buf for parse optimzation
am: 2ae456c2a3

Change-Id: I433259a5e1a0f17be601b126c558abde80c8aa80
2017-10-10 02:58:15 +00:00
Naveen Kumar P
2b9fb0c207 Set error skip ctbs as multiple 8x8 pus
Bug: 65123471

This is required for incomplete ctbs at the frame
boundaries

Change-Id: I7e41a3ac2f6e35a929ba4ff3ca4cfcc859a7b867
2017-10-05 13:56:13 -07:00
Ray Essick
2ae456c2a3 Alloc extra bytes for bits buf for parse optimzation
Without this extra allocation, if a nal fills entire bits
buffer, there will be out of bound memory read access.

Bug: 65719872
Test: ran poc before/after on ASAN of master
Change-Id: I9f4fca0739db84db023b1252c1365bfd13355541
Merged-In: I1c36821505bdc4fe6c23f30a02ab2fb0fb657946
2017-10-03 16:04:33 -07:00
Naveen Kumar P
4cf597a518 Alloc extra bytes for bits buf for parse optimzation
Without this extra allocation, if a nal fills entire bits
buffer, there will be out of bound memory read access.

Bug: 65719872
Test: ran poc before/after on ASAN of master
Change-Id: I1c36821505bdc4fe6c23f30a02ab2fb0fb657946
2017-10-03 15:30:34 -07:00
Robert Shih
b49adbf304 Merge "Added an out of bound check on u4_num_bufs in input argument" into lmp-dev
am: 4b5c23e393

Change-Id: I8608961e4cbf7c7d2d73711a7b7ce6cf2332aa8c
2017-09-13 20:36:55 +00:00
Robert Shih
4b5c23e393 Merge "Added an out of bound check on u4_num_bufs in input argument" into lmp-dev 2017-09-13 20:15:11 +00:00
Marco Nelissen
b1d1fad9f6 Merge "Fix tile index buf alloc size" into lmp-dev
am: 4b9053c15c

Change-Id: If94227bf83556964569337503bae0b75feca7991
2017-09-13 05:51:33 +00:00
Marco Nelissen
4b9053c15c Merge "Fix tile index buf alloc size" into lmp-dev 2017-09-13 05:00:56 +00:00
Harish Mahendrakar
8221313d58 Added an out of bound check on u4_num_bufs in input argument
ps_dec_ip->s_out_buffer.u4_num_bufs was missing out of bound checks

Bug: 35430570
Change-Id: Ibbf9891a885f69e208107725e34e7217147b891e
2017-09-12 13:13:26 -07:00
Naveen Kumar P
578f676115 Fix heap buffer overflow
am: f6ba5eae65

Change-Id: I6e8bcefce5e4a7df8cdc5519734b8c0f4a9c1ce6
2017-09-11 23:50:27 +00:00
Naveen Kumar P
334f896e61 Fix tile index buf alloc size
Bug: 64893226
2017-09-11 15:40:03 -07:00
Naveen Kumar P
5aee254181 RESTRICT AUTOMERGE Fix heap buffer overflow
Test:
- Push multi_rec.hevc (in the bug thread) to the device
- Build:
mmm external/libhevc
- Run on device:
hevcdec --input multi_res.hevc  --num_frames -1 --num_cores 2

Bug: 62815506

Merged-In: I7e0828c9a9bb1e9997c379544ea5f4eb3556417d
Change-Id: I7e0828c9a9bb1e9997c379544ea5f4eb3556417d
2017-09-08 21:15:45 -07:00
Naveen Kumar P
f6ba5eae65 Fix heap buffer overflow
Test:
- Push multi_rec.hevc (in the bug thread) to the device
- Build:
mmm external/libhevc
- Run on device:
hevcdec --input multi_res.hevc  --num_frames -1 --num_cores 2

Bug: 62815506

Merged-In: I7e0828c9a9bb1e9997c379544ea5f4eb3556417d
Change-Id: I7e0828c9a9bb1e9997c379544ea5f4eb3556417d
2017-09-08 21:14:34 -07:00
Naveen Kumar P
5109aa40af Merge "Fix slice decrement for skipped slices" into mnc-dev
am: d743ed23ff

Change-Id: If31bb64ed4da5a773cc32b5a33e93ea85acda776
2017-08-03 21:08:48 +00:00
TreeHugger Robot
d743ed23ff Merge "Fix slice decrement for skipped slices" into mnc-dev 2017-08-03 20:58:10 +00:00
Harish Mahendrakar
107cdf1c41 Merge "Ensure CTB size > 16 for clips with tiles and width/height >= 4096" into lmp-dev am: db15dd7102 am: 419fd4b745 am: 8e6cf47bf1
am: 61f3fbfe13

Change-Id: I640c619d9c69774e716ce43cb77b1bc1bb8869e7
2017-08-03 18:59:37 +00:00
Harish Mahendrakar
61f3fbfe13 Merge "Ensure CTB size > 16 for clips with tiles and width/height >= 4096" into lmp-dev am: db15dd7102 am: 419fd4b745
am: 8e6cf47bf1

Change-Id: I893a9a91df23625bf2cbd6ce2d226b682c773130
2017-08-03 18:53:37 +00:00
Harish Mahendrakar
419fd4b745 Merge "Ensure CTB size > 16 for clips with tiles and width/height >= 4096" into lmp-dev
am: db15dd7102

Change-Id: Ie3b65dfa829d06fbdeb6590cf1458dc886ab6126
2017-08-03 18:40:37 +00:00
TreeHugger Robot
db15dd7102 Merge "Ensure CTB size > 16 for clips with tiles and width/height >= 4096" into lmp-dev 2017-08-03 18:28:53 +00:00
Harish Mahendrakar
248e72c7a8 Ensure CTB size > 16 for clips with tiles and width/height >= 4096
For clips with tiles and dimensions >= 4096,
CTB size of 16 can result in tile position > 255.
This is not supported by the decoder

Bug: 37930177
Test: ran poc w/o crashing
Change-Id: I2f223a124c4ea9bfd98343343fd010d80a5dd8bd
2017-07-24 12:33:29 -07:00
Naveen Kumar P
272f2c23c8 Fix slice decrement for skipped slices
Test: run the poc with and without the patch
Bug: 63045918
Change-Id: I27804d42c55480c25303d1a5dbb43b1d86d7fa94
2017-07-17 22:17:09 +00:00
Harish Mahendrakar
e9683f3831 Merge "Limit boundary PU sizes in case of errors" into lmp-dev am: f661b00835 am: 34ec365ad3 am: f7579e8bd4
am: 54ce382232

Change-Id: Ic01606b0ac69b17f2233c91e202d98179a511d52
2017-07-10 19:51:56 +00:00
Harish Mahendrakar
54ce382232 Merge "Limit boundary PU sizes in case of errors" into lmp-dev am: f661b00835 am: 34ec365ad3
am: f7579e8bd4

Change-Id: I38d1ada08789a4fe31063445af07c6c75dcb50b1
2017-07-10 19:47:56 +00:00
Harish Mahendrakar
34ec365ad3 Merge "Limit boundary PU sizes in case of errors" into lmp-dev
am: f661b00835

Change-Id: I88fb6c3b0a8063e9b7841cf569dda57b0ffbcfb2
2017-07-10 19:38:57 +00:00
TreeHugger Robot
f661b00835 Merge "Limit boundary PU sizes in case of errors" into lmp-dev 2017-07-10 19:29:45 +00:00
Naveen Kumar P
1363086b84 Merge "Check number of output buffers and sizes" into lmp-dev am: 493410548a am: 41d5957422 am: cecb593ca5
am: 6bf3e38d8c

Change-Id: I179c1b76706a54adb014cd5a8c7d75b98025239a
2017-06-16 23:37:33 +00:00
Naveen Kumar P
6bf3e38d8c Merge "Check number of output buffers and sizes" into lmp-dev am: 493410548a am: 41d5957422
am: cecb593ca5

Change-Id: I5e81ebce4997638ea565460f28af3131248e47b4
2017-06-16 23:35:33 +00:00
Naveen Kumar P
41d5957422 Merge "Check number of output buffers and sizes" into lmp-dev
am: 493410548a

Change-Id: I2f44136cdfd6179712843915dbceb79d3e6aa600
2017-06-16 23:32:02 +00:00
TreeHugger Robot
493410548a Merge "Check number of output buffers and sizes" into lmp-dev 2017-06-16 23:26:32 +00:00
Naveen Kumar P
78e98c5480 Return error for invalid crop parameters am: e8c26c16d7 am: 870c70383d am: 6850014493
am: fc0890497a

Change-Id: Ieab583dcfdd14b70b99e51dd3b7c9a7ba9fbc7ae
2017-06-16 18:48:12 +00:00
Naveen Kumar P
fc0890497a Return error for invalid crop parameters am: e8c26c16d7 am: 870c70383d
am: 6850014493

Change-Id: I9df5bb8d14a56469ecb534061404d0da41dee8c2
2017-06-16 18:41:10 +00:00
Naveen Kumar P
870c70383d Return error for invalid crop parameters
am: e8c26c16d7

Change-Id: I7e8ae1eeccfc75b175485e47136b16d27a0b23c6
2017-06-16 18:28:38 +00:00
Naveen Kumar P
e8c26c16d7 Return error for invalid crop parameters
Test: run poc with and without the patch
Bug: 62214264
Change-Id: If627ee9a8f0dbd65963897966e1c2d39f5fbd428
2017-06-15 20:19:16 +00:00
Harish Mahendrakar
62830d130b Limit boundary PU sizes in case of errors
In case of error clips, some PUs are marked as skip.
Ensure such PUs stay within the picture

Bug: 37615911
Test: ran POC included with the bug.
Change-Id: Ie0aeccc752cf556f9dea84de61c15a7906e1060b
2017-06-13 14:54:58 -07:00
Naveen Kumar P
1ffb19f7ae Check number of output buffers and sizes
Bug: 37435531
Bug: 36817631
Bug: 36492741
Change-Id: I85e3da9a8aaefaac0b494868fdc94d858e4cf8e6
2017-06-07 15:28:48 -07:00
Naveen Kumar P
835420e636 Merge "Fix OOB issue in nal unit parsing" into lmp-dev am: 1ce65aea9f am: c1451ed95b am: 18a325cf80
am: f9a3d7de57

Change-Id: If8eb5fd76b4aa6c526382f7c3babf1e1a001581c
2017-06-06 20:57:49 +00:00
Naveen Kumar P
f9a3d7de57 Merge "Fix OOB issue in nal unit parsing" into lmp-dev am: 1ce65aea9f am: c1451ed95b
am: 18a325cf80

Change-Id: I83294b270ac8f6853dce67076b497d2744aed571
2017-06-06 20:54:48 +00:00
Naveen Kumar P
c1451ed95b Merge "Fix OOB issue in nal unit parsing" into lmp-dev
am: 1ce65aea9f

Change-Id: I3778ef75155d6d53876525803a22d045ba2c27ff
2017-06-06 20:50:48 +00:00
TreeHugger Robot
1ce65aea9f Merge "Fix OOB issue in nal unit parsing" into lmp-dev 2017-06-06 20:42:09 +00:00
Marco Nelissen
e30fa58cf0 Merge "DO NOT MERGE Added check for invalid log2_max_transform_block_size in SPS" into lmp-dev 2017-06-06 20:10:10 +00:00