617 commits

Author	SHA1	Message	Date
Harish Mahendrakar	2887504d35	Add u4_enable_hbd to control 10-bit decoding support ... - Add u4_enable_hbd member to ihevcd_cxa_create_ip_t and codec_t. - Return error in ihevcd_parse_sps if u4_enable_hbd is 0 and bit_depth_luma_minus8 or bit_depth_chroma_minus8 are non-zero. - Initialize u4_enable_hbd to 1 by default in main.c, DecHelper/DecTests, and hevc_dec_fuzzer.cpp. - Add --enable_hbd command line option in main.c. - Add test in DecTests.cpp to ensure decoder returns an error when decoding 10b clip with u4_enable_hbd set to 0.	2026-09-29 08:29:55 +05:30
Harish Mahendrakar	2954873b8f	[decoder] Use ihevc_memset_16bit_fptr to initialize reference picture buffers ... Dispatch via ihevc_memset_16bit_fptr instead of calling ihevc_memset_16bit directly when initializing reference picture buffers for the first frame.	2026-09-28 07:15:04 -07:00
Harish Mahendrakar	8b9315b93e	[decoder] Remove unused function pointer members from func_selector_t ... Remove 8 function pointer members from func_selector_t that are never invoked anywhere in the decoder: - ihevc_itrans_4x4_ttype1_fptr - ihevc_itrans_4x4_fptr - ihevc_itrans_8x8_fptr - ihevc_itrans_16x16_fptr - ihevc_itrans_32x32_fptr - ihevc_memset_16bit_mul_8_fptr - ihevc_weighted_pred_chroma_bi_default_fptr - ihevc_hbd_weighted_pred_chroma_bi_default_fptr	2026-09-28 07:14:43 -07:00
Harish Mahendrakar	bd84669497	correct input bufsize in get_bufinfo call for 422/444	2026-09-24 07:52:16 -07:00
Harish Mahendrakar	ba236e2168	Enable HBD support in SPS parsing modules	2026-09-24 06:55:40 -07:00
Harish Mahendrakar	4fc1fef4bf	[decoder]: Add 10-bit SAO support	2026-09-24 06:55:25 -07:00
Harish Mahendrakar	cf50937101	[decoder]: Use pixel_size_y and pixel_size_uv to compute SAO address offsets	2026-09-24 06:55:25 -07:00
Harish Mahendrakar	f06c6adac7	Consolidate sao_10bd_t into sao_t	2026-09-23 21:49:38 -07:00
Harish Mahendrakar	b7bb9836ff	Invoke HBD iq it recon functions	2026-09-23 21:49:25 -07:00
Harish Mahendrakar	cd3ba3e0b4	Update SAO scratch allocations for HBD	2026-09-23 21:49:03 -07:00
Harish Mahendrakar	f6e0db2aa3	Invoke HBD format conversion functions	2026-09-23 07:03:49 -07:00
Harish Mahendrakar	3505dee824	Fix indentation in ihevcd_iquant_itrans_recon_ctb.c ... This has no functional changes. This is done to make it easier to review the updates for HBD support that will be done in the subsequent commits.	2026-09-22 07:16:34 -07:00
Harish Mahendrakar	65d2584a81	Invoke HBD inter pred functions	2026-09-22 07:16:18 -07:00
Harish Mahendrakar	38322d5ce4	Allow QP to be negative for HBD	2026-09-22 07:16:02 -07:00
Harish Mahendrakar	b4c9c51f29	[decoder] Detect dynamic change in bit-depth and chroma format ... bit-depth is still not allowed to be greater than 8, but this adds support to detect dynamic changes in bit-depth which will not be supported.	2026-09-22 07:15:41 -07:00
Harish Mahendrakar	0f30d73943	Add support for parsing PCM for HBD	2026-09-22 07:15:24 -07:00
Harish Mahendrakar	d16a0a0f4c	[decoder] Add support to set output chroma to 128 or 512 based on bit-depth for monochrome	2026-09-22 07:15:10 -07:00
Harish Mahendrakar	d92b1ed2e3	invoke hbd padding functions	2026-09-22 07:14:50 -07:00
Harish Mahendrakar	30b9f67578	invoke hdb deblocking functions	2026-09-22 07:14:36 -07:00
Harish Mahendrakar	6ea3de6e18	[decoder]: Add i4_qp_bd_offset_y and i4_qp_bd_offset_uv support ... - Declare i4_qp_bd_offset_y and i4_qp_bd_offset_uv in codec_t - Initialize i4_qp_bd_offset_y and i4_qp_bd_offset_uv in ihevcd_parse_sps() - Use i4_qp_bd_offset_y in slice_qp clipping and CU QP calculation - Use i4_qp_bd_offset_y in luma dequantization (qp_div and qp_rem)	2026-09-21 06:53:55 -07:00
Harish Mahendrakar	8ffe80c8bd	Update weighted pred parsing module to support HBD	2026-09-21 06:53:39 -07:00
Harish Mahendrakar	ed63d991e9	[decoder]: Add and initialize HBD leaf-level function pointers ... - Add HBD typedefs and function pointer arrays to codec_t in ihevcd_structs.h - Add HBD function pointers to func_selector_t in ihevcd_function_selector.h - Initialize generic HBD function pointers in ihevcd_function_selector_generic.c - Invoke ihevcd_init_function_ptr_generic in ARM and x86 function selectors	2026-09-21 06:53:25 -07:00
Harish Mahendrakar	dd14d7f6de	[decoder]: Change pu1_pic_qp and pu1_qp to WORD8 type and rename ... QP can be negative in HBD path. - Change pu1_pic_qp and pu1_qp to WORD8 type - Rename pu1_pic_qp and pu1_qp to pi1_pic_qp and pi1_qp - Update offset accesses to pi1_qp and pi1_pic_qp across deblocking, boundary strength, and slice parsing	2026-09-21 06:53:06 -07:00
Harish Mahendrakar	b91df9fcac	[decoder]: Use pixel_size_y and pixel_size_uv to compute sizes and address offsets ... Port changes from hbd branch that use pixel_size_y and pixel_size_uv to compute buffer sizes and address offsets: - ihevcd_utils: Scale picture buffer sizes and pointer offsets. - ihevcd_process_slice: Scale CTB offsets and bottom padding offsets. - ihevcd_deblk: Scale source pointers, strides, and rewind offsets. - ihevcd_fmt_conv: Scale cropping and row address offsets, and copy strides. - ihevcd_inter_pred: Scale reference picture addresses and destination offsets. - ihevcd_iquant_itrans_recon_ctb: Scale IPCM buffers, TU/sub-TU pred/dst pointers, intra reference substitution buffers, and neighbor pointers. - ihevcd_api: Scale SAO buffer allocations and offsets, SAO structure size, bitstream buffer size, and min output buffer sizes.	2026-09-21 06:52:43 -07:00
Harish Mahendrakar	5b574436c3	Add hbd functions for ihevcd_fmt_conv and ihevcd_itrans_recon_dc	2026-09-17 16:15:01 -07:00
Harish Mahendrakar	8e4247c53e	[decoder]: Add few entries in codec_t and initialize them for default paths ... Added few members in codec_t and initialized them for 420P, 8bit path. When HBD support is added these will be updated based on the parsed headers.	2026-09-17 12:54:51 -07:00
Harish Mahendrakar	816221d81e	libhevcdec: Reset PPS scratch buffer and extension flags before parsing ... When parsing PPS in ihevcd_parse_pps(), the scratch buffer ps_codec->s_parse.ps_pps_base + MAX_PPS_CNT - 1 was not reset to zero, unlike ihevcd_parse_sps(). In streams with concatenated sequences where an earlier sequence set pps_extension_present_flag and range extension flags, subsequent sequences without PPS extensions would retain the stale flags. This caused the parser to attempt reading non-existent range extension syntax, leading to bitstream parsing failure. - In ihevcd_parse_pps(), reset the scratch PPS structure to zero upon entry while preserving pi2_scaling_mat and ps_tile pointers. - In both ihevcd_parse_pps() and ihevcd_parse_sps(), explicitly zero all extension flags when pps_extension_present_flag / sps_extension_present_flag is 0. Test: ./hevc_dec_tests TAG=agy CONV=476d1054-10ff-4f19-88d5-a1c8dae7b57f (cherry picked from commit 4bf5819c62)	2026-09-17 12:25:17 -07:00
Harish Mahendrakar	fcdeaae045	[decoder] Add bit_depth to iv_yuv_buf_t and ivd_video_decode_op_t ... This new field is currently hard-coded to 8. This will be updated high bit-depth support is added later.	2026-09-16 15:45:58 -07:00
Narayan Kalaburgi	7ef245d5fa	Remove ihevc_hbd_itrans_res.c and update ihevc_itrans_res.c to support hdb ... Partial cherry pick of commit 9886db71d3	2026-09-16 13:16:47 -07:00
Harish Mahendrakar	1713ca27ea	decoder: Fix race condition and invalid CTB coordinates in slice headers ... In ihevcd_copy_slice_hdr(), copying the previous slice header for dependent slices copied i2_ctb_x and i2_ctb_y. If parsing was aborted or delayed, the incomplete slice header retained the previous slice's coordinates, causing concurrent worker threads in ihevcd_slice_hdr_update() to prematurely switch to the invalid slice header. Reset i2_ctb_x and i2_ctb_y to -1 after copying. In ihevcd_parse_slice_header(), initialize i2_ctb_x and i2_ctb_y to -1 immediately following memset so that slices rejected prior to coordinate parsing do not retain valid-looking (0, 0) coordinates. In ihevcd_parse_pic_init(), only skip reinitializing slice header 1 if the first slice was missing in the current picture. Test: ./hevc_dec_tests Test: ./hevc_dec_fuzzer /work/misc/oss-fuzz/build/out/libhevc/crash-b74b07ae377d7450614e4534c86155d1d2999e13 TAG=agy CONV=cfdfe257-7362-41c9-b5be-18261f1c6a3d	2026-09-16 10:56:47 +05:30
StevenShen3641	b21f809576	Fix out-of-bounds read when an SEI payload exceeds the NAL ... ihevcd_parse_sei() truncated the declared SEI payload size to the bytes remaining with MIN() instead of rejecting it. The payload parsers do not consult that size, so ihevcd_parse_mastering_disp_params_sei() read its full 24-byte structure out of a one-byte payload and ran past the end of the bitstream buffer.	2026-09-03 22:44:32 -07:00
Harish Mahendrakar	d42200d2f2	decoder: Fix OOB read in ihevcd_parse_sei_payload when no SPS is valid ... When parsing SEI payloads before any valid SPS has been decoded, ihevcd_parse_sei_payload scanned ps_codec->ps_sps_base using a loop that could step past the array bounds and dereference an invalid pointer. Initialize ps_sps to NULL, check each entry's validity within bounds, and return safely if no valid SPS is present.	2026-09-02 12:58:11 +05:30
Vivek R Jadhav	1a3c8d651a	libhevcdec: Fix chroma SAO neighbor handling for CTB size 16 ... - For CTB size 16 in 4:2:2, sub-block width is 0, causing the Top and Current SAO blocks to be skipped. - Fix Top-Right neighbor in Left block to read from picture buffer when ctb_size == 16 and ctb_y != 0, while keeping line buffer for larger CTBs (32, 64). - Fix Bottom-Left neighbor in Left block to read from picture buffer when ctb_size == 16 to avoid uninitialized backup buffer access. - Generalize Top-Left block condition to (8 * v_samp_factor). Test: ./hevcdec Change-Id: I013e44e024258f2f84690fdc0109210129042245	2026-08-28 04:50:37 +00:00
Vivek R Jadhav	0b2b1d8232	libhevcdec: Fix issues seen in 422 8 bit intra prediction ... - In 4:2:2 chroma format, transform blocks are partitioned into two square sub-TUs (subtu_idx == 0 and subtu_idx == 1). - Fix neighbor availability bitfield mapping for sub-TU 0 and sub-TU 1 based on trans_size (8, 16, 32). - Add reference documentation from ITU-T H.265 Section 7.3.8.8 and Section 8.4.4.2.2. Test: ./hevcdec Change-Id: I013e44e024258f2f84690fdc0109201129042155	2026-08-28 04:50:23 +00:00
Sushant	7da5afcd72	hevcdec: fix chroma SAO ctb-size check for 4:4:4 ... Earlier condition was correctly hardcoded for 420 with luma ctb size as 16. Updated the condition to scale for other chroma factors with vert, and horz subsample factor. Change-Id: I013e67e024258f2f84690fdcc01b4cd52f0fac52	2026-08-21 14:13:01 +00:00
Rakesh Kumar	e3ce7e69cb	hevcdec: Remove rext generic function pointer override for 422/444 ... With SIMD optimizations updated and enabled for 422 and 444 chroma formats, the fallback override in ihevcd_init_function_ptr_rext_generic is no longer necessary. Test: ./build	2026-08-17 16:29:15 +00:00
Rakesh Kumar	efa8b27448	hevcdec: Enable assembly and intrinsic intra prediction functions for 444 and 422 chroma formats ... Remove generic C overrides for chroma and luma intra prediction in ihevcd_init_function_ptr_rext_generic to allow architecture-specific assembly and SIMD intrinsics to be used during 422 and 444 decoding.	2026-08-12 03:37:56 +00:00
Vivek R Jadhav	d61070bafe	libhevc: Update intrinsic for implicit RDPCM ... Test: ./hevcdec Change-Id: I013e44e024258f2f84690fdc0109200109042035	2026-08-05 14:37:42 +00:00
Vivek Jadhav	ce30a4b0e3	libhevcdec: Reapply deblocking assembly changes for YUV444 and YUV422 ... Test: ./hevcdec TODO: Add assemblies and intrinsics for deblocking 422 Change-Id: I40411c04ab00d7e23843eb1d033c4944e3ec66e9	2026-08-04 06:04:10 +00:00
Vivek R Jadhav	6f423a375a	libhevcdec: Enable architecture-specific SIMD optimizations for 422 and 444 ... Previously, when 422 or 444 chroma formats were encountered, all function pointers were overridden to generic C implementations due to lack of support in optimized assemblies/intrinsics for certain components. This change introduces `ihevcd_init_function_ptr_rext` which: - First initializes all function pointers with architecture-optimized versions. - Explicitly overrides only the components not yet optimized for 422/444 formats (intra prediction, SAO, deblocking and chroma padding) to point back to their C implementations. This allows other fully-compatible modules (e.g: inter prediction modes, transform/reconstruction, format conversion) to benefit from SIMD optimizations on 422/444 formats without degrading YUV 420 decoding. Test: ./hevcdec Change-Id: I013e44e024258f2f84690fdc0109200129042145	2026-08-03 13:29:07 +00:00
Vivek Jadhav	a4cb498b8b	libhevcdec: Fix conformance issues for transform skip and implicit RDPCM ... - disable_boundary_filter flag was not reset within the TU loop. This caused the flag to remain sticky at 1 for all subsequent TUs in the CTB once set by any TU. - Transform-skip blocks larger than 4x4, the scaling/dequantization matrix is bypassed and the scaling factor is set to a constant of 16 as per HEVC specification section 8.6.3. - Bypassing the inverse transform for transform-skip blocks requires applying a scaling of tsShift (Rec. ITU-T H.265 Section 8.6.2 Eq 8-296: tsShift = 5 + log2_trans_size) and descaling of bdShift (Eq 8-295: bdShift = 20 - bit_depth). Net shift: shift_ts = bdShift - tsShift (20 - bit_depth) - (5 + log2_trans_size) 15 - bit_depth - log2_trans_size. Test: ./hevcdec Change-Id: I40411c04ab00d7e23842eb1d033c4543e4ec75e9	2026-07-30 09:36:12 -07:00
Harish Mahendrakar	b8c9100658	Remove incorrect prefix from ihevcd_itrans_res_dc ... ihevcd_itrans_res_dc is defined in common folder but has a wrong prefix of ihevcd_. This is now fixed to ihevc_.	2026-07-29 17:08:35 -07:00
Harish Mahendrakar	8dffbdd2d0	Move IVD_ARCH_T and IVD_SOC_T to iv.h and rename as IV_ARCH_T and IV_SOC_T ... This helps in decoupling unit tests in common from depending on ivd.h	2026-07-29 15:37:52 -07:00
Sabith Saheb	41d029542e	fix oob top-left pu-map read in ihevcd_get_mv_ctb	2026-07-14 07:25:34 -07:00
Sabith Saheb	1cef4c170f	fix oob slice-index read in ihevcd_sao_shift_ctb	2026-07-14 07:25:11 -07:00
Harish Mahendrakar	085f030e9e	Invoke ihevcd_free_dynamic_bufs() in ihevcd_allocate_dynamic_bufs() ... This will ensure that any memory that is allocated before and not yet freed, will be freed. This is done as a precaution to ensure there are no leaks.	2026-07-13 00:08:29 -07:00
Sabith Saheb	c605590236	use unsigned word type in ihevcd_bits_seek to avoid signed shift ub	2026-07-06 21:28:17 -07:00
Ram Mohan M	bc802ee605	hevcdec: update chroma subsample filter from neighbor to area ... For clips with chroma format idc 444/422 and output format selected to 420, after decoding during chroma sampling conversion from 444/422 to 420, neighbor filtering is done currently. This is updated to area. Test: ./hevcdec Change-Id: I024886655084051093858c5c40a94c0373c64813	2026-07-02 10:09:50 -07:00
Sushant	d629b12768	hevcdec: fix statcoeff placement for persistent rice adaptation ... According to the ITU Specs (9.3.3.11) the statCoeff for persistent rice adaptation must only be updated when the parsing of coeff_abs_level_remaining is actually triggered. Earlier, the i1_update_stats was incorrectly placed outside, resulting stateCoeff getting incorrectly updated for the first coefficient of every sub-block, and corrupting it. Test: ./hevcdec Change-Id: I7535ced74c18f55a7aff31d1c6d6d68f4a28f2cd	2026-06-24 22:51:07 -07:00
SABITHSAHEB	8260aefeb9	fix oob chroma source read in ihevcd_fmt_conv_422sp_to_420p	2026-06-23 09:21:08 +05:30