Remove unnecessary null checks for function pointers in tests
Some checks failed
CMake / build (cmake, aarch64-linux-gnu-gcc, -DCMAKE_TOOLCHAIN_FILE=../cmake/toolchains/aarch64_toolchain.cmake, aarch64-linux-gnu-g++, ubuntu-latest-cross-aarch64-cmake, ubuntu-latest) (push) Has been cancelled
CMake / build (cmake, arm-linux-gnueabihf-gcc, -DCMAKE_TOOLCHAIN_FILE=../cmake/toolchains/aarch32_toolchain.cmake, arm-linux-gnueabihf-g++, ubuntu-latest-cross-aarch32-cmake, ubuntu-latest) (push) Has been cancelled
CMake / build (cmake, clang, , clang++, macos-latest-clang-cmake, macos-latest) (push) Has been cancelled
CMake / build (cmake, clang, , clang++, ubuntu-24.04-arm-clang-cmake, ubuntu-24.04-arm) (push) Has been cancelled
CMake / build (cmake, clang, , clang++, ubuntu-latest-clang-cmake, ubuntu-latest) (push) Has been cancelled
CMake / build (cmake, clang, -DSANITIZE=fuzzer-no-link,address, clang++, ubuntu-latest-clang-cmake-asan-fuzzer, ubuntu-latest) (push) Has been cancelled
CMake / build (cmake, clang, -G Ninja, clang++, ubuntu-latest-clang-cmake-ninja, ubuntu-latest) (push) Has been cancelled
CMake / build (cmake, gcc, , g++, ubuntu-latest-gcc-cmake, ubuntu-latest) (push) Has been cancelled

This commit is contained in:
Harish Mahendrakar 2026-03-07 20:24:20 -08:00
parent 4740ca60b9
commit b77a7babd3
3 changed files with 6 additions and 27 deletions

View file

@ -42,10 +42,6 @@ protected:
}
template <typename FuncPtr> void RunTest(FuncPtr func_ptr) {
if (ref_func_selector == nullptr || tst_func_selector == nullptr) {
GTEST_SKIP() << "Function selector not available";
}
std::mt19937 rng(0);
std::uniform_int_distribution<int16_t> coeff_dist(-32768, 32767);
std::uniform_int_distribution<uint8_t> pixel_dist(0, 255);

View file

@ -74,18 +74,10 @@ protected:
}
template <typename FuncPtr> void RunTest(FuncPtr func_ptr) {
if (ref && ref->*func_ptr) {
(ref->*func_ptr)(src_buf.data(), tmp_buf.data(), dst_buf_ref.data(),
src_strd, dst_strd, 0, 0);
} else {
GTEST_SKIP() << "Reference function not available";
}
if (tst && tst->*func_ptr) {
(tst->*func_ptr)(src_buf.data(), tmp_buf.data(), dst_buf_tst.data(),
src_strd, dst_strd, 0, 0);
} else {
GTEST_SKIP() << "Test function not available";
}
(ref->*func_ptr)(src_buf.data(), tmp_buf.data(), dst_buf_ref.data(),
src_strd, dst_strd, 0, 0);
(tst->*func_ptr)(src_buf.data(), tmp_buf.data(), dst_buf_tst.data(),
src_strd, dst_strd, 0, 0);
ASSERT_NO_FATAL_FAILURE(compare_output<WORD16>(
dst_buf_ref, dst_buf_tst, trans_size, trans_size, dst_strd));

View file

@ -79,17 +79,8 @@ protected:
}
template <typename FuncPtr> void RunTest(FuncPtr func_ptr) {
if (ref && ref->*func_ptr) {
(ref->*func_ptr)(pu1_ref, src_strd, pu1_dst_ref, dst_strd, nt, mode);
} else {
GTEST_SKIP() << "Reference function not available";
}
if (tst && tst->*func_ptr) {
(tst->*func_ptr)(pu1_ref, src_strd, pu1_dst_tst, dst_strd, nt, mode);
} else {
GTEST_SKIP() << "Test function not available";
}
(ref->*func_ptr)(pu1_ref, src_strd, pu1_dst_ref, dst_strd, nt, mode);
(tst->*func_ptr)(pu1_ref, src_strd, pu1_dst_tst, dst_strd, nt, mode);
ASSERT_NO_FATAL_FAILURE(
compare_output<UWORD8>(dst_buf_ref, dst_buf_tst, nt, nt, dst_strd));
}