Harish Mahendrakar
31b397c813
Added an out of bound check on u4_num_bufs in input argument am: aa11ab9fdb am: 50ec420228 am: 0514a1ebfb am: fa8bb9d89c am: 96228ba3b9 am: 4a6a743d40 am: 4ed04c7bb1 am: b9027e8cc1
...
am: 859498bb08
2017-09-11 22:39:38 +00:00
Hamsalekha S
1d6b06a73a
Decoder: Conceal picture only if valid picture buffer is obtained. am: 5df744afde am: 7f78e3aa9a am: 8810e9db7f am: 1ab3e51baf am: 32c369cc3f am: fd327a47fb am: b10090d47a
...
am: 2825c578d3
2017-09-11 22:39:14 +00:00
Harish Mahendrakar
4a6a743d40
Added an out of bound check on u4_num_bufs in input argument am: aa11ab9fdb am: 50ec420228 am: 0514a1ebfb am: fa8bb9d89c
...
am: 96228ba3b9
2017-09-11 22:30:10 +00:00
Hamsalekha S
32c369cc3f
Decoder: Conceal picture only if valid picture buffer is obtained. am: 5df744afde am: 7f78e3aa9a am: 8810e9db7f
...
am: 1ab3e51baf
2017-09-11 22:28:11 +00:00
Harish Mahendrakar
50ec420228
Added an out of bound check on u4_num_bufs in input argument
...
am: aa11ab9fdb
2017-09-11 22:22:40 +00:00
Hamsalekha S
5df744afde
Decoder: Conceal picture only if valid picture buffer is obtained.
...
If all the slices in the current pic were invalid, then
the decoder would not have received a valid picture buffer
in the current call. In such cases there is no need to conceal or
deblock the picture.
Bug: 62896384
Test: run ASAN-enabled PoC before/after the patch
Change-Id: I3cf6e871592826f93b0dcd2b06fff80677bc8338
2017-08-18 20:45:17 +00:00
Harish Mahendrakar
aa11ab9fdb
Added an out of bound check on u4_num_bufs in input argument
...
ps_dec_ip->s_out_buffer.u4_num_bufs was missing out of bound checks
Bug: 62688399
Change-Id: Ic5e5c002d29fcb18064550d5a5f9289bb68b448e
2017-08-10 10:15:16 -07:00
Hamsalekha S
2e10678938
Added error check for output buffer size. am: 3f6c941de5 am: f0d2caa214 am: 9a6312ec9f am: 83c397d1ab am: 462316f8d2 am: 564bdc7609 am: 3aa85a9cc5 am: 873d325720
...
am: 08d268a942
2017-06-19 20:49:53 +00:00
Hamsalekha S
564bdc7609
Added error check for output buffer size. am: 3f6c941de5 am: f0d2caa214 am: 9a6312ec9f am: 83c397d1ab
...
am: 462316f8d2
2017-06-19 20:26:20 +00:00
Hamsalekha S
f0d2caa214
Added error check for output buffer size.
...
am: 3f6c941de5
2017-06-19 20:02:48 +00:00
Hamsalekha S
3f6c941de5
Added error check for output buffer size.
...
The output buffer size given by the application, needs to be checked
in every process call. This is required in the case of resolution
change.
Bug: 36006815
Test: avcdec -i poc.bin
Change-Id: I16a92cdad23eb7b1e12c1a67c1b2599204f29249
2017-06-16 17:41:23 -07:00
Marco Nelissen
36ffbf2beb
Merge "Initializing reference list for every P/B slice." into mnc-dev am: 3477b8e0d7 am: d98f1cf41b am: 18c5ca6984 am: 3cc8a48116 am: 93767dc556 am: 900303e2b0 am: 610062c062 am: 12d32dedae
...
am: 3b7dde2b72
2017-06-06 21:09:49 +00:00
Marco Nelissen
900303e2b0
Merge "Initializing reference list for every P/B slice." into mnc-dev am: 3477b8e0d7 am: d98f1cf41b am: 18c5ca6984 am: 3cc8a48116
...
am: 93767dc556
2017-06-06 20:50:48 +00:00
Marco Nelissen
d98f1cf41b
Merge "Initializing reference list for every P/B slice." into mnc-dev
...
am: 3477b8e0d7
2017-06-06 20:27:41 +00:00
Marco Nelissen
3477b8e0d7
Merge "Initializing reference list for every P/B slice." into mnc-dev
2017-06-06 20:14:42 +00:00
Hamsalekha S
a7b1d1c722
Merge "Fix resolution change within a decode call." into mnc-dev am: 7fc42b801c am: 252ca18add am: 4c6288e861 am: 90fc697c82 am: 8b3d043280 am: d603f906d2 am: e1b496babb am: 85b8159cf0
...
am: 6edcc25a5a
2017-06-06 18:30:46 +00:00
Hamsalekha S
d603f906d2
Merge "Fix resolution change within a decode call." into mnc-dev am: 7fc42b801c am: 252ca18add am: 4c6288e861 am: 90fc697c82
...
am: 8b3d043280
2017-06-06 18:05:00 +00:00
Hamsalekha S
252ca18add
Merge "Fix resolution change within a decode call." into mnc-dev
...
am: 7fc42b801c
2017-06-06 17:39:59 +00:00
TreeHugger Robot
7fc42b801c
Merge "Fix resolution change within a decode call." into mnc-dev
2017-06-06 17:32:41 +00:00
Hamsalekha S
fe18375850
Fix resolution change within a decode call.
...
If resolution changes within a decode call,due to multiple
sps, the decoder hangs as the the application will
give the same data again in the next decode call. This
results in a hang. Fixed this by flaging an error,
when sps/resoultion changes within a process call.
Bug: 38487564
Test: ran POC on patched O-based system w/o hanging
Change-Id: I30095b2e8bf573c1a58a316a23b1a5e6a4af589b
2017-06-05 13:28:44 -07:00
TreeHugger Robot
0a91df5eca
Merge "DO NOT MERGE Decoder: Fixed allocation size of pred info buffer" into mnc-dev
2017-06-02 18:40:21 +00:00
Hamsalekha S
f9d3f9af8f
Initializing reference list for every P/B slice.
...
Reference list needs to be initialized for every P/B
slice, to ensure colocated picture always points to a
valid picture buffer, even in the case of error.
Bug: 36279112
Change-Id: I051d7e725b0af209cc7bb333db8da3518adf78a0
2017-06-02 10:22:52 -07:00
Marco Nelissen
70593599f5
Merge "Decoder: Fix allocation for Mbaff weight matrix" into mnc-dr-dev am: db8f1ae73f am: dcbf996666 am: 8b4c87943a am: 672cb37cc6 am: ad69241f3a am: 7ba9ed2338 am: fed8ee727b
...
am: 5ed090d7d8
2017-05-16 15:49:53 +00:00
Marco Nelissen
ad69241f3a
Merge "Decoder: Fix allocation for Mbaff weight matrix" into mnc-dr-dev am: db8f1ae73f am: dcbf996666 am: 8b4c87943a
...
am: 672cb37cc6
2017-05-16 15:36:52 +00:00
Marco Nelissen
db8f1ae73f
Merge "Decoder: Fix allocation for Mbaff weight matrix" into mnc-dr-dev
2017-05-16 15:22:17 +00:00
Hamsalekha S
c0994c1fea
Merge "Decoder: Fixed flag u1_top_bottom_decoded." into mnc-dev am: cc07eaa5d2 am: 9a5c62841e am: 514d08016a am: 4dd1490ec9 am: 122d0942a8 am: 917c7eee1c am: d189b84641 am: 9e191ce3a6
...
am: ae093b98bc
2017-05-12 23:10:02 +00:00
Hamsalekha S
917c7eee1c
Merge "Decoder: Fixed flag u1_top_bottom_decoded." into mnc-dev am: cc07eaa5d2 am: 9a5c62841e am: 514d08016a am: 4dd1490ec9
...
am: 122d0942a8
2017-05-12 23:02:32 +00:00
Hamsalekha S
9a5c62841e
Merge "Decoder: Fixed flag u1_top_bottom_decoded." into mnc-dev
...
am: cc07eaa5d2
2017-05-12 22:51:00 +00:00
Hamsalekha S
07db35ad5a
Decoder: Fix allocation for Mbaff weight matrix
...
Increased the allocation size for Mbaff weight
matrix buffer
Bug: 36996978
Change-Id: I21cf2cb1010abdc6346f743f5237ae1730c4bf41
2017-05-12 14:11:10 -07:00
Hamsalekha S
7703822731
Decoder: Fixed flag u1_top_bottom_decoded.
...
Fixed initialization of flag u1_top_bottom_decoded
in decoder context. This flag indicates if top
field and botton field is decoded.
Bug: 36993291
Test: avcdec --input poc.h264 --output /dev/null
Change-Id: I9f8a2620683abd8b15e4780d76d4849394710716
2017-05-12 20:14:46 +00:00
Hamsalekha S
6a5cb80068
DO NOT MERGE Decoder: Fixed allocation size of pred info buffer
...
Buffer allocation size for pred info was increased
in the case number reference frames equal to 1.
Bug: 36998372
Change-Id: I1f84a16703422109d40bed8436f35d0c2069c088
2017-05-11 15:09:57 -07:00
Hamsalekha S
d0ab5b06d7
Bug fix for flush without valid frames
...
We now return fail and get out of flush mode to accept bitstream in the next call.
Bug: 35585952
Test: test case does not hang
Change-Id: Id22cc98d4a47714475a67918990a181a805c4c9f
2017-02-21 12:18:44 -08:00
Harish Mahendrakar
b1bbfa5320
Decoder: Fixed initialization of first_slice_in_pic am: 0b23c81c3d am: 16fa990ce1 am: ab79eb3973 am: a37d120eb2 am: c011eeade7 am: 94e17dc822 am: 9117d918dd
...
am: f837a7796b
2017-02-14 17:18:39 +00:00
Harish Mahendrakar
20c2cfbc12
Decoder: Moved end of pic processing to end of decode call am: 494561291a am: ba7f9e2aed am: 26bb8b98ee am: 89fa016b5f am: df2fa01c9e am: 7944003371 am: fd5c8e352a
...
am: 9432beb534
2017-02-14 17:16:16 +00:00
Harish Mahendrakar
94e17dc822
Decoder: Fixed initialization of first_slice_in_pic am: 0b23c81c3d am: 16fa990ce1 am: ab79eb3973 am: a37d120eb2
...
am: c011eeade7
2017-02-14 17:11:38 +00:00
Harish Mahendrakar
7944003371
Decoder: Moved end of pic processing to end of decode call am: 494561291a am: ba7f9e2aed am: 26bb8b98ee am: 89fa016b5f
...
am: df2fa01c9e
2017-02-14 17:08:45 +00:00
Harish Mahendrakar
16fa990ce1
Decoder: Fixed initialization of first_slice_in_pic
...
am: 0b23c81c3d
2017-02-14 17:03:06 +00:00
Harish Mahendrakar
ba7f9e2aed
Decoder: Moved end of pic processing to end of decode call
...
am: 494561291a
2017-02-14 17:00:16 +00:00
Harish Mahendrakar
0b23c81c3d
Decoder: Fixed initialization of first_slice_in_pic
...
To handle some errors, first_slice_in_pic was being set to 2.
This is now cleaned up and first_slice_in_pic is set to 1 only once per pic.
This will ensure picture level initializations are done only once even in case
of error clips
Bug: 33717589
Bug: 33551775
Bug: 33716442
Bug: 33677995
Change-Id: If341436b3cbaa724017eedddd88c2e6fac36d8ba
2017-02-14 16:59:09 +00:00
Harish Mahendrakar
494561291a
Decoder: Moved end of pic processing to end of decode call
...
ih264d_end_of_pic() was called after parsing slice of a new picture.
This is now being done at the end of decode of the current picture.
decode_gaps_in_frame_num which needs frame_num of new slice is now
done after decoding frame_num in new slice.
This helps in handling errors in picaff streams with gaps in frames
Bug: 33588051
Bug: 33641588
Bug: 34097231
Change-Id: I1a26e611aaa2c19e2043e05a210849bd21b22220
2017-02-14 16:58:07 +00:00
Harish Mahendrakar
1f0ab0b089
DO NOT MERGE: Decoder: Fixes an out of bound write in bitstream buffer
...
[this is for mnc-dev only, not any other mnc-*-dev flavors;
there is a different patch for mnc-dr-dev, nyc-* and going forward]
After emulation prevention, data is written as an int,
so at least 3 additional bytes should be available.
And since bitstream functions read 8 bytes ahead, 8 extra bytes
should be available in the bitstream buffer.
Bug: 33934721
Test: Ittiam testing, POC in the bug no longer fails
Change-Id: I444ec6f85d01b0bade9f827e15c4b476779d6c69
2017-02-13 14:44:11 -08:00
Harish Mahendrakar
d24b4a2fca
Decoder: Fixes an out of bound write in bitstream buffer am: 33ef7de9dd am: 0aab4958fb am: 9f72b6eca1 am: 73a3e320d8 am: 89377f2acf am: 9801d7e8d5
...
am: 109509aeb0
2017-02-13 18:59:47 +00:00
Harish Mahendrakar
89377f2acf
Decoder: Fixes an out of bound write in bitstream buffer am: 33ef7de9dd am: 0aab4958fb am: 9f72b6eca1
...
am: 73a3e320d8
2017-02-13 18:52:16 +00:00
Harish Mahendrakar
33ef7de9dd
Decoder: Fixes an out of bound write in bitstream buffer
...
[for mnc-dr-dev and later; mnc-dev gets a different patch]
After emulation prevention, data is written as an int,
so at least 3 additional bytes should be available.
And since bitstream functions read 8 bytes ahead, 8 extra bytes
should be available in the bitstream buffer.
Bug: 33934721
Change-Id: I444ec6f85d01b0bade9f827e15c4b476779d6c69
2017-01-19 09:17:00 -08:00
Marco Nelissen
d5424f66e3
Merge "DO NOT MERGE Decoder: Increase memory allocation for weights & offsets for interlaced clips" into mnc-dev
2017-01-18 18:42:47 +00:00
Harish Mahendrakar
4b2c277d9c
Decoder: Increase memory allocation for weights & offsets for interlaced clips am: bee9b9a54b am: bfc735cf17 am: 87c2d690fa am: 826159785f am: 3f1af4a90c am: 1806c2e12b
...
am: e4acdfb8c3
2017-01-18 17:19:47 +00:00
Harish Mahendrakar
3f1af4a90c
Decoder: Increase memory allocation for weights & offsets for interlaced clips am: bee9b9a54b am: bfc735cf17 am: 87c2d690fa
...
am: 826159785f
2017-01-18 16:59:45 +00:00
Harish Mahendrakar
bfc735cf17
Decoder: Increase memory allocation for weights & offsets for interlaced clips
...
am: bee9b9a54b
2017-01-18 16:41:13 +00:00
Marco Nelissen
696b6f666c
Merge "Decoder: Increase memory allocation for weights & offsets for interlaced clips" into mnc-dr-dev
2017-01-18 16:27:26 +00:00
Harish Mahendrakar
3101a6aa5a
Decoder: Fixed DoS in header decode when no PPS is present am: 2cd2f7a335 am: cec6503a20 am: 031a3fdbba am: 5a44d81d8c am: 60566cca95 am: e951e02347 am: a89050b3f2
...
am: b0dd5208aa
2017-01-18 00:43:15 +00:00
