Isha Kulkarni
34769a5b08
Decoder: Fix Integer Sanitizer Issues
...
Bug: 118445723
Test: vendor
Change-Id: I719898beb93ca5d20d9822f685ac6d4920252cdf
2019-03-28 14:40:40 -07:00
Isha Kulkarni
43dc60e81e
Decoder: Fix Integer Sanitizer Issues in ih264d_parse_cavlc
...
Bug:118445723
Test: vendor
Change-Id: I71b3c0f548b57c51c80de0bd4c640f56b2f31a55
2019-03-28 14:40:34 -07:00
Isha Shrikant Kulkarni
96f7193ba0
Decoder: Fix integer sanitizer issues in ih264d_parse_cabac
...
Bug: 118445723
Test: vendor
Change-Id: Icf98785fa474bd9c774ba4282b9c3d73360a69ea
2019-03-28 14:40:27 -07:00
Isha Shrikant Kulkarni
fc7139a53e
Decoder: Fix Integer Sanitizer issues in ih264d_process_bslice
...
Bug: 118445723
Test: vendor
Change-Id: Ib5d8f72be016330beafa6e7996976eeff1b23c39
2019-03-28 14:40:17 -07:00
Ray Essick
fbc772b17b
Merge "Decoder: Add null check for scaling matrix."
2019-02-12 21:54:59 +00:00
Sasha Smundak
51f1a220ec
Explicitly include log/log.h instead of cutils/log.h
...
Eliminates the warning.
Test: treehugger
Bug: 123758136
Change-Id: Id8940e053c90c45ba39cdd27a44cc83f130487b7
2019-02-01 10:45:14 -08:00
S Hamsalekha
f28de0366c
Decoder: Add null check for scaling matrix.
...
Also void->word32 return type so failure can be signaled to caller.
Bug: 115743419
Test: vendor + poc
Change-Id: I0a07ac11255c2c672803aab7085824c417bde282
2019-01-08 11:37:37 -08:00
Harish Mahendrakar
b13124444c
[automerger] decoder: Signal IVD_RES_CHANGED error for change in crop params am: 442a01bf37 am: 1d7d7f9bf6 am: acacf063c2 am: f33c02ed73 am: c09d3f99ab am: 145ae0d049 am: 4402b34a4f am: 7a6b55da22 am: 48900d4e51
...
am: 2e5273847c
2018-11-27 12:23:55 -08:00
Harish Mahendrakar
7a6b55da22
[automerger] decoder: Signal IVD_RES_CHANGED error for change in crop params am: 442a01bf37 am: 1d7d7f9bf6 am: acacf063c2 am: f33c02ed73 am: c09d3f99ab am: 145ae0d049
...
am: 4402b34a4f
2018-11-27 12:10:36 -08:00
Android Build Merger (Role)
145ae0d049
[automerger] decoder: Signal IVD_RES_CHANGED error for change in crop params am: 442a01bf37 am: 1d7d7f9bf6 am: acacf063c2 am: f33c02ed73 am: c09d3f99ab
...
Change-Id: I0dda0584bd0bf112fade0827b0460a82f8c14437
2018-11-10 18:16:37 +00:00
Android Build Merger (Role)
1d7d7f9bf6
[automerger] decoder: Signal IVD_RES_CHANGED error for change in crop params am: 442a01bf37
...
Change-Id: I05d6d693a8e8d18cd3cf74d95271efd8a339e06f
2018-11-10 18:16:32 +00:00
Harish Mahendrakar
442a01bf37
decoder: Signal IVD_RES_CHANGED error for change in crop params
...
IVD_RES_CHANGED was not signaled when crop parameters changed, i.e.
display dimensions changed without change in decode dimensions.
In such cases, if output buffer was allocated as per the current
dimension being decoded, without IVD_RES_CHANGED signalled, there can be
an OOB write if the new buffer is smaller than the frame being returned
as output
Bug: 118399205
Test: vendor
Change-Id: Ia750a99cda08a3254a6f8ea8b55d07e655b34d05
2018-11-10 10:16:06 -08:00
Thomala Srinivas
2286dbb91f
Decoder: Initialize some array and structure to zero
...
In intra_pred_ref_filtering function, initialize the values
of array au1_ngbr_pels to zero and in ih264d_parse_decode_slice
function, initialize the values of struct s_tmp_poc to zero.
Bug: 111762686
Test: vendor
Change-Id: Iac67f5e7d24f821627de64c8570f4be648c296c8
2018-11-01 14:35:05 -07:00
Rakesh Kumar
590ff56ba5
Decoder: Memset allocated dynamic and static buffer to zero
...
Bug: 111407302
Bug: 111208713
Bug: 111128067
Bug: 111762807
Bug: 111762100
Bug: 111761624
Bug: 112328051
Bug: 112329563
Bug: 112326322
Bug: 112205113
Bug: 112204376
Test: manual
Change-Id: I35e6069a26ee5ef4c0fff111df255a5eddff78ae
2018-08-23 17:27:22 -07:00
Rakesh Kumar
837aefa3a2
Fix Compiler warnings
...
Intrinsic _mm_set_epi8 require char input, converting everything to char.
Including log.h from android library instead of cutils.
Bug: 112316276
Test: before/after object comparison for no diff in generated code.
Change-Id: I82b8c48494619b64465eda2476c7c903652c6066
2018-08-10 15:17:08 -07:00
TreeHugger Robot
2c566a8712
Merge "Fix signed integer overflow in prev_max_display_seq"
2018-06-20 22:14:25 +00:00
Android Build Merger (Role)
e6d4971fdb
[automerger] Bug fix for flush without valid frames am: 10c1176f1b am: 54fe392964 am: 6261ed297b am: 051d4fb2dc am: 1863b7cc03
...
Change-Id: Ibd65acb3016732e53b25cb4aee2ec58076f6340f
2018-05-21 23:36:25 +00:00
Android Build Merger (Role)
54fe392964
[automerger] Bug fix for flush without valid frames am: 10c1176f1b
...
Change-Id: Ie26a4e3f41ab437f9d41bddb0a1166274fc3a261
2018-05-21 23:36:19 +00:00
Hamsalekha S
10c1176f1b
Bug fix for flush without valid frames
...
We now return fail and get out of flush mode to accept bitstream in the next call.
Bug: 35585952
Bug: 63521984
Test: test case does not hang
Change-Id: Id22cc98d4a47714475a67918990a181a805c4c9f
2018-05-21 15:36:09 -07:00
Ritu Baldwa
0e4598c1c9
Decoder: Return error for invalid vui parameter
...
Parameter num_reorder_frames should be in the range of
zero to max_dec_frame_buffering, inclusive.
Bug: 73338792
Test: vendor
Change-Id: Ib7d428ea7ac9ad946d09968a8e89ce75bf076292
2018-04-19 10:38:25 -07:00
Ritu Baldwa
49afc8f344
Fix signed integer overflow in prev_max_display_seq
...
Prev_max_display_seq accumulates max_poc, which results in integer overflow.
Resetting it to zero whenever overflow occurs.
Bug: 73337834
Test: boot
Change-Id: Ia3f6d30f1a6e7fac05d073e30e38ce2ca4e4f52a
2018-04-16 10:08:46 -07:00
Ritu Baldwa
777146501f
[automerger] Decoder: Modify setting short term reference field flag am: 47cc04b40c am: 1991ec77e7 am: c18d0ab03a am: 8f05a87c39 am: ce46d15877 am: 8781a2aa9b am: 9cb460fb64 am: bae32f4c46 am: b8dd278100 am: 2dfd8c6d91
...
am: e44fbd93cb
2018-04-05 18:22:54 -07:00
Android Build Merger (Role)
2dfd8c6d91
[automerger] Decoder: Modify setting short term reference field flag am: 47cc04b40c am: 1991ec77e7 am: c18d0ab03a am: 8f05a87c39 am: ce46d15877 am: 8781a2aa9b am: 9cb460fb64 am: bae32f4c46 am: b8dd278100
...
Change-Id: I9d0d825dc092c033eea729ea51eb8915c2502a68
2018-03-28 17:26:02 +00:00
Android Build Merger (Role)
8781a2aa9b
[automerger] Decoder: Modify setting short term reference field flag am: 47cc04b40c am: 1991ec77e7 am: c18d0ab03a am: 8f05a87c39 am: ce46d15877
...
Change-Id: I9946acaead19bd15f5953a791429e12c5a5cf9df
2018-03-28 17:25:57 +00:00
Android Build Merger (Role)
1991ec77e7
[automerger] Decoder: Modify setting short term reference field flag am: 47cc04b40c
...
Change-Id: If09f9c6ab67bb396ed22c71175ee7de8f3c4a040
2018-03-28 17:25:51 +00:00
Ritu Baldwa
47cc04b40c
Decoder: Modify setting short term reference field flag
...
Do not mark bottom field as short term in case of error.
Bug: 73553038
Bug: 73552574
Bug: 73552999
Test: poc before/after
Change-Id: I8576861af36996a361a81f48ba9b251f0ae4e660
2018-03-28 10:24:26 -07:00
Android Build Merger (Role)
57cd27cc9b
Merge changes from topic "am-8231d92f-aea1-4f7d-b84c-789126fb6fa2" into oc-dev am: 3fffe3c300
...
am: 5759ea0b59
2018-01-31 22:38:58 +00:00
TreeHugger Robot
78f1152a7a
Merge "Decoder: Fixed reset values in parse sps." into mnc-dev
2018-01-31 21:10:18 +00:00
TreeHugger Robot
3fffe3c300
Merge changes from topic "am-8231d92f-aea1-4f7d-b84c-789126fb6fa2" into oc-dev
...
* changes:
[automerger] Decoder: Fixed reset values in parse sps. am: 9c32ad7126731580450e2b842fb541d9a7fe1268552788326b33a0d86ce4773108fa3f42e8b285618534b9e55b9c32ad7126731580450e2b842fb541d9a7fe1268552788326b33a0d86ce4773108fa3f42e8b285619c32ad7126731580450e2b842fb541d9a7fe1268552788326b33a0d86ce4773108fa3f9c32ad7126731580450e2b842fb541d9a7fe1268552788326b33a0d86ce49c32ad7126731580450e2b842fb541d9a7fe1268552788326b9c32ad7126731580450e2b842fb541d9a7fe12689c32ad7126731580450e2b842fb5419c32ad7126731580450e9c32ad7126
2018-01-31 21:10:18 +00:00
TreeHugger Robot
b5b90f0549
Merge changes from topic "am-8231d92f-aea1-4f7d-b84c-789126fb6fa2" into nyc-dr1-dev
...
* changes:
[automerger] Decoder: Fixed reset values in parse sps. am: 9c32ad7126731580450e2b842fb541d9a7fe1268552788326b9c32ad7126731580450e2b842fb541d9a7fe12689c32ad7126731580450e2b842fb5419c32ad7126731580450e9c32ad7126
2018-01-31 21:10:18 +00:00
TreeHugger Robot
ef5bc92259
Merge changes from topic "am-8231d92f-aea1-4f7d-b84c-789126fb6fa2" into mnc-dr-dev
...
* changes:
[automerger] Decoder: Fixed reset values in parse sps. am: 9c32ad7126
2018-01-31 21:10:18 +00:00
Android Build Merger (Role)
ab81339c93
[automerger] Decoder: Set prev slice type for I slice. am: aecdfd1aff am: 65db3cc9a3 am: 93e93983e1 am: 0f9ee33f0a am: 9d76581d46 am: 475e185a91 am: 16d1d4faa8 am: 08e373f4fe am: aa395054d5 am: 3c729938cc
...
am: c901efd3fd
2018-01-31 18:30:22 +00:00
Android Build Merger (Role)
3c729938cc
[automerger] Decoder: Set prev slice type for I slice. am: aecdfd1aff am: 65db3cc9a3 am: 93e93983e1 am: 0f9ee33f0a am: 9d76581d46 am: 475e185a91 am: 16d1d4faa8 am: 08e373f4fe am: aa395054d5
...
Change-Id: If3af4fa8e6c5a18cda2135e90156c3441e738f60
2018-01-29 23:19:22 +00:00
Android Build Merger (Role)
475e185a91
[automerger] Decoder: Set prev slice type for I slice. am: aecdfd1aff am: 65db3cc9a3 am: 93e93983e1 am: 0f9ee33f0a am: 9d76581d46
...
Change-Id: I6f12497fc967f6537e2e8882cd735cdbeedc9b35
2018-01-29 23:19:15 +00:00
Android Build Merger (Role)
65db3cc9a3
[automerger] Decoder: Set prev slice type for I slice. am: aecdfd1aff
...
Change-Id: I5397b5635a304040fa8bcbd2999be4b07fcbdc0d
2018-01-29 23:19:09 +00:00
Ritu Baldwa
aecdfd1aff
Decoder: Set prev slice type for I slice.
...
Fixed initialization of u1_pr_sl_type for I slice.
Bug: 70897454
Test: ran PoC before/after patch
Change-Id: I0c37317513b72236be98c2b25482a67bf2b56052
2018-01-29 15:17:19 -08:00
Android Build Merger (Role)
891d4796e1
[automerger] Decoder: Fixed reset values in parse sps. am: 9c32ad7126 am: 731580450e am: 2b842fb541 am: d9a7fe1268 am: 552788326b am: 33a0d86ce4 am: 773108fa3f am: 42e8b28561 am: 8534b9e55b
...
Change-Id: I0216f20b9226c6a85fc9cbe257b2ed341aacb86b
2018-01-18 18:44:29 +00:00
Android Build Merger (Role)
33a0d86ce4
[automerger] Decoder: Fixed reset values in parse sps. am: 9c32ad7126 am: 731580450e am: 2b842fb541 am: d9a7fe1268 am: 552788326b
...
Change-Id: Ib54b87663a62ba48b3763fcef8092d1133f24b9b
2018-01-18 18:44:23 +00:00
Android Build Merger (Role)
731580450e
[automerger] Decoder: Fixed reset values in parse sps. am: 9c32ad7126
...
Change-Id: Ia8766fd9f4b9a2cb5f7bb13e221d8c0f9b366d66
2018-01-18 18:44:16 +00:00
Ritu Baldwa
9c32ad7126
Decoder: Fixed reset values in parse sps.
...
Memset to zero whenever new sps occurs.
Bug: 70897394
Test: manual
Change-Id: I5936fd55265ff8ad2b275a72b175cdb540bb7933
2018-01-18 10:43:26 -08:00
Ray Essick
25e3974121
Merge "Decoder: Adding Error Check for Output Buffer Size in Shared Display Mode." into mnc-dev am: afc729db25 am: 1fb89d8488 am: 56f836a29c am: 33675f68d6 am: 547804d647 am: 7adc4d57f1 am: cfe44b34c0 am: 17b987beec am: bce27b7e66 am: e31fa45761
...
am: d1b1b3df78
2018-01-08 22:53:25 +00:00
Ray Essick
e31fa45761
Merge "Decoder: Adding Error Check for Output Buffer Size in Shared Display Mode." into mnc-dev am: afc729db25 am: 1fb89d8488 am: 56f836a29c am: 33675f68d6 am: 547804d647 am: 7adc4d57f1 am: cfe44b34c0 am: 17b987beec
...
am: bce27b7e66
2018-01-08 22:49:54 +00:00
Ray Essick
7adc4d57f1
Merge "Decoder: Adding Error Check for Output Buffer Size in Shared Display Mode." into mnc-dev am: afc729db25 am: 1fb89d8488 am: 56f836a29c am: 33675f68d6
...
am: 547804d647
2018-01-08 22:41:22 +00:00
Ray Essick
1fb89d8488
Merge "Decoder: Adding Error Check for Output Buffer Size in Shared Display Mode." into mnc-dev
...
am: afc729db25
2018-01-08 22:27:38 +00:00
Ray Essick
afc729db25
Merge "Decoder: Adding Error Check for Output Buffer Size in Shared Display Mode." into mnc-dev
2018-01-08 22:16:23 +00:00
Ritu Baldwa
6b66cac7a8
Decoder: Fixed memory overflow in shared display mode. am: c3b026a87d am: 0183e8df10 am: 53b26e4caa am: 64df5835a4 am: f55fa2495d am: 01f26b3531 am: 8467cf1390 am: bc664e6fa7 am: 6c5f746f25 am: f8f4968473
...
am: 134620a49b
2018-01-08 20:24:46 +00:00
Ritu Baldwa
f8f4968473
Decoder: Fixed memory overflow in shared display mode. am: c3b026a87d am: 0183e8df10 am: 53b26e4caa am: 64df5835a4 am: f55fa2495d am: 01f26b3531 am: 8467cf1390 am: bc664e6fa7
...
am: 6c5f746f25
2018-01-08 20:18:41 +00:00
Ritu Baldwa
01f26b3531
Decoder: Fixed memory overflow in shared display mode. am: c3b026a87d am: 0183e8df10 am: 53b26e4caa am: 64df5835a4
...
am: f55fa2495d
2018-01-08 20:06:07 +00:00
Ritu Baldwa
0183e8df10
Decoder: Fixed memory overflow in shared display mode.
...
am: c3b026a87d
2018-01-08 19:56:05 +00:00
Ritu Baldwa
c3b026a87d
Decoder: Fixed memory overflow in shared display mode.
...
The factor multiplication should happen only at the source,
not at the destination.
Bug: 71375536
Test: manual
Change-Id: Ib5f00b87150a0533880346fac5464b0b1a802c36
2018-01-05 11:09:27 -08:00
