Hamsalekha S
34e66b4dc1
Merge "Decoder: Fixed hang in the case of dangling field" into mnc-dev am: 2f1ca945b1 am: 1b1e6d3ec9 am: 8ec4061310 am: 40d1b833d8 am: 73763b165e am: e9ec948685 am: 2411d507d4 am: 5795e09124 am: a55b5dd44f am: 359a2ba846 am: e127b146ff
...
am: f6058dbfff
Change-Id: I0e33ccc7a71c1148190a3798776a0a6e0b1001aa
2017-10-03 17:59:14 +00:00
Hamsalekha S
359a2ba846
Merge "Decoder: Fixed hang in the case of dangling field" into mnc-dev am: 2f1ca945b1 am: 1b1e6d3ec9 am: 8ec4061310 am: 40d1b833d8 am: 73763b165e am: e9ec948685 am: 2411d507d4 am: 5795e09124
...
am: a55b5dd44f
Change-Id: I4393ad6185c54c0cf6cd8534e03cbca1d81f5af5
2017-10-03 17:52:12 +00:00
Hamsalekha S
e9ec948685
Merge "Decoder: Fixed hang in the case of dangling field" into mnc-dev am: 2f1ca945b1 am: 1b1e6d3ec9 am: 8ec4061310 am: 40d1b833d8
...
am: 73763b165e
Change-Id: Ia96b46ff5c254047eeff4dad62a0429a6d75ddf9
2017-10-03 17:43:45 +00:00
Hamsalekha S
1b1e6d3ec9
Merge "Decoder: Fixed hang in the case of dangling field" into mnc-dev
...
am: 2f1ca945b1
Change-Id: I203d518ad9dc60ea41dfdc88c1903b47398246ba
2017-10-03 17:34:44 +00:00
TreeHugger Robot
2f1ca945b1
Merge "Decoder: Fixed hang in the case of dangling field" into mnc-dev
2017-10-03 17:29:09 +00:00
Ritu Baldwa
ed7a63fbcc
DO NOT MERGE Decoder: Increased memory allocation.
...
ps_dec->u1_recon_mb_grp is twice the width in case of mbaff,
increasing relevant allocations accordingly.
Increased allocation of intra-prediction buffer to
include padding.
Bug: 64964675
Test: POC from bug report
Change-Id: Ic4a6151bb12ac1122c228220b9150b2a372aae21
2017-09-29 11:49:50 -07:00
Hamsalekha S
252628cffb
Decoder: Fixed hang in the case of dangling field
...
The u1_top_bottom_decoded flag in the decoder context has been fixed
to be updated correctly in the case of dangling field
Bug: 63315932
Test: ran POC after patching
Change-Id: I8db4ebeb94fba735ba45f365c37e52a202ea84cd
2017-09-29 10:25:21 -07:00
Marco Nelissen
a2c59e3ab3
Merge "Decoder: Updated error check while parsing num_ref_idx_lx_active." into mnc-dev am: 224824ba17 am: 628056c0ed am: becbdb15b7 am: 2f85a749c5 am: bd6a74b45b am: 828dc44ed5 am: a1d4d39a61 am: b4f8a983ad am: d3ea876a4d am: 957708e9b1 am: 0c909b99f0
...
am: bd336ce65e
Change-Id: I0f46d2f751bac9110da556fc930f33cd834dd562
2017-09-14 01:25:11 +00:00
Marco Nelissen
957708e9b1
Merge "Decoder: Updated error check while parsing num_ref_idx_lx_active." into mnc-dev am: 224824ba17 am: 628056c0ed am: becbdb15b7 am: 2f85a749c5 am: bd6a74b45b am: 828dc44ed5 am: a1d4d39a61 am: b4f8a983ad
...
am: d3ea876a4d
Change-Id: I2c6eb56ae9a8e094c9c7513527e07e75a2e22c71
2017-09-13 23:21:34 +00:00
Marco Nelissen
828dc44ed5
Merge "Decoder: Updated error check while parsing num_ref_idx_lx_active." into mnc-dev am: 224824ba17 am: 628056c0ed am: becbdb15b7 am: 2f85a749c5
...
am: bd6a74b45b
Change-Id: Ia3024ff02b981807fc0437a9611de72c92ea8c7d
2017-09-13 20:06:27 +00:00
Marco Nelissen
628056c0ed
Merge "Decoder: Updated error check while parsing num_ref_idx_lx_active." into mnc-dev
...
am: 224824ba17
Change-Id: Id5366922a8312c3fc99f5dc42c64e4bfdf11795b
2017-09-13 05:51:32 +00:00
Marco Nelissen
224824ba17
Merge "Decoder: Updated error check while parsing num_ref_idx_lx_active." into mnc-dev
2017-09-13 05:00:15 +00:00
Hamsalekha S
2463d42f6f
Merge "Decoder: Corrected variable datatypes in ih264d_get_implicit_weights." into mnc-dev am: a2d8a1444d am: 8659d0e563 am: 0af8672874 am: 30468b264e am: dd338e085c am: dc56ebdb83 am: e42cbf31fd am: 0bd2cd5f1c am: 9dc4a57a87 am: 16b7ec0491
...
am: 305bac508f
Change-Id: Ibe60a4e8b1db28ddad94f7fb71cbe3fd7873b6a9
2017-09-12 01:25:06 +00:00
Hamsalekha S
16b7ec0491
Merge "Decoder: Corrected variable datatypes in ih264d_get_implicit_weights." into mnc-dev am: a2d8a1444d am: 8659d0e563 am: 0af8672874 am: 30468b264e am: dd338e085c am: dc56ebdb83 am: e42cbf31fd am: 0bd2cd5f1c
...
am: 9dc4a57a87
Change-Id: Ib073bbec0588fb1d985eda19e07f98b821b7393f
2017-09-12 00:51:53 +00:00
Hamsalekha S
dc56ebdb83
Merge "Decoder: Corrected variable datatypes in ih264d_get_implicit_weights." into mnc-dev am: a2d8a1444d am: 8659d0e563 am: 0af8672874 am: 30468b264e
...
am: dd338e085c
Change-Id: Ib77127995a96a95fcc67d1817af3dda211d6f10f
2017-09-12 00:24:23 +00:00
Hamsalekha S
8659d0e563
Merge "Decoder: Corrected variable datatypes in ih264d_get_implicit_weights." into mnc-dev
...
am: a2d8a1444d
Change-Id: I50d88e962f2435189cbb4720d8254729eb47829f
2017-09-12 00:14:49 +00:00
TreeHugger Robot
a2d8a1444d
Merge "Decoder: Corrected variable datatypes in ih264d_get_implicit_weights." into mnc-dev
2017-09-12 00:11:33 +00:00
Harish Mahendrakar
e5c2c33295
Added an out of bound check on u4_num_bufs in input argument am: aa11ab9fdb am: 50ec420228 am: 0514a1ebfb am: fa8bb9d89c am: 96228ba3b9 am: 4a6a743d40 am: 4ed04c7bb1 am: b9027e8cc1 am: 859498bb08 am: 31b397c813
...
am: 8564f06db6
Change-Id: I8e572678c2d456b7458793449cbf7e72e6b63b9b
2017-09-11 22:43:26 +00:00
Hamsalekha S
ba77e93be7
Decoder: Conceal picture only if valid picture buffer is obtained. am: 5df744afde am: 7f78e3aa9a am: 8810e9db7f am: 1ab3e51baf am: 32c369cc3f am: fd327a47fb am: b10090d47a am: 2825c578d3 am: 1d6b06a73a
...
am: 7f049a7472
Change-Id: I5a44be13778eb16c0300d13e5dc1c32d7e0c506a
2017-09-11 22:43:13 +00:00
Harish Mahendrakar
31b397c813
Added an out of bound check on u4_num_bufs in input argument am: aa11ab9fdb am: 50ec420228 am: 0514a1ebfb am: fa8bb9d89c am: 96228ba3b9 am: 4a6a743d40 am: 4ed04c7bb1 am: b9027e8cc1
...
am: 859498bb08
Change-Id: I364cdcdd56d88f411892723935683d16ffcd0321
2017-09-11 22:39:38 +00:00
Hamsalekha S
1d6b06a73a
Decoder: Conceal picture only if valid picture buffer is obtained. am: 5df744afde am: 7f78e3aa9a am: 8810e9db7f am: 1ab3e51baf am: 32c369cc3f am: fd327a47fb am: b10090d47a
...
am: 2825c578d3
Change-Id: I1bf0cb0c96c45b419c06bd9b1d202b1ff08193e4
2017-09-11 22:39:14 +00:00
Harish Mahendrakar
4a6a743d40
Added an out of bound check on u4_num_bufs in input argument am: aa11ab9fdb am: 50ec420228 am: 0514a1ebfb am: fa8bb9d89c
...
am: 96228ba3b9
Change-Id: Ic048f96697bdaedea3bbc0a8cf1acf78ed488e37
2017-09-11 22:30:10 +00:00
Hamsalekha S
32c369cc3f
Decoder: Conceal picture only if valid picture buffer is obtained. am: 5df744afde am: 7f78e3aa9a am: 8810e9db7f
...
am: 1ab3e51baf
Change-Id: I964f1bd1fc0d9534d6c9498864cc7831d13de449
2017-09-11 22:28:11 +00:00
Harish Mahendrakar
50ec420228
Added an out of bound check on u4_num_bufs in input argument
...
am: aa11ab9fdb
Change-Id: I7dd6739821da87a96072dae422416e8037332a4f
2017-09-11 22:22:40 +00:00
Ray Essick
dc9396971d
Merge "DO NOT MERGE: Decoder: Conceal picture only if valid picture buffer is obtained." into mnc-dev
2017-09-11 22:17:06 +00:00
Hamsalekha S
208c74d62a
Decoder: Updated error check while parsing num_ref_idx_lx_active.
...
Added an error check on the lower limit of u1_num_ref_idx_lx_active,
while parsing slice header. The minimum possible value is 1.
Bug: 64836894
Change-Id: I57056851fc135ed00f7a10af5c81eb560e9e12de
2017-09-11 20:16:47 +00:00
Hamsalekha S
3eb692de91
Decoder: Corrected variable datatypes in ih264d_get_implicit_weights.
...
The difference between two 32 signed numbers was getting assigned
to 16 bits, leading to a divide by zero arithmetic execption.
Modified variable names to match their datatypes.
Bug: 65122447
Change-Id: I45ade1945f10b4d7660bd09fb564e60fd29d40dc
2017-09-08 13:21:14 -07:00
Lajos Molnar
09c8cb1b30
support 4080 max dimension
...
4096 is 256 macroblocks which does not fit on 8-bits, and 8-bits
are used for some variables that contain the size.
Bug: 65438670
Change-Id: Id977303054841c458cbd21c1538a9035d178fbef
2017-09-08 12:42:40 -07:00
Ray Essick
45aa4ac86d
DO NOT MERGE: Decoder: Conceal picture only if valid picture buffer is obtained.
...
If all the slices in the current pic were invalid, then
the decoder would not have received a valid picture buffer
in the current call. In such cases there is no need to conceal or
deblock the picture.
Bug: 62896384
Test: run ASAN-enabled PoC before/after the patch
Change-Id: Ia7d979a78ae3f4fb443a1759c8e6cf8780565ad8
Merged-In: I3cf6e871592826f93b0dcd2b06fff80677bc8338
2017-09-06 23:46:21 +00:00
Lajos Molnar
8a7f15c3d4
support 4K max dimension
...
This is required for handling 4K thumbnails that may be rotated.
Bug: 64939294
Change-Id: Ia33d8e1ce7fb07b5ec6bf604d30cd8f75c3228ae
2017-08-24 19:07:58 -07:00
Hamsalekha S
5df744afde
Decoder: Conceal picture only if valid picture buffer is obtained.
...
If all the slices in the current pic were invalid, then
the decoder would not have received a valid picture buffer
in the current call. In such cases there is no need to conceal or
deblock the picture.
Bug: 62896384
Test: run ASAN-enabled PoC before/after the patch
Change-Id: I3cf6e871592826f93b0dcd2b06fff80677bc8338
2017-08-18 20:45:17 +00:00
Harish Mahendrakar
aa11ab9fdb
Added an out of bound check on u4_num_bufs in input argument
...
ps_dec_ip->s_out_buffer.u4_num_bufs was missing out of bound checks
Bug: 62688399
Change-Id: Ic5e5c002d29fcb18064550d5a5f9289bb68b448e
2017-08-10 10:15:16 -07:00
Hamsalekha S
f96761b52d
Decoder: Fixed allocation of pv_map_ref_idx_to_poc_buf. am: a925a6b539 am: bf8b7083e9 am: ebae2ef7bd am: d5ad4f8c04 am: 6f82dff7b9 am: 0716eeeb7f am: 0b64261f4c am: d2e5daaede am: 61ddc9e202 am: 6d73354309
...
am: 79b56d80d5
Change-Id: Ic7cfdc087bf9c3de52c5d6cf9a25dfe25db4a936
2017-07-15 01:16:34 +00:00
Hamsalekha S
61ddc9e202
Decoder: Fixed allocation of pv_map_ref_idx_to_poc_buf. am: a925a6b539 am: bf8b7083e9 am: ebae2ef7bd am: d5ad4f8c04 am: 6f82dff7b9 am: 0716eeeb7f am: 0b64261f4c
...
am: d2e5daaede
Change-Id: Ic1a04ff426ec654e28d142ced625011b7ff9fbe1
2017-07-15 01:04:04 +00:00
Hamsalekha S
6f82dff7b9
Decoder: Fixed allocation of pv_map_ref_idx_to_poc_buf. am: a925a6b539 am: bf8b7083e9 am: ebae2ef7bd
...
am: d5ad4f8c04
Change-Id: I8c096a96d86379e40d02c445e95044055b124d73
2017-07-15 00:48:02 +00:00
Hamsalekha S
a925a6b539
Decoder: Fixed allocation of pv_map_ref_idx_to_poc_buf.
...
Increased allocation to include reference list1 also by
default. In the case of error, we could get B_SLICES
even in BASE_PROFILE. The initialization in the
dec_slice_struct_t slice structure has also been
modified accordingly.
Test: run poc with and without this patch
Bug: 38496660
Change-Id: I3451d79bbcd9f0d7a80981a9897f877b7f0812bd
2017-07-13 17:49:14 +00:00
Ray Essick
707287f248
Merge "Decoder : Fix memory leak when sps changes."
2017-07-11 04:03:40 +00:00
Hamsalekha S
674fb1aa06
Decoder: Fixed overflow in refernce list creation. am: cbcd2846fa am: a54dcc6338 am: 136293c373 am: 28702336ea am: d4d96c6267 am: eaf6bed710 am: 400685c446 am: 4192026584
...
am: d00e2547c9
Change-Id: I2939be93a829b4ede24a1285fd337109e2f388d2
2017-07-10 19:25:26 +00:00
Hamsalekha S
eaf6bed710
Decoder: Fixed overflow in refernce list creation. am: cbcd2846fa am: a54dcc6338 am: 136293c373 am: 28702336ea
...
am: d4d96c6267
Change-Id: Ic9b4e1910349f0d110d286d0c7d013bf3f20e239
2017-07-10 19:06:53 +00:00
Hamsalekha S
a54dcc6338
Decoder: Fixed overflow in refernce list creation.
...
am: cbcd2846fa
Change-Id: Ic4d5c775bfeb8950f07145c9441130ea295bdfa5
2017-07-10 18:49:51 +00:00
Hamsalekha S
f15bb32866
Decoder : Fix memory leak when sps changes.
...
ih264d_allocate_dynamic_bufs is now called only once
after every ih264d_init_decoder call. This is possible
since we support only identical( all the critical
parameters will be same) sps in our sps array.
Signal resolution change when u1_frame_mbs_only_flag
in SPS changes.
Bug: 62897300
Test: compilation, boot
Change-Id: I0cf71fe9de72b5dadca2d1daf881d821786f94e3
2017-07-07 10:48:53 -07:00
Hamsalekha S
cbcd2846fa
Decoder: Fixed overflow in refernce list creation.
...
Since the maximum value of long term index is 255,
the loop control variable needs to be 32 bit.
Bug: 38448381
Test: ran POC before/after applying fix
Change-Id: Iae3ecff38d4a922bde10fde33f1cfcafd2ea2680
2017-07-07 10:34:44 -07:00
Hamsalekha S
f7de034890
Initialize DPB structures to valid values. am: b8d362561e am: 278ed70003 am: f178731344 am: ed0086bd3f am: aa22ca288d am: b2503ce9ad am: 2025670e41 am: 630d10abba
...
am: 8a712339cf
Change-Id: Iac74df1e352c4021aca883932c198cfc99714405
2017-06-26 22:16:03 +00:00
Hamsalekha S
b2503ce9ad
Initialize DPB structures to valid values. am: b8d362561e am: 278ed70003 am: f178731344 am: ed0086bd3f
...
am: aa22ca288d
Change-Id: I7de594095bbe168e230814fa4ba82b2422988e0d
2017-06-26 22:03:06 +00:00
Hamsalekha S
278ed70003
Initialize DPB structures to valid values.
...
am: b8d362561e
Change-Id: I6025560875e3234a3cc99d316e1ccd46109ef269
2017-06-26 21:40:11 +00:00
Hamsalekha S
b8d362561e
Initialize DPB structures to valid values.
...
When the first frame is a B frame, the colocated picture
will now point to the current frame.
Test: run poc with and without this patch
Bug: 38115076
Change-Id: I48a8f128740551d6a9252931dafcf8c629ecad0d
2017-06-20 20:34:06 +00:00
Hamsalekha S
2e10678938
Added error check for output buffer size. am: 3f6c941de5 am: f0d2caa214 am: 9a6312ec9f am: 83c397d1ab am: 462316f8d2 am: 564bdc7609 am: 3aa85a9cc5 am: 873d325720
...
am: 08d268a942
Change-Id: I04d24975487e9188d30ff1ebac6f76e563143ef4
2017-06-19 20:49:53 +00:00
Hamsalekha S
564bdc7609
Added error check for output buffer size. am: 3f6c941de5 am: f0d2caa214 am: 9a6312ec9f am: 83c397d1ab
...
am: 462316f8d2
Change-Id: Id9021bcb9534cd9b30063eb9be6de464014c67d7
2017-06-19 20:26:20 +00:00
Hamsalekha S
f0d2caa214
Added error check for output buffer size.
...
am: 3f6c941de5
Change-Id: I5b06314d7b3d0fb699160ba1326ecb31aedf3082
2017-06-19 20:02:48 +00:00
Hamsalekha S
3f6c941de5
Added error check for output buffer size.
...
The output buffer size given by the application, needs to be checked
in every process call. This is required in the case of resolution
change.
Bug: 36006815
Test: avcdec -i poc.bin
Change-Id: I16a92cdad23eb7b1e12c1a67c1b2599204f29249
2017-06-16 17:41:23 -07:00