From 8362f0939b3835b84e8971237288ce50d5fe268e Mon Sep 17 00:00:00 2001 From: Martin Storsjo Date: Thu, 27 Jan 2022 15:41:02 +0200 Subject: [PATCH] Set correct defaults for video signal flags in VUI When u1_video_signal_type_present_flag and u1_colour_description_present_flag were set, we did write all fields relating to video signal and color description into the VUI, even if all those fields were uninitialized (left at the default cleared zero, which for most fields are invalid/reserved value zero). Instead have these flags default to zero, making it clear that the VUI doesn't (yet) contain correctly set values for those fields. Bug: 240470605 Change-Id: I86628cff190c8a40e9c6fd12d3fc8e06419ece7c --- encoder/ih264e_api.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/encoder/ih264e_api.c b/encoder/ih264e_api.c index 1f69e3e..a01cf96 100644 --- a/encoder/ih264e_api.c +++ b/encoder/ih264e_api.c @@ -2938,8 +2938,8 @@ static WORD32 ih264e_set_default_params(cfg_params_t *ps_cfg) ps_cfg->u4_constrained_intra_pred = 0; ps_cfg->u4_pic_info_type = 0; ps_cfg->u4_mb_info_type = 0; - ps_cfg->s_vui.u1_video_signal_type_present_flag = 1; - ps_cfg->s_vui.u1_colour_description_present_flag = 1; + ps_cfg->s_vui.u1_video_signal_type_present_flag = 0; + ps_cfg->s_vui.u1_colour_description_present_flag = 0; return ret; }