wrapper/FFmpeg
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
No description
88227 commits 40 branches 405 tags 230 MiB
Find a file
Stefan Schoenefeld 31161bc969 avcodec/h263dec: fix hwaccel decoding 
Recently we encountered an issue when decoding a h.263 file:

FFmpeg will freeze when decoding h.263 video with NVDEC. Turns out this is not directly related to NVDEC but is a problem that shows with several other HW decoders like VDPAU, though the exact kind of error is different (either error messages or freezing[1]). The root cause is that ff_thread_finish_setup() is called twice per frame from ff_h263_decode_frame(). This is not supported by ff_thread_finish_setup() and specifically checked for and warned against in the functions code. The issue is also specific to hw accelerated decoding only as the second call to ff_thread_finish_setup() is only issued when hw acceleration is on. The fix is simple: add a check that the first call is only send when hw acceleration is off, and the second call only when hw acceleration is on (see attached patch). This works fine as far as I was able to test with vdpau and nvdec/nvcuvid hw decoding. The patch also adds NVDEC to the hw config list if available.

I also noticed a secondary issue when browsing through the code which is that, according to documentation, ff_thread_finish_setup() should only be called if the codec implements update_thread_context(), which h263dec does not. The patch does not address this and I'm not sure any action needs to be taken here at all.

[1] This is depending on whether or not the hw decoder sets the  HWACCEL_CAPS_ASYNC_SAFE flag

Signed-off-by: Timo Rothenpieler <timo@rothenpieler.org>
2019-08-04 16:24:54 +02:00
compat compat/cuda/ptx2c: strip CR from each line 2017-08-30 11:20:34 +02:00
doc Update for 3.4.6 2019-03-28 10:23:26 +01:00
ffbuild build: prevent SDL2 from polluting global cflags and extralibs 2017-10-09 21:41:11 -03:00
fftools fftools/ffmpeg: Repair reinit_filter feature 2019-03-24 10:38:51 +01:00
libavcodec avcodec/h263dec: fix hwaccel decoding 2019-08-04 16:24:54 +02:00
libavdevice avdevice/decklink_dec: Fix ;; 2018-06-18 01:16:03 +02:00
libavfilter avfilter/af_silenceremove: fix possible crash if supplied duration is negative 2019-01-25 01:01:42 +01:00
libavformat avformat/aacdec: resync to the next adts frame on invalid data instead of aborting 2019-07-23 01:13:41 -03:00
libavresample Bump minor versions for branching 3.4 2017-10-11 01:23:47 +02:00
libavutil avutil/mem: Fix invalid use of av_alloc_size 2019-07-23 01:18:40 -03:00
libpostproc postproc/postprocess_template: remove FF_REG_sp from clobber list 2019-03-24 10:38:51 +01:00
libswresample swresample/swresample: Fix input channel count in resample_first computation 2018-10-28 02:22:42 +02:00
libswscale Bump minor versions for branching 3.4 2017-10-11 01:23:47 +02:00
presets presets: remove moldering iPod presets 2014-06-17 16:15:04 -08:00
tests tests/fate/filter-video: increase fuzz for fate-filter-refcmp-psnr-rgb 2019-03-24 10:38:51 +01:00
tools tools/ismindex: remove unused header 2017-10-01 18:19:14 -03:00
.gitattributes fate: add SCC test 2017-01-27 17:06:42 +01:00
.gitignore build: add support for building .cu files via nvcc 2017-05-15 11:46:50 +02:00
.travis.yml build: Prefer NASM assembler over YASM 2017-06-21 17:00:30 -03:00
Changelog Update for 3.4.6 2019-03-28 10:23:26 +01:00
configure configure: bump year 2019-03-24 10:38:51 +01:00
CONTRIBUTING.md Add CONTRIBUTING.md 2016-09-18 10:02:13 +01:00
COPYING.GPLv2
COPYING.GPLv3
COPYING.LGPLv2.1
COPYING.LGPLv3
CREDITS
INSTALL.md INSTALL: add markdown syntax 2014-05-28 22:38:38 +02:00
LICENSE.md Merge commit '4fef648d10' 2017-03-15 22:07:47 +01:00
MAINTAINERS MAINTAINERS: change the decklink maintainer to myself 2017-10-04 22:44:42 +02:00
Makefile Makefile: generate stripped CLI tools directly instead of copying unstripped ones first 2017-10-10 19:45:14 +02:00
README.md Add CONTRIBUTING.md 2016-09-18 10:02:13 +01:00
RELEASE Update for 3.4.6 2019-03-28 10:23:26 +01:00
RELEASE_NOTES add release notes based on release 3.3 2017-10-11 03:11:33 +02:00

README.md

FFmpeg README

FFmpeg is a collection of libraries and tools to process multimedia content such as audio, video, subtitles and related metadata.

Libraries

  • libavcodec provides implementation of a wider range of codecs.
  • libavformat implements streaming protocols, container formats and basic I/O access.
  • libavutil includes hashers, decompressors and miscellaneous utility functions.
  • libavfilter provides a mean to alter decoded Audio and Video through chain of filters.
  • libavdevice provides an abstraction to access capture and playback devices.
  • libswresample implements audio mixing and resampling routines.
  • libswscale implements color conversion and scaling routines.

Tools

  • ffmpeg is a command line toolbox to manipulate, convert and stream multimedia content.
  • ffplay is a minimalistic multimedia player.
  • ffprobe is a simple analysis tool to inspect multimedia content.
  • ffserver is a multimedia streaming server for live broadcasts.
  • Additional small tools such as aviocat, ismindex and qt-faststart.

Documentation

The offline documentation is available in the doc/ directory.

The online documentation is available in the main website and in the wiki.

Examples

Coding examples are available in the doc/examples directory.

License

FFmpeg codebase is mainly LGPL-licensed with optional components licensed under GPL. Please refer to the LICENSE file for detailed information.

Contributing

Patches should be submitted to the ffmpeg-devel mailing list using git format-patch or git send-email. Github pull requests should be avoided because they are not part of our review process and will be ignored.