From 96ab00656674da7efd95d2f86a93811d818ee38e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Kacper=20Michaj=C5=82ow?= Date: Sat, 26 Jul 2025 04:55:12 +0200 Subject: [PATCH] avformat/ffmetadec: don't compare undefined string MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Fixes use-of-uninitialized-value when bp.len == 0. Signed-off-by: Kacper Michajłow --- libavformat/ffmetadec.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavformat/ffmetadec.c b/libavformat/ffmetadec.c index bfda7d0bd8..69c93e6b3b 100644 --- a/libavformat/ffmetadec.c +++ b/libavformat/ffmetadec.c @@ -182,7 +182,7 @@ static int read_header(AVFormatContext *s) while(!avio_feof(s->pb)) { get_bprint_line(s->pb, &bp); - if (!memcmp(bp.str, ID_STREAM, strlen(ID_STREAM))) { + if (bp.len == strlen(ID_STREAM) && !memcmp(bp.str, ID_STREAM, strlen(ID_STREAM))) { AVStream *st = avformat_new_stream(s, NULL); if (!st) @@ -192,7 +192,7 @@ static int read_header(AVFormatContext *s) st->codecpar->codec_id = AV_CODEC_ID_FFMETADATA; m = &st->metadata; - } else if (!memcmp(bp.str, ID_CHAPTER, strlen(ID_CHAPTER))) { + } else if (bp.len == strlen(ID_CHAPTER) && !memcmp(bp.str, ID_CHAPTER, strlen(ID_CHAPTER))) { AVChapter *ch = read_chapter(s); if (!ch)