From 7e8306dd2da54fa499ea79a74f0ba81507e6c9d4 Mon Sep 17 00:00:00 2001 From: Andreas Rheinhardt Date: Thu, 5 Nov 2020 21:35:56 +0100 Subject: [PATCH] avcodec/gdv: Remove dead check At the end of its decode function, the decoder sets *got_frame to 1 and then checks whether ret is < 0; if so, it is returned, otherwise avpkt->size is. But it is impossible for ret to be < 0 here and if it were, it would be nonsense to set *got_frame to 1 before this. Therefore just return avpkt->size unconditionally. Fixes Coverity issue #1439730. Reviewed-by: Paul B Mahol Signed-off-by: Andreas Rheinhardt --- libavcodec/gdv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/gdv.c b/libavcodec/gdv.c index f00f3ac145..2be1e2ea7f 100644 --- a/libavcodec/gdv.c +++ b/libavcodec/gdv.c @@ -551,7 +551,7 @@ static int gdv_decode_frame(AVCodecContext *avctx, void *data, *got_frame = 1; - return ret < 0 ? ret : avpkt->size; + return avpkt->size; } static av_cold int gdv_decode_close(AVCodecContext *avctx)