diff --git a/libavcodec/x86/opus_dsp_init.c b/libavcodec/x86/opus_dsp_init.c index c51f786ee8..a9f8a96159 100644 --- a/libavcodec/x86/opus_dsp_init.c +++ b/libavcodec/x86/opus_dsp_init.c @@ -24,9 +24,9 @@ #include "libavutil/x86/cpu.h" #include "libavcodec/opus_pvq.h" -extern float ff_pvq_search_sse2(float *X, int *y, int K, int N); -extern float ff_pvq_search_sse4(float *X, int *y, int K, int N); -extern float ff_pvq_search_avx (float *X, int *y, int K, int N); +extern float ff_pvq_search_approx_sse2(float *X, int *y, int K, int N); +extern float ff_pvq_search_approx_sse4(float *X, int *y, int K, int N); +extern float ff_pvq_search_exact_avx (float *X, int *y, int K, int N); av_cold void ff_opus_dsp_init_x86(CeltPVQ *s) { @@ -34,12 +34,12 @@ av_cold void ff_opus_dsp_init_x86(CeltPVQ *s) #if CONFIG_OPUS_ENCODER if (EXTERNAL_SSE2(cpu_flags)) - s->pvq_search = ff_pvq_search_sse2; + s->pvq_search = ff_pvq_search_approx_sse2; if (EXTERNAL_SSE4(cpu_flags)) - s->pvq_search = ff_pvq_search_sse4; + s->pvq_search = ff_pvq_search_approx_sse4; - if (EXTERNAL_AVX(cpu_flags)) - s->pvq_search = ff_pvq_search_avx; + if (EXTERNAL_AVX_FAST(cpu_flags)) + s->pvq_search = ff_pvq_search_exact_avx; #endif } diff --git a/libavcodec/x86/opus_pvq_search.asm b/libavcodec/x86/opus_pvq_search.asm index 2f4864c95c..8cf040465d 100644 --- a/libavcodec/x86/opus_pvq_search.asm +++ b/libavcodec/x86/opus_pvq_search.asm @@ -82,7 +82,7 @@ SECTION .text %endif %endmacro -%macro PULSES_SEARCH 1 +%macro PULSES_SEARCH 2 ; %1 - add or sub, %2 - use approximation ; m6 Syy_norm ; m7 Sxy_norm addps m6, mm_const_float_0_5 ; Syy_norm += 1.0/2 @@ -96,7 +96,7 @@ align 16 movaps m4, [tmpY + r4] ; y[i] movaps m5, [tmpX + r4] ; X[i] -%if !cpuflag(avx) ; for crappy ancient CPUs that have slow packed divs but fast 1/sqrt +%if %2 xorps m0, m0 cmpps m0, m0, m5, 4 ; m0 = (X[i] != 0.0) %endif @@ -104,7 +104,7 @@ align 16 addps m4, m6 ; m4 = Syy_new = y[i] + Syy_norm addps m5, m7 ; m5 = Sxy_new = X[i] + Sxy_norm -%if !cpuflag(avx) +%if %2 andps m5, m0 ; if(X[i] == 0) Sxy_new = 0; Prevent aproximation error from setting pulses in array padding. %endif @@ -119,7 +119,7 @@ align 16 andps m5, m0 ; (0 0 %%add_pulses_loop: - PULSES_SEARCH add ; m6 Syy_norm ; m7 Sxy_norm + PULSES_SEARCH add, %1 ; m6 Syy_norm ; m7 Sxy_norm sub Kd, 1 jnz %%add_pulses_loop @@ -320,7 +325,7 @@ align 16 ; K - pulses > 0 align 16 %%remove_pulses_loop: - PULSES_SEARCH sub ; m6 Syy_norm ; m7 Sxy_norm + PULSES_SEARCH sub, %1 ; m6 Syy_norm ; m7 Sxy_norm add Kd, 1 jnz %%remove_pulses_loop @@ -367,12 +372,15 @@ align 16 jmp %%return %endmacro - +; if 1, use a float op that give half precision but execute for around 3 cycles. +; On Skylake & Ryzen the division is much faster (around 11c/3), +; that makes the full precision code about 2% slower. +; Opus also does use rsqrt approximation in their intrinsics code. INIT_XMM sse2 -PVQ_FAST_SEARCH +PVQ_FAST_SEARCH 1 INIT_XMM sse4 -PVQ_FAST_SEARCH +PVQ_FAST_SEARCH 1 INIT_XMM avx -PVQ_FAST_SEARCH +PVQ_FAST_SEARCH 0