wrapper/FFmpeg
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

avfilter/vf_hwdownload: Fix leak of formats list upon error

Browse source 
If adding the list of input formats to its AVFilterLink fails, the list
of output formats (which has not been attached to permanent storage yet)
leaks. This has been fixed by not creating the lists of in- and output
formats simultaneously. Instead creating said lists is relegated to
ff_formats_pixdesc_filter() (this also avoids the reallocations implicit
in using ff_add_format()) and the second list is only created after (and
if) the first list has been permanently attached to its AVFilterLink.

Reviewed-by: Nicolas George <george@nsup.org>
Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@gmail.com>
This commit is contained in:
Andreas Rheinhardt 2020-08-07 23:40:43 +02:00
parent 2a471af50a
commit 257cd5fa38
1 changed files with 5 additions and 18 deletions
Download patch file Download diff file Expand all files Collapse all files

23
libavfilter/vf_hwdownload.c
View file

@ -37,26 +37,13 @@ typedef struct HWDownloadContext {
static int hwdownload_query_formats(AVFilterContext *avctx)
{
AVFilterFormats *infmts = NULL;
AVFilterFormats *outfmts = NULL;
const AVPixFmtDescriptor *desc;
AVFilterFormats *fmts;
int err;
for (desc = av_pix_fmt_desc_next(NULL); desc;
desc = av_pix_fmt_desc_next(desc)) {
if (desc->flags & AV_PIX_FMT_FLAG_HWACCEL)
err = ff_add_format(&infmts, av_pix_fmt_desc_get_id(desc));
else
err = ff_add_format(&outfmts, av_pix_fmt_desc_get_id(desc));
if (err) {
ff_formats_unref(&infmts);
ff_formats_unref(&outfmts);
return err;
}
}
if ((err = ff_formats_ref(infmts, &avctx->inputs[0]->out_formats)) < 0 ||
(err = ff_formats_ref(outfmts, &avctx->outputs[0]->in_formats)) < 0)
if ((err = ff_formats_pixdesc_filter(&fmts, AV_PIX_FMT_FLAG_HWACCEL, 0)) ||
(err = ff_formats_ref(fmts, &avctx->inputs[0]->out_formats)) ||
(err = ff_formats_pixdesc_filter(&fmts, 0, AV_PIX_FMT_FLAG_HWACCEL)) ||
(err = ff_formats_ref(fmts, &avctx->outputs[0]->in_formats)))
return err;
return 0;